4820a863a9
[Avatar] Fix cache usage and other minor bugs
2021-09-23 14:34:34 +01:00
a557ba0224
[Timelines][Plugins][Left] Plugins now provide their path ID. Feed redone as it's own independant template.
2021-09-22 16:47:06 +01:00
05f16a3084
[ENTITY][AttachmentThumbnail] Now thumbnails are always only available in three sizes: small, medium, big
...
Commit jointly produced with eli (Eliseu Amaro)
Breaking change: Entity changed to only store the tinyint referring to the size stored
With this, the logic was simplified and now it's not possible to make an
instance produce unnecessary thumbs. The aspect ratio is preserved and
thus the thumbs will always look nice. New configuration was added to
maintain flexibility.
2021-09-22 15:13:46 +01:00
7beb5c2995
[GSFile] Fix sanitize configuration
2021-09-22 15:13:46 +01:00
69e7dc44bd
[ENTITY][Note] Change isVisibleTo to allow for not supplying an actor
2021-09-21 16:38:50 +01:00
879f54c772
[CACHE] Filter notes by scope in pagedStream
...
This currently does not return a fixed number of notes per page. Fixing this is left as an exercise to the reader
2021-09-21 16:37:51 +01:00
14c173df7a
[CACHE][COMPONENT][Tag] Add generic Cache::pagedStream and use it for the tag stream. Note that it doesn't respect scope yet
2021-09-21 15:35:07 +01:00
6715a036e9
[CACHE] Add way to fetch limit,offset values from a list
2021-09-21 11:04:26 +01:00
ce80065775
[DB] Add mechanism for specifying limit and offset in dql query
2021-09-21 11:04:26 +01:00
91fd7d1cfa
[CONFIG][CORE] Fix bug in overriding default config
2021-09-21 11:04:14 +01:00
8bb6285522
[ENTITY][Note] A note may have no content
2021-09-20 17:06:21 +01:00
b7298eaa44
[ENTITY] ActorTag: use getter for tag name on toString
2021-09-20 17:05:50 +01:00
8fe8687c5b
[UTIL][HTML] Move to a unified array
2021-09-20 13:28:18 +01:00
e8f4563633
[UTIL][Formatting][COMPONENT][Link][Tag] Refactor code from formatting into Link and Tag, where appropriate. Drop 'perfect url regex' as the one used in v2 is better
2021-09-20 13:28:18 +01:00
556b8f8265
[ENTITY][NoteTag] Add 'canonical' field to tag
2021-09-20 13:27:27 +01:00
04174bc56d
[UTIL][UI] Change how plaintext notes are rendered to be split into paragraphs. Remove span around tags
2021-09-20 13:27:27 +01:00
51c7e10483
[UTIL][HTML] Allow specifying options: [raw => bool], whether to escape the provided inner HTML or not. Use with care
2021-09-20 13:27:21 +01:00
67d62cf37b
[TWIG] Remove kludge event TwigPopulateVars
2021-09-18 07:27:35 +01:00
fda998e335
[Avatar] We definitely don't need an event to retrieve avatar urls
2021-09-18 07:26:10 +01:00
2bd19fa087
[NOTE][Posting] Revert regressions introduced with c90efe2c52
...
Entity Note: It doesn't make sense to handle attachments on Note::create.
Attachments exist out of Notes, they are a thing on their own.
Furthermore, they aren't always handled the same, they most definitely
aren't always uploaded files.
FileQuota: It doesn't make sense to check if a file is greater than max
allowed upload size here. The plugin ensures a user is inside his
allowed quota, it's ignorant to anything else. Whether a file respect
max upload is a core thing that must be handled directly in the Posting
component. TODO: The configuration regarding user and monthly quota
must become FileQuotaPlugin settings and be removed from core.
c90efe2c52 - [UI] Add mechanism for rendering note contents in different formats. Implement plaintext rendering. Use rendered field for note content, rather than the content itself
2021-09-18 05:12:18 +01:00
941cbe6599
[Actor] Refactor GSActor into Actor
2021-09-18 05:12:17 +01:00
d6f31d102a
[CORE][ActivityStreamsTwo][ActivityPub] Set all routes
...
Allow global routes to act for every actor
Fix Favoured stream query
2021-09-18 05:12:15 +01:00
b177cb69e7
[HTML][SECURITY] Harden implmentation of HTML generation
2021-09-18 05:12:08 +01:00
8f0a3e4977
[UI] Add mechanism for rendering note contents in different formats. Implement plaintext rendering. Use rendered field for note content, rather than the content itself
2021-09-18 05:12:06 +01:00
f344ed376c
[ATTACHMENTS][Embed][UI] Allow plugins to provide a title for an attachment, if a note has none, implement such a mechanism in Embed and cache the result, since it is potentially costly
2021-09-18 05:12:06 +01:00
15a2a69274
[ROUTER] Add option is_system_path, to allow specifying that a route, such as gsactor_view_nickname should not be considered a system path, when checking for the collision of nicknames
2021-09-18 05:12:05 +01:00
e563c393f8
[ROUTER] Add mechanism for sorting the order in which core routes are loaded
2021-09-18 05:12:05 +01:00
e9d809d441
[Security][Exception] Security exception handling, login and register. TODO EmailNotFoundException and NicknameNotFoundException.
2021-09-15 14:48:06 +01:00
26af284353
[CONTROLLER][SECURITY] Registration feedback. The flashError works. However, Symfony's Exception error page is viewed upon trying to register.
2021-09-15 14:48:06 +01:00
365edbaff0
[ActivityStreamsTwo] Initial Actor support
...
Various bug fixes
2021-09-15 10:26:53 +01:00
1adde913c6
[PHPStan] Only run custom PHPStan extensions if environment vairable PHPSTAN_BOOT_KERNEL is defined (since it requires having the whole social setup available)
2021-09-14 13:13:45 +01:00
7c465bba5f
[NOTE] Add mimetype to notes
2021-09-14 13:13:45 +01:00
c69b28d894
[CORE] Fix Undefined array key 0 in DB::filterTableName
2021-09-14 13:13:45 +01:00
b74d944ae3
[TOOLS][PHPStan] Raise PHPStan level to 3 and fix new errors
2021-09-14 13:13:45 +01:00
f81bf4a257
[TOOLS][PHPStan] Add mechanism for initializing the whole application
2021-09-14 13:13:44 +01:00
ddb9702b1c
[TOOLS][PHPStan] Add support for deducing the correct entity type from a table name. Needs refactoring and can only run inside container, as it connects to the database itself
2021-09-14 13:13:44 +01:00
4e30e5aad9
[TOOLS] Fix all issues found by PHPStan level 2
2021-09-14 13:13:44 +01:00
61071a6821
[PLUGINS][Reply][Repeat][Favourite] Base template semantic rework. Reply, repeat and favourite respective classes are now assigned in their NoteHandlerPlugin.
2021-09-14 13:13:43 +01:00
ddd2ffe26a
[TWIG] Add extension to check if Firefox is being used
2021-09-14 13:13:43 +01:00
add8f4a52f
[TOOLS] Fix all errors found by PHPStan level 1
2021-09-14 13:13:42 +01:00
277a080d7c
[EXCEPTION] Add NotImplementedException
2021-09-14 13:13:42 +01:00
eb833b62e2
[TOOLS] Fix all level 0 errors found by PHPStan and move constant definition to bootstrap file
2021-09-14 13:13:42 +01:00
f65e2b90f2
[CORE] Fix use of Exception class without import
2021-09-14 13:13:41 +01:00
cbbef90752
[UTIL][CONFIG] Ensure setConfig uses a locals key
2021-09-14 13:13:41 +01:00
4916c8cbda
[CONTROLLER][AdminPanel] Add missing Exception import
2021-09-14 13:13:41 +01:00
e8ae0b74e0
[CORE][Controller] Switch order for content negotiation: allow events to take precedence. Bring back default JSON response
2021-09-14 13:13:41 +01:00
cd89106fc0
[EXCEPTION][RedirectException] Add prevention for open redirects by default and ensure we can redirect to the same page
2021-09-14 13:13:40 +01:00
16cde6dfd7
[PLUGINS][Reply] Redirect back to previous URL on note reply. Move controller to own class
...
This should be safe against open redirects, as it doesn't allow redirecting to other domains
2021-09-14 13:13:40 +01:00
0a7fd9c460
[CORE][MODULES][NoteHandlerPlugin] Add missing import for Event
2021-09-14 13:13:40 +01:00
1d5fd1aefa
[CORE][Controller] Fix Controller::__invoke so it actually passes on the route parameters to the controller method. Add Controller->string, which gets a query parameter as a string value, or null if not set
2021-09-14 13:13:40 +01:00
330143e549
[ROUTER][DOCUMENTATION] Add Router::isAbsolute, add documentation to Router::url and `s/setRouter/serServices/
2021-09-14 13:13:39 +01:00
be27a10244
[EVENTS] Rename event RouteInFormat to ControllerResponseInFormat
2021-09-14 13:13:39 +01:00
983e0303a5
[ROUTER] Sort routes so that the one with a smaller list of Accept types matches first
...
This requires a copy, but gets cached, so it's the ideal place to do it.
Note that only routes that match the incoming Accept match anyway, so the order between those with different accept types is not relevant
2021-09-14 13:13:39 +01:00
45734d882c
[CONFIG] Make it possible to write module configuration in a config.{php,yml,yaml,xml} file and set each value as properties in the module object
2021-09-14 13:13:38 +01:00
e4aa3ae968
[NOTE] Add route and controller
2021-09-14 13:13:37 +01:00
fd3b57dc24
[CORE][Controller] Make it possible for plugins to add different content-types to existing routes
2021-09-14 13:13:37 +01:00
626f50080b
[MODULES] Use snake_case for module config keys
2021-09-14 13:13:37 +01:00
033c4db914
[MODULES] Add function to defer module initialization and cleanup to plugin and component. Add example in Avatar component
...
Forward onInitializeModule to onInitializePlugin if the component is a plugin
2021-09-14 13:13:37 +01:00
bda839be7b
[MODULES] Add InitiializeModule and CleanupModule events, similar to v2
2021-09-14 13:13:37 +01:00
1ee8df1494
[DOCS][Developer] Elaborate on implementing and configuring a module
2021-09-14 13:13:37 +01:00
141f919ca7
[CONFIG][TESTS] Fix error found by AdminPanel test
2021-09-14 13:13:36 +01:00
c71a4b06ef
[CONFIG] Make it possible to write module configuration in a config.{php,yml,yaml,xml} file and set each value as properties in the module object
2021-09-14 13:13:36 +01:00
3587b8dc1d
[CONFIG] Refactor configuration loading
2021-09-14 13:13:36 +01:00
2fdd0b0820
[TESTS][DataFixtures] Use Temporary file instead of an ad-hoc solution to copy the upload files
2021-09-14 13:13:36 +01:00
2b457655ea
[CORE] Fix path configuration
2021-09-14 13:13:35 +01:00
e7b985a460
[FIXTURES] Catch any exception, we don't have VIPS-related only
2021-09-14 13:13:35 +01:00
f9079784c4
[ENTITY][AttachmentThumbnail] Improve the way EncoderPlugins participate in the thumbnail process
2021-09-14 13:13:35 +01:00
bc1fb007aa
[Core][GSFile] Improve the way EncoderPlugins participate in the file sanitization process
2021-09-14 13:13:34 +01:00
210f895e74
[ENTITY][Attachment] Respect rfc6838#section-4.2 mimetype length
2021-09-14 13:13:34 +01:00
2a3db65216
[CONTROLLER][Attachment] Some attachments may not have dimensions
2021-09-14 13:13:34 +01:00
26bf78360b
[ROUTER][UTIL] Allow specifying the Accept format for a route
2021-09-14 13:13:34 +01:00
811caaadf9
[MODULES][PLUGINS] Move noteActionHandle utility to NoteHandlerPlugin which plugins which handle actions on notes should extend
2021-09-14 13:13:34 +01:00
458b6d0009
[UI] Rename all forms to more specific names, to avoid form name collisions
2021-09-14 13:13:33 +01:00
6af1383e07
[UTIL][Form] Disallow using very generic form names, as they can collide with other forms in the same page
2021-09-14 13:13:33 +01:00
4cd3924cc1
[ATTACHMENTS][AttachmentThumbnail] Fix implementation of predictScalingValues and small fixes
2021-09-14 13:13:32 +01:00
2ccbbd53a6
[TESTS] Add code coverage annotations to entities
2021-09-14 13:13:32 +01:00
79215bc439
[Note] Fix scope check for group notes, move away from SQL, to DQL
2021-09-14 13:13:32 +01:00
e392a9c90c
[TESTS][DataFixtures] Add user, self follows, group member and group scope note
2021-09-14 13:13:32 +01:00
4b2a92d052
[UI][Attachment] Use Attachment methods to get the proper URL, rather than crafting it in a template
2021-09-14 13:13:32 +01:00
6799052ff5
[ATTACHMENTS] Ensure thumbnail dimensions are bounded and change way cropping is implemented
2021-09-14 13:13:32 +01:00
b50f11a040
[ENTITY][Link] self urls can't be considered a remote url
2021-09-14 13:13:31 +01:00
5c8677304c
[DOCS][Developer] Update storage documentation
2021-09-14 13:13:31 +01:00
e2e6c7a5bf
[TESTS] Hot-fix Security controller tests, broken with ongoing form rendering changes
2021-09-14 13:13:30 +01:00
44a581f0f6
[UTIL][FORM] Password form now shows the proper HTML class, and it's respective label.
2021-09-14 13:13:30 +01:00
87d7318de5
[CONTROLLER][SECURITY] Added class names. Help labels for each form element. Each form element now has a proper block prefix (the resulting HTML won't simply concatenate the form's name to the element's label).
2021-09-14 13:13:30 +01:00
ebee70621b
[FORM] Fix bug where options were passed in the data parameter
2021-09-14 13:13:30 +01:00
4f880eb761
[PLUGINS][ENTITY][Cover][ProfileColor] Clean up after interns and move entity defintions to be inside the corresponding plugin, rather than in core
2021-09-14 13:13:29 +01:00
2351e7c6d1
[CORE][GSFile] Use pathinfo rather than regular expressions and don't attempt to persist an already persisted entity
2021-09-14 13:13:28 +01:00
3843348c1b
[CONTROLLER][Attachment] Small refactor and add testing annotation
2021-09-14 13:13:28 +01:00
e2caf19b67
[TESTS] Remove copied upload test files, if upload failed
2021-09-14 13:13:28 +01:00
aef61e4c73
[TESTS] Add coverage ignore flags to trivial methods
2021-09-14 13:13:28 +01:00
fe86735b8b
[DB][DOCUMENTATION] Explain limit: 2 in findOneBy
2021-09-14 13:13:28 +01:00
c3db2f60d2
[UTIL][EXCEPTIONS] Introduce NotStoredLocallyException
2021-09-14 13:13:28 +01:00
6445a616a8
[ENTITY][Attachment] Raise mimetype max length to 64 characters and ensure we don't attempt to store more than that
2021-09-14 13:13:28 +01:00
d4d4f4e950
[TESTS] Cleanup attachment test data
2021-09-14 13:13:27 +01:00
6e6d1a946f
[TESTS] Remove MediaFileTest and move setup code to media data fixture
2021-09-14 13:13:27 +01:00
53f89ade85
[TESTS] Move Media fixtures to their own file, for organization
2021-09-14 13:13:27 +01:00
74d1874991
[DOCUMENTATION][Entity] Improve documentation on Entity::getWithPK, explaining the ways it can be used
2021-09-14 13:13:27 +01:00
060a5abef1
[ENTITY][Link] Sometimes URLs don't work, handle that
2021-09-14 13:13:27 +01:00
f690bc06ae
[ATTACHMENT] Some attachments don't have thumbnails and that's okay
2021-09-14 13:13:27 +01:00
b4a03b814f
[CORE][GSFile] ensureFilenameWithProperExtension: extension isn't an I/O param
2021-09-14 13:13:26 +01:00
728f8d8fb8
[ENTITY][Note] Add getter for note links
2021-09-14 13:13:26 +01:00
9e4cac0123
[ENTITY] Refactor RemoteURL entities to Link
...
RemoteURL was being an awfully confusing term.
2021-09-14 13:13:26 +01:00
968e3431e1
[Attachment] Sometimes we can't provide download of original file
2021-09-14 13:13:26 +01:00
4cc4523632
[Posting] Re-add original file to attachment on upload, if it was previously removed
2021-09-14 13:13:26 +01:00
d076781c74
[AttachmentToNote][Attachment] Add title getter to Attachment
2021-09-14 13:13:26 +01:00
bac18715c5
[StoreRemoteMedia] Implement the first version of it in v3
2021-09-14 13:13:25 +01:00
63cbf4052f
[UTIL] Common::config wasn't a proper port from v2, it has to accept one argument only as well
2021-09-14 13:13:25 +01:00
33cc9386d2
[RemoteURLToAttachment] Fix primary key, relation is: One Attachment Has Many URLs, One URL Has One Attachment
2021-09-14 13:13:25 +01:00
78c5c4b084
[Attachment] Allow to delete the associated file
2021-09-14 13:13:25 +01:00
508f1f8796
[MODULES] Add module configuration
2021-09-14 13:13:25 +01:00
de8a2f579c
[CORE][Event] Fix bug on handler Log
2021-09-14 13:13:25 +01:00
4ecdeac6a3
[CORE][Entity] Compare with object properties when creating/updating, instead of class
2021-09-14 13:13:25 +01:00
75f70f8182
[ENTITY][Posting] Remove GSActorToRemoteURL, Fix URL database store
2021-09-14 13:13:25 +01:00
f5175cc59d
[ATTACHMENTS] Always store in the same location
2021-09-14 13:13:24 +01:00
3f61537140
[ENTITY] Split Attachment in various new entities
...
Remove Attachment Scope
Fixed some minor bugs
Scope will be implemented later in v3. It doesn't make sense to have
the scope handling being per attachment. Different actors can post
the same attachment with different scopes. The attachment controller
will assume the highest level of scope applied to the attachment and
the rest will be handled at the note level.
Motivation:
* Remove title from attachment, as it's part of the relation between attachment and note.
* Remove actor from attachment, many actors may publish the same attachment.
* Remove is_local from attachment, as it's part of the relation between attachment and note.
* Remove remote_url from attachment, different urls can return the same attachment.
Addition:
* Attachment now has a lives attribute, it's a reference counter with a nicer name
* GSActorToAttachment
* GSActorToRemoteURL
* RemoteURL
* RemoteURLToNote
* RemoteURLToAttachment
* AttachmentToNote now has a title attribute
2021-09-14 13:13:24 +01:00
39006fb6b5
[DB][Attachments] Use count function rathar than fetch and count, rename to refCount, rather than countDepencies
2021-09-14 13:13:24 +01:00
809bf00aa9
[TemporaryFile][TESTS] Throw on attempt to write to null resource and fix tests
2021-09-14 13:13:24 +01:00
6728dd40b0
[ENTITY] Add JsonSerializable interface to Entity base class and implement it for the Note class
2021-09-14 13:13:24 +01:00
2851b899b8
[TESTS] Add test annotations to core classes
2021-09-14 13:13:23 +01:00
21a5bbe639
[CORE][Controller] Fix JSON response and add test annotations
2021-09-14 13:13:23 +01:00
061a85d6b3
[EVENTS] Change FormatNoteList do separate in and out arguments
...
This is necessary due to some weird problem which I wasn't able to figure out (but which doesn't matter)
that somehow causes the event to be called twice during testing, and thus the function was exploding
2021-09-14 13:13:23 +01:00
b5de80303a
[TEST] Raise test coverage for UserPanel to 100%
2021-09-14 13:13:23 +01:00
480665afc8
[CONTROLLER][UserPanel] Finish implementation of ::notifications so it actually saves the values in the database
2021-09-14 13:13:23 +01:00
cdf3426567
[CONTROLLR][UserPanel][PLUGINS] Add submit button to notification settings for each transport
2021-09-14 13:13:23 +01:00
afbcb179b2
[CONTROLLER][AdminPanel] Further ensure form validity
2021-09-14 13:13:23 +01:00
38a331220f
[CORE][Log] Add Log::unexpected_exception utility which logs and throws a ServerException
2021-09-14 13:13:23 +01:00
085e880631
[CORE][Entity] Fix implementation of createOrUpdate so it doesn't throw NotFoundException if trying to create an object
...
This was previously done because we wanted to notify the callee that
and entity existed but not with the provided contents. With the change
of return value, with a bool $is_update, this is no longer a problem.
2021-09-14 13:13:22 +01:00
1b623a85ae
[UTIL][FormFields] Move FormFields class to Util\Form namespace
2021-09-14 13:13:22 +01:00
1647c5391f
[Favourite][TWIG][CSS] Favourite now works.
2021-09-14 13:13:22 +01:00
21362d1e4d
[ATTACHMENTS] Add dependencies counter
2021-09-14 13:13:21 +01:00
3334aca7b9
[Avatar] Move entity from core to component
2021-09-14 13:13:20 +01:00
fb6aa78ae8
[CORE][GSFile] Allow storing files under /file
2021-09-14 13:13:20 +01:00
e688bf8aed
[TESTS] Ignore coverage of ResetPasswordRequest, as it uses mailing functionality. We may want to introduce this test in the future
2021-09-14 13:13:20 +01:00
9ad2cb5e66
[UTIL][FormFields] Allow specifying whether a password is required and provide placeholder text
2021-09-14 13:13:20 +01:00
5aedf64e5b
[ROUTES] Remove individual settings pages, as they got merged
2021-09-14 13:13:20 +01:00
27f2fbdade
[ENTITY] Refactor LocalUser::changePassword for easier use
2021-09-14 13:13:20 +01:00
19318b3163
[UTIL][EXCEPTION] Add AuthenticationException, representing an auth error, status code 401 unauthorized
2021-09-14 13:13:20 +01:00
a1592656e0
[TESTS] Change format of data fixtures to allow creating more users
2021-09-14 13:13:20 +01:00
2dd3511149
[CORE][DB] Specify desired case in array_change_case, for clarity
2021-09-14 13:13:19 +01:00
0ae67d96ea
[TESTS] Raise test coverage for AdminPanel to 100%
2021-09-14 13:13:19 +01:00
b77e35ef09
[SECURITY] Do not require email when in development
2021-09-14 13:13:19 +01:00
fe7c2b5115
[TESTS] Raise test coverage for AdminPanel controller to 100%
2021-09-14 13:13:19 +01:00
e0a0df502e
[TESTS] Raise test coverage for Attachment controller to 100%
2021-09-14 13:13:19 +01:00
29d77b446f
[TESTS] Add a sample image to the test dataset
2021-09-14 13:13:19 +01:00
647e4c03b3
[CORE][GSFile] Ensure files are stored inside the configured storage folder, with a relative filename in the database
2021-09-14 13:13:19 +01:00
51f8f004b3
[CORE][CONTROLLER] Add TODO to Controller base class as to where our custom exception pages would be implemented
2021-09-14 13:13:18 +01:00
0b80727769
[CORE][ENTITY] Allow create'ing will null values
2021-09-14 13:13:18 +01:00
855d427442
[UTIL][FORM] Create a utility class that defines common form fields, such as passwords
2021-09-14 13:13:18 +01:00
dfc97d2607
[TESTS] Raise test coverage for Controller/Security to 100%
2021-09-14 13:13:18 +01:00
dc2b9f940e
[CORE][GSFile] Assert that the destination folder where to store the attachment is inside the INSTALLDIR and store the filepath in the database
2021-09-14 13:13:18 +01:00
8139a21eb9
[TESTS] Add coverage ignore to TemplateController and ResetPassword (as it requires sending emails)
2021-09-14 13:13:18 +01:00
518995d155
[CONTROLLER][Attachment] Assert that the supplied is positive and add documentation
2021-09-14 13:13:17 +01:00
88dd9e542f
[CORE][GSFile] Change actor_id paramenter of validateAndStoreFileAsAttachment to optional and reorder them and their usages
2021-09-14 13:13:17 +01:00
7bd88bd101
[AUTOGENERATED] Update entity fields for ResetPasswordRequest entity
2021-09-14 13:13:17 +01:00
471dc52c92
[CORE] Add repositories, as needed by the Reset Password Bundle
2021-09-14 13:13:17 +01:00
0c54a3297f
[UTIL] Add a class that defines commonly used form fields
2021-09-14 13:13:17 +01:00
ccd5ebf8e4
[CORE] Add passowrd reset and forgot password functionality
2021-09-14 13:13:17 +01:00
769fff2448
[CORE][SECURITY][EMAIL] Move email confirmation functionality to it's own static wrapper, in preparation for adding password reset functionality
2021-09-14 13:13:17 +01:00
e27823ae6c
[CONTROLLER][Security] Refactor and make clearer errors with duplicate nicknames and emails. Return notes as a callable, since they're not used in the default template, in the login and register pages
2021-09-14 13:13:17 +01:00
32ca61e214
[TESTS][Queue] Add @codeCoverageIgnore to select queueing functions
2021-09-14 13:13:16 +01:00
41e4e2de0e
[TESTS][Router] Add tests for Router and use named paramenters, as we can since PHP8
2021-09-14 13:13:16 +01:00
6d22932092
[ENTITY][LocalUser] Add method 'findByNicknameOrEmail'
2021-09-14 13:13:16 +01:00
e6d20bd30d
[CORE][Controller][TESTS] Fix issue that arrises in tests where the Accept header is not specified
2021-09-14 13:13:16 +01:00
d07cb79844
[EXCEPTION] Add Email related exceptions
2021-09-14 13:13:16 +01:00
e250edf7fd
[UTIL][Nickname] Refactor Nickname and extract a validate function, as we'll want to perform normalization in select cases in the future, likely as a plugin
2021-09-14 13:13:16 +01:00
f904b76ce7
[TESTS][DataFixtures] Add password and email to created test user
2021-09-14 13:13:16 +01:00
efacf6da56
[TESTS][Twig] Add @codeCoverageIgnore to select methods, as these are simple wrappers
2021-09-14 13:13:16 +01:00
e77498ac19
[ENTITY] Remove 'normalized_nickname' field from GSActor as that feature will be moved to a plugin
2021-09-14 13:13:15 +01:00
2f69579ddb
[TESTS][DOCUMENTATION][Module] Add documentation and exclude method from testing in Module base class
2021-09-14 13:13:15 +01:00
7a2574eafb
[CORE][TemporaryFile] Add option to specify attempts and better handle when reaching the attemp limit without being able to create a file
2021-09-14 13:13:15 +01:00
f5fb4ed3c3
[TESTS] Add tests for GSFile
2021-09-14 13:13:15 +01:00
af5526d720
[DB] Refactor findOneBy method
2021-09-14 13:13:15 +01:00
7263752b18
[TESTS][DOCUMENTATION] Add documenation for the list events command and exclude it from unit testing
2021-09-14 13:13:15 +01:00
1c09aefd5a
[CONFIG] Make password length limits configurable
2021-09-14 13:13:14 +01:00
de5650e98e
[TESTS] Exclude class Security from testing, as it's a simple wrapper
2021-09-14 13:13:14 +01:00
d609dafdbc
[TESTS] Raise test coverage for ModuleManager to 100%
2021-09-14 13:13:14 +01:00
bd321f05a7
[TESTS] Exclude HTTPClient from testing, as it's a simple wrapper and we don't want to be performing HTTP requests in tests, for speed and reliability
2021-09-14 13:13:14 +01:00
2ee99e5176
[TESTS] Raise test coverage for Form to 100%
2021-09-14 13:13:14 +01:00
3b18853ff1
[TESTS][LOG] Raise test coverage for Log class to 100%
2021-09-14 13:13:14 +01:00
f98ce1c3d0
[TESTS] Ignore GNUsocial class from tests, as it simply pipes objects around
2021-09-14 13:13:13 +01:00
3cc1756d1b
[FORM][DOCUMENTATION] Add documentation to Form class
2021-09-14 13:13:13 +01:00
f9a022745e
[EVENT] Fixup implementation, as imformed by tests
2021-09-14 13:13:13 +01:00
d22711504c
[ENTITY] Fixup implementation, as imformed by tests
2021-09-14 13:13:13 +01:00
8317c612ff
[DB] Handle using methods with class name as well as table name and add lookup methods
2021-09-14 13:13:13 +01:00
bfe9c6c9c4
[TESTS] Add ignore annotations to code paths that serve as hooks in DependencyInjection
2021-09-14 13:13:13 +01:00
28c010fcc7
[TESTS][CACHE] Fixup errors found in cache implementation by testing. Ensure the newest values are kept, in pushList with max_count
2021-09-14 13:13:12 +01:00
e2f61b05d8
[ENTITY] Fix foreign key type in Cover entity, as found by tests
2021-09-14 13:13:12 +01:00
6dd0292397
[SETTINGS][ROUTES][CONTROLLER] Settings overhaul, refactoring to accommodate new global settings view. WIP, component settings aren't shown at the moment.
...
Signed-off-by: Eliseu Amaro <mail@eliseuama.ro>
2021-09-14 13:13:12 +01:00
367cc5c5c7
[DOCS][Dev] Add Queues
2021-09-14 13:13:11 +01:00
27fb2da1d0
[DOCS][Dev] Add Internationalisation
2021-09-14 13:13:11 +01:00
ce39f6ca4a
[DOCS][Dev] Add Routes and Controllers
2021-09-14 13:13:10 +01:00
c020958690
[DOCS] Write exceptions chapter
2021-09-14 13:13:09 +01:00
80cde06f4b
[MEDIA][Thumbnail] Fix non-instantiated variable
2021-09-14 13:13:04 +01:00
cb7fa0a081
[SECURITY] Remove aggressive normalization of nicknames. This will be moved to a plugin in the future and we'll open an RFC, as discussed
2021-09-14 13:13:04 +01:00
a5348f2427
[MEDIA][AttachmentThumbnail] Add mimetype to Entity
2021-09-14 13:13:04 +01:00
861732176e
[Media] Support any kind of thumbnails in the Core
...
Sanitize Attachments instead of Validate (part 1)
Ensure the intended filetypes and mimetypes during Vips conversions (part 1)
Various bug fixes
2021-09-14 13:13:03 +01:00
481e953cde
[Media] File quota should be triggered by the Core
2021-09-14 13:13:03 +01:00
72dcff22f7
[MEDIA] We need permissions to run chmod in directories
...
It's better to have in the filename data that we couldnt't otherwise rapidly retrieve
2021-09-14 13:13:03 +01:00
6ecdaa5d72
[MEDIA] Fix database misses on thumbnail retrieval
...
We were storing the real scaling values instead of the predictions, but the core is never able to pre-compute the real values generated by the encoding plugins so, we have to rely on our own aproximation function ported from v2
2021-09-14 13:13:03 +01:00
c8cf8c3f13
[FILE][TemporaryFile] Fix various issues now that we also have Symfony's file abstractions
2021-09-14 13:13:03 +01:00
8817613016
[CORE][GNUsocial] Fix undefined property typo
2021-09-14 13:13:03 +01:00
9f553707ba
[CORE] Proxies: constant HEADER_X_FORWARDED_ALL is deprecated
...
Give ENV preference over SERVER
2021-09-14 13:13:02 +01:00
687b2e2bc7
[UTIL] Add utility to flatten the result of note queries
2021-09-14 13:13:02 +01:00
74f477489b
[TESTS] Raise test coverage for App\Controller\Network to 100% and fixup related code
2021-09-14 13:13:02 +01:00
86400ce815
[UTIL] Provide static access to current request and utilities in Common
2021-09-14 13:13:02 +01:00
9198797aea
[CORE] Throw more meaningfull error when method doesn't exist in Security and Entity
2021-09-14 13:13:02 +01:00
6d93b6fb32
[TESTS] Raise App\Core\DB\DB test coverage to 100% and fix issues found
2021-09-14 13:13:01 +01:00
b9fbed2e3d
[CORE] Clarify message when calling non existent method in Entity
2021-09-14 13:13:01 +01:00
45f54e615c
[TESTS] Merge datafixtures to allow for using the correct ID in notes, and add group_inbox
2021-09-14 13:13:01 +01:00
e1a1d01844
[TESTS] Add GNUsocialTestCase, which initializes our infrastructure when bootKernel is called
2021-09-14 13:13:01 +01:00
d31c3b1784
[AUTOGENERATED] Update autogenerated code
2021-09-14 13:13:01 +01:00
de0c35d5a6
[TOOLS][TESTS] Add a data fixture with example notes, for testing
2021-09-14 13:13:00 +01:00
fbe0f36a53
[TESTS] Expand test coverage for App\Util\Forms\ArrayTransformer, App\Util\Notification and App\Twig\Runtime
2021-09-14 13:13:00 +01:00
6591d78a9c
[TWIG] Remove unused Twig function 'get_note_other_content'
2021-09-14 13:13:00 +01:00
fc9b934bbc
[UTIL] Fix App\Util\TemporaryFile, adding default options and preventing warning on not enough permission
2021-09-14 13:12:59 +01:00
31b6211bd0
[TOOLS][TESTS] Add data fixtures, which populate the database with users used for testing
2021-09-14 13:12:59 +01:00
ec1081ed43
[UTIL] Rename and rewrite isTaken to checkTaken
2021-09-14 13:12:59 +01:00
bd249b508b
[ENTITY] Add 'normalized_nickname' to GSActor, the result of Nickname::normalize, so we can make sure we don't have very similar nicknames duplicated
2021-09-14 13:12:59 +01:00
a49ee453ab
[TESTS] Raise App\Util\HTML test coverage to 100%
2021-09-14 13:12:58 +01:00
fbea08ca9b
[TESTS] Raise App\Util\Bitmap test coverage to 100%
2021-09-14 13:12:58 +01:00
abda73b8e3
[TESTS] Raise App\Util\Common test coverage to 100%
2021-09-14 13:12:58 +01:00
3fab198c04
[ENTITY] Add uniqueness constraint to Attachment::file_hash
2021-09-14 13:12:58 +01:00
4f936108a1
[ATTACHMENTS] Don't store an attachment if it's a dupplicate, reuse it
2021-09-14 13:12:58 +01:00
2b83a4b627
[UTILS][TemporaryFile] Change way TemporaryFile takes arguments and it's internal implementation
2021-09-14 13:12:58 +01:00
3b39046a38
[UTIL] Fix bugs found in App\Util\Formatting by tests
2021-09-14 13:12:58 +01:00
091f4b5194
[ATTACHMENTS] Do not create thumbnails for attachments with mimetype different from 'image|video'
2021-09-14 13:12:57 +01:00
b6d7d46719
[ENTITY] Fix entity->has to access private properties with closure bindTo
2021-09-14 13:12:57 +01:00
1e7d8cac9a
[ATTACHMENTS] Follow URL redirects and don't duplicate attachments
2021-09-14 13:12:57 +01:00
adb6680a01
[ATTACHMENTS] Respect config for smart crop
2021-09-14 13:12:57 +01:00
8f43c8b405
[AUTOGENERATED] Update auto generated code
2021-09-14 13:12:57 +01:00
4fcccb1d1c
[CORE][ImageEncoder] Add width and height back in attachment entity and allow for differently sized thumbs
...
The strategy adopted involves predicting the thumb size as we did in v2 before having vips resize
2021-09-14 13:12:56 +01:00
1c9f807595
[Embed] Fix some bugs and change AttachmentEmbed::url to ::media_url
2021-09-14 13:12:56 +01:00
c9090e6cee
[ATTACHMENTS][GSFile] Rename ValidateAndStore functions
2021-09-14 13:12:56 +01:00
6d31945401
[ATTACHMENTS] In sendFile, check that file exists or show a custom exception
2021-09-14 13:12:56 +01:00
38cf8f8efe
[ENTITY] Change foreign key definition to new format for cover and profile_color tables
2021-09-14 13:12:56 +01:00
837f644458
[UTIL][Formatting] Add twigRenderFile
2021-09-14 13:12:55 +01:00
e9a96f1c9b
[DOCUMENTATION] Add high level code walkthrough to developer docs
2021-09-14 13:12:55 +01:00
8cb64ede7f
[AttachmentShowRelated] Move Attachment related to plugin
2021-09-14 13:12:55 +01:00
7509913fcf
[ENTITY] Add field size to attachments, used for quota calculations
2021-09-14 13:12:54 +01:00
29457ef50d
[UTIL] Add option for setting a file suffix on TemporaryFile constructor and add missing TemporaryFileException
2021-09-14 13:12:54 +01:00
e9b2b18093
[Avatar] Implement avatar deletion
2021-09-14 13:12:53 +01:00
2ec7059076
[AVATAR] Move avatar settings page to Avatar component
2021-09-14 13:12:53 +01:00
88e5cec8fc
[ENTITY][GSActor] Fix getAvatarUrl method
2021-09-14 13:12:53 +01:00
aea8639d44
[ATTACHMENTS] Restrict thumbnail generation to allowed sizes. Defaults to only configured sizes, but can be extended with the event 'GetAllowedThumbnailSizes'. The intention is to prevent DoS attacks, since handling a thumbnail request is a relatively slow process
2021-09-14 13:12:53 +01:00
436528172c
[ATTACHMENTS] Add controller and templates for the attachment show page, which shows extra info about an attachment, such as related notes and tags
2021-09-14 13:12:53 +01:00
be91fb754d
[CORE] Typo in GSFile and slight Twig weirdness in base template
2021-09-14 13:12:52 +01:00
b1e514832b
[Embed][ENTITY] Fix embed route and use attachment_view rather than _show. Rename Entity::have to Entity::has, because grammar
2021-09-14 13:12:52 +01:00
30107de079
[Embed] Fix plugin. Only attempt to show an image, if we have one
2021-09-14 13:12:52 +01:00
2adb3c3521
[ATTACHMENTS] Add event 'AttachmentFileInfo' to allow a plugin to override the file displayed
2021-09-14 13:12:52 +01:00
708a910870
[UTIL] Fix remove affix utilities, so they only try to remove an affix if the string starts/ends with it
2021-09-14 13:12:52 +01:00
a7ef2babe6
[AUTOGENERATED] Update autogenerated code
2021-09-14 13:12:52 +01:00
7adc198a52
[ENTITY] Add meta method 'have*' to Entity base class, which checks if a field 'isset'
2021-09-14 13:12:51 +01:00
34059a8d3d
[ATTACHMENTS][EVENT] Add onHashFile event, which can be used to deduplicate files
...
Currently, we simply hash the contents of the file with sha256, but in the future we can use something smarter,
which could find visual feature similarity between images
2021-09-14 13:12:51 +01:00
60a9085e56
[FORMATTING] Add utilities to remove affixes from strings
2021-09-14 13:12:51 +01:00
9a7f1358c2
[ENTITY] Add utils to Attachment and AttachmentThumbnail to get the corresponding URL and html representation parameters
2021-09-14 13:12:51 +01:00
2a74dced22
[UTIL] Add TemporaryFile class, courtesy of Alexei Sorokin from v2, a class that ensures files stored in /tmp are removed, as it doesn't happen in some cases
2021-09-14 13:12:51 +01:00
94edad43d9
[UTIL] Add method to validate url
2021-09-14 13:12:23 +01:00
5c78def973
[HTTPClient] Add utility functions for all HTTP methods
2021-09-14 13:12:23 +01:00
1b8f5b7bf0
[DB] Make DB::findOneBy throw a different exception if two values are found
2021-09-14 13:12:23 +01:00
e94df546c3
[Posting] Extract and store URLs from note content. Introduce 'AttachmentStoreNew' event
2021-09-14 13:12:23 +01:00
ae0e410986
[TESTS] Fix Nickname test
2021-09-14 13:12:23 +01:00
8dff0b1d0c
[Favourite] Make twig event operate on array rather than string
2021-09-14 13:12:23 +01:00
7a90e844b7
[SECURITY][DB] Make user register 'atomic', by using a single transaction for inserting all objects, to avoid partial inserts
2021-09-14 13:12:23 +01:00
3afa872cec
[UI] Use thumbnail path for thumbs
2021-09-14 13:12:22 +01:00
e1995f44ce
[ATTACHMENTS] Move thumbnail controller to core and cleanup
2021-09-14 13:12:22 +01:00
e6c6e7afd7
[AVATAR] Fix JS cropping script and save square image, in case other themes need it
2021-09-14 13:12:22 +01:00
d2bb5bba14
[ImageEncoder] Move DB::persist call to AttachmentThumbnail
2021-09-14 13:12:22 +01:00
e385a9ac29
[ATTACHMENTS] Even more further refactoring
...
Introduce Encoder plugins Instead of abstract upload and thumb modules
Ported attachment routes. In v3 thumbnail depends on existing attachment
so route updated accordingly.
2021-09-14 13:12:18 +01:00
0eaccc32fe
[ATTACHMENTS] Further refactoring
...
Some key points:
- Components and Plugins shouldn't extend Module directly
- Avatars should be fetched via GSActor ID, not by nickname as that isn't unique
- Avatar now is a separate Component
- Common file utilities are now to be placed in Core\GSFile, this will
handle storage and trigger validation
- Some bug fixes
2021-09-14 13:11:51 +01:00
cdef6858ce
[ENTITY] Cache AttachmentThumbnail query result
2021-09-14 13:11:51 +01:00
65999bd183
[Poll] Move tables from core to plugin
2021-09-14 13:11:51 +01:00
716ca063d5
[ImageThumbnail] Finish image thumbnailing functionality
2021-09-14 13:11:51 +01:00
19850b5e0d
[DB] Fix bug in custom criteria format wrangling
2021-09-14 13:11:51 +01:00
4358656c55
[ImageThumbnail] Implement image resizing with Intervention/Image
2021-09-14 13:11:50 +01:00
7284c833a6
[DB] Allow DQL queries with table name rather than entity
2021-09-14 13:11:50 +01:00
0d01f1d060
[CORE] Add functionality to App\Core\Controller to get and validate GET parameters
2021-09-14 13:11:50 +01:00
5579f4fa5d
[MEDIA] Rename File to Attachment
2021-09-14 13:11:50 +01:00
dc5bdfa1fb
[CORE] Rename NoteScope to VisibilityScope, as it will be used for attachment visbility too
2021-09-14 13:11:50 +01:00
9659762726
[DB] Add table map which allows using table names rather than entities in Doctrine operations
2021-09-14 13:11:50 +01:00
c44443b52c
[AUTOGENERATED] Update autogenerated code
2021-09-14 13:11:50 +01:00
e7ed325ac6
[MEDIA] Refactor File as Attachment
2021-09-14 13:11:49 +01:00
566c7694b5
[CONFIG][TWIG] Move twig config to php code to add support for placing templates in modules (plugins and components)
2021-09-14 13:11:49 +01:00
299bc5b551
[TWIG] Add way to launch events from TWIG, capture service and add way to render from a string
2021-09-14 13:11:49 +01:00
1687ecaa24
[FAVOURITE] Temporary commit to fix exception in timeline
2021-09-14 13:11:48 +01:00
ccf3aa990a
[MODULES] Introduce the concept of abstract modules to V3
...
Introduce placeholder for abstract upload and thumb modules
Temporarily supress some bugs
2021-09-14 13:11:45 +01:00
539f1861a6
[NETWORK] Fix big brain bug
2021-09-14 13:10:55 +01:00
ea802621aa
[ENTITY] Remove extraneous File_thumbnail.php file
2021-09-14 13:10:55 +01:00
e2e561e663
[DB][FKEY] Temporarily disable foreign key mapping, as there seems to be a bug in doctrine, which is under investigation
2021-09-14 13:10:23 +01:00
faa362e2e2
[DB] Remove unique constraint from GSActor.nickname and fix register and related functionality
2021-09-14 13:10:23 +01:00
68de1b09b1
[NICKNAME] Don't throw when normalizing reserved nicknames
2021-09-14 13:10:23 +01:00
78548365da
[WEB] Fix translations and small inconsistency when opening on web
2021-09-14 13:10:23 +01:00
8b5bd40421
[TESTS] Add tests to all relevant methods under App\Util and fix errors that popup
2021-09-14 13:10:23 +01:00
57dad5eca4
[NICKNAME] Add nickname min length config and check it in Nickname::normalize
2021-09-14 13:10:23 +01:00
5afd2c9843
Duplicate src/Util/Exception/NicknameTooLongException.php history in src/Util/Exception/NicknameTooShortException.php history.
2021-09-14 13:10:23 +01:00
dc2a453e94
[TESTS] Add tests of Common and fix small oddities that pop up
2021-09-14 13:10:22 +01:00
b387ea9aa0
[TESTS] Fix error when testing cold redis cache
2021-09-14 13:10:22 +01:00
88e4044d02
[TESTS] Add tests for the bitmap utility and fix implementation
2021-09-14 13:10:22 +01:00
8d25859de7
[LOG] Only try to log if setup, so logs can be disabled, in tests, for instance
2021-09-14 13:10:22 +01:00
7e648a296f
CACHE] Fix cache implementation with the help of tests and remove premature optimization for non-redis list caching
...
This complicated the code significantly and likely didn't help that much, if at all. The recommended setup is using Redis, anyway, which is plenty optimized
2021-09-14 13:10:22 +01:00
