Commit Graph

17 Commits

Author SHA1 Message Date
Evan Prodromou
5067939e9a Try to do intelligent redirect codes
After fixing the redirect code output, there are a lot of weirdnesses
with e.g. form handling. Try to add explicit redirect codes where
needed -- principly when handling a POST.
2009-04-01 15:32:30 -04:00
Robin Millette
998e6044e5 uiredesign 2009-01-23 04:29:21 +00:00
Robin Millette
c20d0612bf uiredesign + phpdocs 2009-01-22 06:02:23 +00:00
Evan Prodromou
4b0cf99e56 Convert use of common_server_error and common_user_error to methods on Action 2009-01-15 23:03:38 +00:00
Evan Prodromou
eaa81d25fa Convert all actions to use new UI functions
I did a massive search-and-replace to get all the action subclasses to
use the new output function (common_element() -> $this->element(), etc.)

There's still a lot to do, but it's a first step
2009-01-15 22:57:15 +00:00
Evan Prodromou
b264c03d32 move opening brace of class declaration to next line
Another gigantor PEAR coding standards patch. Here, I've moved the
opening curly bracket on a class statement to the following line.

darcs-hash:20081223194923-84dde-77a93de314caadbcb5b70bf346a4648be77a864e.gz
2008-12-23 14:49:23 -05:00
Evan Prodromou
04ef1ba8ee change function headers to K&R style
Another huge change, for PEAR code standards compliance. Function
headers have to be in K&R style (opening brace on its own line),
instead of having the opening brace on the same line as the function
and parameters. So, a little perl magic found all the function
definitions and move the opening brace to the next line (properly
indented... usually).

darcs-hash:20081223193323-84dde-a28e36ecc66672c783c2842d12fc11043c13ab28.gz
2008-12-23 14:33:23 -05:00
Evan Prodromou
eb2f9c98ac replace NULL with null
Another global search-and-replace update. Here, I've replaced the PHP
keyword 'NULL' with its lowercase version. This is another PEAR code
standards change.

darcs-hash:20081223192129-84dde-4a0182e0ec16a01ad88745ad3e08f7cb501aee0b.gz
2008-12-23 14:21:29 -05:00
Evan Prodromou
edbc0c665c replace all tabs with four spaces
The PEAR coding standards decree: no tabs, but indent by four spaces.
I've done a global search-and-replace on all tabs, replacing them by
four spaces. This is a huge change, but it will go a long way to
getting us towards phpcs-compliance. And that means better code
readability, and that means more participation.

darcs-hash:20081223191907-84dde-21e8efe210e6d5d54e935a22d0cee5c7bbfc007d.gz
2008-12-23 14:19:07 -05:00
Evan Prodromou
ef3d487ae0 enable block API
darcs-hash:20081208185728-5ed1f-8d5f6be6decfbb50deb4ca50bee13404d0c51b72.gz
2008-12-08 13:57:28 -05:00
Evan Prodromou
ef0b45c0f1 error in figuring out actions to return to
darcs-hash:20081208172812-5ed1f-58ce42160f0ea5330de578c310897906d0012c5c.gz
2008-12-08 12:28:12 -05:00
Evan Prodromou
17fd7b1850 add returnto information to the block form
darcs-hash:20081208170931-5ed1f-e7c5853e6a222b04723f20c01ebaae15eeab3687.gz
2008-12-08 12:09:31 -05:00
Evan Prodromou
2ced62bd7e change element_start to element for instructions
darcs-hash:20081208072629-5ed1f-90935f7a2a3d99a4c21b6390eb3fc941117c2580.gz
2008-12-08 02:26:29 -05:00
Evan Prodromou
96128353d0 return true from block action
darcs-hash:20081208071720-5ed1f-82ff38a26edc9254883bd22e055b7a883b07081c.gz
2008-12-08 02:17:20 -05:00
Evan Prodromou
ad3fcbce43 add header and footer
darcs-hash:20081208063056-5ed1f-ff1fdbc345395661c19699c6c76cc1d1f6ea8d25.gz
2008-12-08 01:30:56 -05:00
Evan Prodromou
3e496c19f9 fixup handle function in block action
darcs-hash:20081208062841-5ed1f-be70623070712b4877c8d2fd8aaadba33ebd2180.gz
2008-12-08 01:28:41 -05:00
Evan Prodromou
9b4df5056f add block form to subscribers list and profile page
I added a small form for blocking users to profiles in the profile
list, and also to the profile page.

I also added an action to handle the results of blocking someone.

This required some changes to the profile list class (so I could
add the block form), so I made them. And the gallery class lets its
subclasses return a subclass of ProfileList for their profile list.

darcs-hash:20081208055511-5ed1f-e2e09986bd3b9cbb6a00a0c6b94f49ea78b7bdab.gz
2008-12-08 00:55:11 -05:00