Diogo Cordeiro
c083a8bcc2
[SESSION] Implement SessionHandlerInterface instead of setting custom handlers by XRevan86
2019-05-22 22:29:33 +01:00
Diogo Cordeiro
e8783d46d0
[SESSION] Increase type strictness for full PHP adherence
...
Documented this file (adapted from maiyannah's postActiv doc)
This commit also fixes PHP Warning: session_write_close(): Session callback expects true/false return value in classes/Session.php on line 289 (spoted by XRevan86)
Observation: In a newer release we will be replacing this kind of castings with actual explicit PHP7 return types
2019-05-22 22:29:26 +01:00
Diogo Cordeiro
c03ed457a6
Fix broken user activitystreams feed due to deleted notices
2019-05-06 23:27:38 +01:00
Diogo Cordeiro
6cf674f8f8
Some minor refactoring on session handler
2019-04-27 00:28:05 +01:00
Diogo Cordeiro
339204f1ee
Fix negative one subscriptions by XRevan86
...
Only local users are subscribed to themselves.
2019-04-26 01:10:53 +01:00
Diogo Cordeiro
496ab8c920
User_im_prefs - Fix wrong schemaDef
2019-04-19 20:54:24 +01:00
Diogo Cordeiro
9a39ebe66f
Database fields with timestamp type now allow CURRENT_TIMESTAMP to be set as default value
...
Add default values to created and modified columns of Profile_list table to fix issue #338
2018-08-25 14:07:52 +01:00
Mikael Nordfeldth
586aaa596e
Quote URL on dupe search and better logging on upgrade
2017-07-27 19:39:55 +02:00
Mikael Nordfeldth
457d32e273
Merge branch 'takeshitakenji/gnu-social-twitter-repeat-config' into mmn_fixes
2017-07-11 22:09:12 +02:00
mmn
dd8e17a387
Merge branch 'profile' into 'nightly'
...
Change Profile->getUser() to match the current user
See merge request !129
2017-07-11 20:05:47 +00:00
mmn
924bcd93e5
Merge branch 'notice_id-xml' into 'nightly'
...
Use the statusnet namespace for notice_id in atom feed
See merge request !136
2017-07-11 20:01:01 +00:00
Mikael Nordfeldth
0dd68d11cb
What just happened? Not sure if me or git caused duplicate code.
2017-05-06 14:48:04 +02:00
Mikael Nordfeldth
4f37c564a5
Merge branch 'master' into mmn_fixes
2017-05-06 14:40:06 +02:00
Mikael Nordfeldth
966971bd12
Revert some of 8a4bec811b
...
use Notice_prefs instead of adding a new field. The rationale here
is simply that the Notice table was _huge_ and I rant into issues
with /tmp filling up when altering the tables. So let's just create
a new table instead.
2017-05-06 14:38:48 +02:00
Mikael Nordfeldth
7767c57087
Notice_prefs now available (I just copied Profile_prefs)
2017-05-06 14:38:47 +02:00
Mikael Nordfeldth
d115f9dd1b
Output selfLink from notice asActivity[Object]
2017-05-06 14:38:45 +02:00
Mikael Nordfeldth
434956fc75
Notices start saving selfLink from activities/objects
2017-05-06 14:38:42 +02:00
Mikael Nordfeldth
286b1e0ab7
Revert some of 8a4bec811b
...
use Notice_prefs instead of adding a new field. The rationale here
is simply that the Notice table was _huge_ and I rant into issues
with /tmp filling up when altering the tables. So let's just create
a new table instead.
2017-05-06 13:24:11 +02:00
Mikael Nordfeldth
2cbef2b10f
Notice_prefs now available (I just copied Profile_prefs)
2017-05-06 13:22:10 +02:00
Mikael Nordfeldth
7c829852b8
Output selfLink from notice asActivity[Object]
2017-05-06 12:26:54 +02:00
Mikael Nordfeldth
8a4bec811b
Notices start saving selfLink from activities/objects
2017-05-06 12:15:54 +02:00
Mikael Nordfeldth
000af6d9ee
default to #addtag on !group mention
2017-05-02 21:21:53 +02:00
Mikael Nordfeldth
07458e5375
Fixed the parsing of ostatus:conversation etc.
...
Conversation will now start storing remote URL
The namespace features don't work the way they were written for here
so I fixed that, making the ostatus: namespace properly looked up and
then the homegrown getLink function looks for what is back-compat with
StatusNet etc. if I remember correctly.
2017-05-02 18:58:22 +02:00
Mikael Nordfeldth
979c525124
I like to throw exceptions instead of using if statements.
2017-05-02 09:07:39 +02:00
Mikael Nordfeldth
75079320d1
Give remote Atom URL for remote profile view
2017-04-09 12:13:53 +02:00
Mikael Nordfeldth
d2c7c83615
Merge branch 'nightly' of git.gnu.io:gnu/gnu-social into nightly
2017-04-06 13:34:57 +02:00
mmn
550606177b
Merge branch 'fixtests' into 'nightly'
...
Got Old Unittests Passing
See merge request !131
2017-04-06 10:23:12 +00:00
Mikael Nordfeldth
2ce2201496
Show full acct uri as html title on link mouseover
2017-04-06 11:45:58 +02:00
Thomas Karpiniec
47cd054976
Use the statusnet namespace for notice_id
2017-02-04 21:59:30 +11:00
Mikael Nordfeldth
a7043bf7cc
Split up source and source_link. Never trust HTML!
...
https://community.highlandarrow.com/notice/269667
or alternatively: https://social.umeahackerspace.se/conversation/495655
2016-09-02 01:00:52 +02:00
Mikael Nordfeldth
59b93b23e2
Split up source and source_link. Never trust HTML!
...
https://community.highlandarrow.com/notice/269667
or alternatively: https://social.umeahackerspace.se/conversation/495655
2016-09-02 00:55:46 +02:00
Mikael Nordfeldth
3b046ee49d
Shorthand function to check if notice has been repeated.
2016-08-27 14:42:28 +02:00
Nym Coy
1f866fcaed
ActivityGenerationTests.php fails but doesn't crash anymore.
...
Fixed an error where a profile id was reused after another profile was
deleted, and the new profile still had the deleted role.
Fixed ActivityGenerationTests::testNoticeInfoRepeated() which was passing
User instead of Profile, throwing errors.
tests/ActivityGenerationTests.php now passes.
CommandInterpreterTest now passes.
Moved JidValidateTest to XmppValidateTest, since Jabber functionality has
moved to the XmppPlugin. Tests work but don't pass, but they are at least
skipped if XmppPlugin is not active.
LocationTest passes, but the tests are not very good. Lots of nulls.
MediaFileTest passes.
NicknameTest passes. Nickname::normalize() now throws an error if the
nickname is too long with underscores.
UserFeedParseTest passes.
URLDetectionTest passes if $config['linkify']['(bare_ipv4|bare_ipv6|
bare_domains)'] are false. Untested otherwise.
Fixed Nickname::isBlacklisted() so it does not throw an error if
$config['nickname]['blacklist'] not set.
2016-08-14 11:55:49 +05:30
Mikael Nordfeldth
d84bf83419
Created function File->setTitle(str)
2016-07-23 21:00:57 +02:00
Mikael Nordfeldth
1b3d583418
file_quota for OembedPlugin too
...
Don't download huge files that might kill memory limits.
2016-07-21 03:19:05 +02:00
Mikael Nordfeldth
1981cb7662
Select the first generated thumbnail, which should be the proper size
...
...most of the time. If all works well.
2016-07-21 00:38:16 +02:00
Mikael Nordfeldth
f02d32b718
Reworked File->getUrl to throw exception
...
In case you require a local URL and one can't be generated, throw
FileNotStoredLocallyException(File $file)
2016-07-07 00:44:50 +02:00
Mikael Nordfeldth
b4a0bff740
Some mimetype madness!
2016-07-06 08:59:16 +02:00
Martin Lyth
b0204023c0
Fix the case of a call to sameAs()
2016-07-02 17:43:47 -04:00
Martin Lyth
c9afdae01c
Check if we're the current user before retrieving
2016-07-02 17:02:37 -04:00
Martin Lyth
a62755182c
Test user equality better in Profile->getUser()
2016-07-02 15:45:42 -04:00
Martin Lyth
d7a29be3ac
Change Profile->getUser() to match the current user
...
Profile->getUser() gets the User independently from common_current_user.
This means that changes to one does not affect the other, even if they
are the same user.
This changes that, so that getUser() returns common_current_user() if
they are both the same user.
This is done to fix a bug in the user profile settings, where changes in
the language and timezone are applied to the return value of
Profile->getUser() but not propagated to common_cur_user(), which causes
the profile settings to display incorrect information until the page is
refreshed.
2016-06-30 18:24:58 -04:00
Mikael Nordfeldth
3d6e25ee5f
We have to create and populate the Notice_location table before constraint checking foreign keys.
2016-06-25 13:01:56 +02:00
Mikael Nordfeldth
f93f02f424
Managed_DataObject now has getByUri()
2016-06-25 11:59:06 +02:00
Mikael Nordfeldth
42a62da764
getByUri shorthand function for Managed_DataObject (with uri)
2016-06-25 11:52:17 +02:00
Mikael Nordfeldth
7978cd6d59
s/EmptyIdException/EmptyPkeyValueException/
2016-06-25 11:50:59 +02:00
Mikael Nordfeldth
1dfac3ad63
Allow getting filesize by function
2016-06-24 15:53:23 +02:00
Stephen Paul Weber
47e541eaec
Allow getting notice title without implying one
...
Sometimes I just want explicit titles, and not the generated "blah posted on date" text
2016-06-10 21:00:01 +00:00
Mikael Nordfeldth
6d6db77f06
Documentation update in File class file
2016-05-04 11:44:14 +02:00
Mikael Nordfeldth
87dd0fbdb6
UseFileAsThumbnailException uses direct File object now
2016-05-04 11:34:50 +02:00
Mikael Nordfeldth
7aa9a69c2f
Link to attachment page instead of big-ass image
2016-05-01 11:35:51 +02:00
Mikael Nordfeldth
0959efd7be
Use constant for ATTN_PUBLIC (public collection)
2016-04-18 15:56:52 +02:00
Mikael Nordfeldth
c48508d590
use getByID (also bad variable reference)
2016-04-18 15:08:47 +02:00
Mikael Nordfeldth
6d33c003fc
Maybe stop deleteRelated from failing on constraint checking
2016-04-04 12:04:20 +02:00
Mikael Nordfeldth
195285ac2f
Fix constraint checking and only run it if not already constrained
2016-04-01 06:24:11 +02:00
Mikael Nordfeldth
8de3469957
Constraint check Notice table, need to get foreign key array!
2016-03-31 17:57:01 +02:00
Mikael Nordfeldth
2f91cb0df7
We should assume all verbs and such are their full URIs in our db
2016-03-29 12:57:52 +02:00
Mikael Nordfeldth
72cafe03e9
Index object_type too...
2016-03-29 12:48:25 +02:00
Mikael Nordfeldth
4e2be07234
Better indexing for Notice (performance++)
2016-03-29 12:13:33 +02:00
Mikael Nordfeldth
4790db348d
FetchRemoteNotice event call in Notice (not effective yet)
2016-03-27 14:00:05 +02:00
Mikael Nordfeldth
49a91885c9
Strictify Notice->isPublic()
2016-03-24 01:54:33 +01:00
Mikael Nordfeldth
6b4c331060
Attachment and file handling since we could get NULL instead of File
2016-03-23 17:53:38 +01:00
Mikael Nordfeldth
e32f2b0a39
Not really necessary in practice but makes better queries
2016-03-23 17:51:13 +01:00
Mikael Nordfeldth
250d99d997
Allow actions to be performed on updateWithKeys
...
Avoids overloading and lets dataobject classes use onUpdateKeys()
to do special stuff, like if a key is made up of a hash of other fields etc.
2016-03-23 15:19:50 +01:00
Mikael Nordfeldth
86ce93b376
Notice->deleteRelated should be called from delete()
2016-03-21 17:34:03 +01:00
Neil E. Hodges
39ebb64b85
Added proper enabling and disabling of sending RTs to Twitter.
2016-03-21 07:12:52 -07:00
Mikael Nordfeldth
566977c136
forgot 'new' after throw
2016-03-10 13:46:19 +01:00
Mikael Nordfeldth
15c16ac54e
Make sure File_thumbnail->getPath() doesn't throw NoResultException
2016-03-09 23:49:01 +01:00
Mikael Nordfeldth
a24c6fdb39
If our host matched in File lookup, it could throw exceptions on Router->map
2016-03-09 14:52:15 +01:00
Mikael Nordfeldth
e4310a57cd
Profile->noticeCount minor change
2016-03-08 20:00:58 +01:00
Mikael Nordfeldth
4360c65ed9
Super special case where we should copy files instead of mv
2016-03-08 01:59:58 +01:00
Mikael Nordfeldth
3b1181dae6
Display locally stored remote GIFs as thumbnails
...
Many newspapers seem to use animated GIFs as catchy header images, which
we would fail to show from oEmbed/OpenGraph fetching since they would
want us to "use File as Thumbnail", but the only place the image filename
was stored was in File_thumbnail, for the thumbnail of that file_id which
had a URL set.
2016-03-08 01:36:24 +01:00
Mikael Nordfeldth
4e5c0e70a6
fillConfigVoids to set default value of empty config options
2016-03-07 22:55:52 +01:00
Mikael Nordfeldth
265fa12917
Relatively experimental change to store thumbnails in 'file/thumb/' (by default)
2016-03-07 22:33:34 +01:00
Mikael Nordfeldth
a3b265a477
Portability for filepath in File
2016-03-07 20:13:07 +01:00
Mikael Nordfeldth
a0336ce48b
Unnecessary debug output
2016-03-06 18:15:36 +01:00
Mikael Nordfeldth
d9538183bd
Use information about activityschema public mention for Notice scope
2016-03-06 17:47:35 +01:00
Mikael Nordfeldth
6ec72b2978
Move mail_confirm_address out of mail.php
2016-03-06 17:27:40 +01:00
Mikael Nordfeldth
175b7e8541
Refactor some ConfirmaddressAction stuff
2016-03-02 15:31:48 +01:00
Mikael Nordfeldth
346a73c36f
Fix a regression in 1f76c1e4
that stopped sending email confirmation on registration
2016-03-02 14:38:34 +01:00
Mikael Nordfeldth
97d8e4571f
Fix a regression in 1f76c1e4
that stopped sending email confirmation on registration
2016-03-02 14:35:08 +01:00
Mikael Nordfeldth
53772ba305
Some rights one does not have if either sandboxed or silenced
2016-03-02 12:41:56 +01:00
Mikael Nordfeldth
d6598e790c
Introduce a ConfigException
2016-03-02 12:33:06 +01:00
Mikael Nordfeldth
9534969c05
Don't set is_local=LOCAL_NONPUBLIC on sandboxed user notices
...
Let's decide whether they are nonpublic by testing them when the notice
is shown instead.
2016-03-02 12:26:23 +01:00
Mikael Nordfeldth
79d68a52d0
No 'acct:' in FancyName please.
2016-03-02 10:49:33 +01:00
Mikael Nordfeldth
7ec69e4215
User->hasBlocked typing
2016-03-02 00:04:31 +01:00
Mikael Nordfeldth
99fbb181c1
Translation changes, use FancyName in email subject
2016-03-01 23:53:36 +01:00
Mikael Nordfeldth
4abb3f19bf
Make Profile->getFancyUrl() somewhat better on fallback
...
It tries to get a referential identifier apart from the fullname trying
with acct: URI, profile URL and lastly URI.
2016-03-01 23:48:32 +01:00
Mikael Nordfeldth
ddd60e7142
Make Profile->getFancyName() return including the acct URI
2016-03-01 23:37:38 +01:00
Mikael Nordfeldth
47f408ca7c
Strict typing for mail_notify_attn
2016-03-01 23:37:11 +01:00
Mikael Nordfeldth
e41809af89
Nothing interesting was made in this commit.
2016-03-01 16:30:00 +01:00
Mikael Nordfeldth
a112e7f9a4
Use another method of detecting unspecified defaultImage size
2016-03-01 15:00:52 +01:00
Mikael Nordfeldth
63c087a255
Consistent behaviour for ScopingNoticeStream $scoped
...
We don't guess the current profile anymore if the value of the profile === -1
Also sets $this->scoped for all ScopingNoticeStream inheritors, which just
like in an Action can be null if we're not scoped in any way (logged in).
2016-03-01 14:51:47 +01:00
Mikael Nordfeldth
52a3764ae4
Resolve relative URLs (assuming URI.Base==notice URL)
...
The real way to do this would be to get the xml:base property from
the Atom feed but it's probably not there in any posts we see today.
2016-02-26 14:46:26 +01:00
Mikael Nordfeldth
1e6520fddd
Woops, forgot to skip the / in path
2016-02-26 14:13:46 +01:00
Mikael Nordfeldth
6a4470912f
Fiddling with merge request #98 to use internal routing functions
2016-02-26 14:10:32 +01:00
Mikael Nordfeldth
8356c2495c
Use mb_* and strict === comparison
2016-02-26 13:52:25 +01:00
mmn
722ff4d9c0
Merge branch 'foolproof_file_redirection_branch' into 'nightly'
...
Foolproof file redirection
This solves an issue when our internal /attachment/{file_id} links are shortened with an remote shorteners (which caused the /attachment/{file_id} links to be saved to the File table and a thumbnail of a thumbnail being generated)
See merge request !98
2016-02-26 12:49:10 +00:00
mmn
fae9e27365
Merge branch 'group-autocomplete' into 'nightly'
...
Fix !group autocomplete
"Call to undefined method User_group::getFullname"
See merge request !108
2016-02-26 12:30:19 +00:00
Mikael Nordfeldth
c58228195b
Make sure the saved Notice has an ID
2016-02-26 01:11:20 +01:00