Fixed various bugs Some important concepts to bear in mind: * Notification: Associated with activities, won't be reconstructed together with objects, can be thought of as transient * Attention: Associated with objects, will be reconstructed with them, can be thought as persistent * Notifications and Attentions have no direct implications. * Mentions are a specific form of attentions in notes, leads to the creation of Attentions. Finally, Potential PHP issue detected and reported: https://github.com/php/php-src/issues/8199 `static::method()` from a non static context (such as a class method) calls `__call`, rather than the expected `__callStatic`. Can be fixed by using `(static fn() => static::method())()`, but the usage of the magic method is strictly unnecessary in this case.
		
			
				
	
	
		
			181 lines
		
	
	
		
			7.1 KiB
		
	
	
	
		
			PHP
		
	
	
	
	
	
			
		
		
	
	
			181 lines
		
	
	
		
			7.1 KiB
		
	
	
	
		
			PHP
		
	
	
	
	
	
| <?php
 | |
| 
 | |
| declare(strict_types = 1);
 | |
| 
 | |
| // {{{ License
 | |
| // This file is part of GNU social - https://www.gnu.org/software/social
 | |
| //
 | |
| // GNU social is free software: you can redistribute it and/or modify
 | |
| // it under the terms of the GNU Affero General Public License as published by
 | |
| // the Free Software Foundation, either version 3 of the License, or
 | |
| // (at your option) any later version.
 | |
| //
 | |
| // GNU social is distributed in the hope that it will be useful,
 | |
| // but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
| // GNU Affero General Public License for more details.
 | |
| //
 | |
| // You should have received a copy of the GNU Affero General Public License
 | |
| // along with GNU social.  If not, see <http://www.gnu.org/licenses/>.
 | |
| // }}}
 | |
| 
 | |
| namespace Component\Notification;
 | |
| 
 | |
| use App\Core\DB\DB;
 | |
| use App\Core\Event;
 | |
| use function App\Core\I18n\_m;
 | |
| use App\Core\Log;
 | |
| use App\Core\Modules\Component;
 | |
| use App\Core\Queue\Queue;
 | |
| use App\Core\Router\RouteLoader;
 | |
| use App\Core\Router\Router;
 | |
| use App\Entity\Activity;
 | |
| use App\Entity\Actor;
 | |
| use App\Entity\LocalUser;
 | |
| use App\Util\Exception\ServerException;
 | |
| use Component\FreeNetwork\FreeNetwork;
 | |
| use Component\Notification\Controller\Feed;
 | |
| use Exception;
 | |
| use Throwable;
 | |
| 
 | |
| class Notification extends Component
 | |
| {
 | |
|     public function onAddRoute(RouteLoader $m): bool
 | |
|     {
 | |
|         $m->connect('feed_notifications', '/feed/notifications', [Feed::class, 'notifications']);
 | |
|         return Event::next;
 | |
|     }
 | |
| 
 | |
|     /**
 | |
|      * @throws ServerException
 | |
|      */
 | |
|     public function onCreateDefaultFeeds(int $actor_id, LocalUser $user, int &$ordering): bool
 | |
|     {
 | |
|         DB::persist(\App\Entity\Feed::create([
 | |
|             'actor_id' => $actor_id,
 | |
|             'url'      => Router::url($route = 'feed_notifications'),
 | |
|             'route'    => $route,
 | |
|             'title'    => _m('Notifications'),
 | |
|             'ordering' => $ordering++,
 | |
|         ]));
 | |
|         return Event::next;
 | |
|     }
 | |
| 
 | |
|     /**
 | |
|      * Enqueues a notification for an Actor (such as person or group) which means
 | |
|      * it shows up in their home feed and such.
 | |
|      * WARNING: It's highly advisable to have flushed any relevant objects before triggering this event.
 | |
|      * OBSERVATION: $sender->getSubscribers() will always be pre-included, thus why $targets=[] is normal
 | |
|      *
 | |
|      * $targets should be of the shape:
 | |
|      * ['source' => (int|Actor)[]] // Prefer Actor whenever possible
 | |
|      * Example of $targets:
 | |
|      * [[42, $actor_alice, $actor_bob]] // Avoid repeating actors or ids
 | |
|      *
 | |
|      * @param Actor       $sender   The one responsible for this activity, take care not to include it in targets
 | |
|      * @param Activity    $activity The activity responsible for the object being given to known to targets
 | |
|      * @param array       $targets  attentions, Mentions, any other source
 | |
|      * @param null|string $reason   An optional reason explaining why this notification exists
 | |
|      */
 | |
|     public function onNewNotification(Actor $sender, Activity $activity, array $targets = [], ?string $reason = null): bool
 | |
|     {
 | |
|         // Ensure targets are all actor objects and unique
 | |
|         $effective_targets = [];
 | |
|         foreach ($targets as $target) {
 | |
|             if (\is_int($target)) {
 | |
|                 $target_id     = $target;
 | |
|                 $target_object = null;
 | |
|             } else {
 | |
|                 $target_id     = $target->getId();
 | |
|                 $target_object = $target;
 | |
|             }
 | |
|             if (!\array_key_exists(key: $target_id, array: $effective_targets)) {
 | |
|                 $target_object ??= Actor::getById($target_id);
 | |
|                 $effective_targets[$target_id] = $target_object;
 | |
|             }
 | |
|         }
 | |
|         unset($targets);
 | |
| 
 | |
|         if (Event::handle('NewNotificationStart', [$sender, $activity, $effective_targets, $reason]) === Event::next) {
 | |
|             self::notify($sender, $activity, $effective_targets, $reason);
 | |
|         }
 | |
| 
 | |
|         Event::handle('NewNotificationEnd', [$sender, $activity, $effective_targets, $reason]);
 | |
|         return Event::next;
 | |
|     }
 | |
| 
 | |
|     public function onQueueNotificationLocal(Actor $sender, Activity $activity, Actor $target, ?string $reason, array &$retry_args): bool
 | |
|     {
 | |
|         // TODO: use https://symfony.com/doc/current/notifier.html
 | |
|         return Event::stop;
 | |
|     }
 | |
| 
 | |
|     public function onQueueNotificationRemote(Actor $sender, Activity $activity, array $targets, ?string $reason, array &$retry_args): bool
 | |
|     {
 | |
|         if (FreeNetwork::notify($sender, $activity, $targets, $reason)) {
 | |
|             return Event::stop;
 | |
|         } else {
 | |
|             return Event::next;
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /**
 | |
|      * Bring given Activity to Targets' knowledge.
 | |
|      * This will flush a Notification to DB.
 | |
|      *
 | |
|      * @return true if successful, false otherwise
 | |
|      */
 | |
|     public static function notify(Actor $sender, Activity $activity, array $targets, ?string $reason = null): bool
 | |
|     {
 | |
|         $remote_targets = [];
 | |
|         foreach ($targets as $target) {
 | |
|             if ($target->getIsLocal()) {
 | |
|                 if ($target->hasBlocked($author = $activity->getActor())) {
 | |
|                     Log::info("Not saving notification to actor {$target->getId()} from sender {$sender->getId()} because receiver blocked author {$author->getId()}.");
 | |
|                     continue;
 | |
|                 }
 | |
|                 if (Event::handle('NewNotificationShould', [$activity, $target]) === Event::next) {
 | |
|                     if ($sender->getId() === $target->getId()
 | |
|                         || $activity->getActorId() === $target->getId()) {
 | |
|                         // The target already knows about this, no need to bother with a notification
 | |
|                         continue;
 | |
|                     }
 | |
|                 }
 | |
|                 Queue::enqueue(
 | |
|                     payload: [$sender, $activity, $target, $reason],
 | |
|                     queue: 'NotificationLocal',
 | |
|                     priority: true,
 | |
|                 );
 | |
|             } else {
 | |
|                 // We have no authority nor responsibility of notifying remote actors of a remote actor's doing
 | |
|                 if ($sender->getIsLocal()) {
 | |
|                     $remote_targets[] = $target;
 | |
|                 }
 | |
|             }
 | |
|             // XXX: Unideal as in failures the rollback will leave behind a false notification,
 | |
|             // but most notifications (all) require flushing the objects first
 | |
|             // Should be okay as long as implementations bear this in mind
 | |
|             try {
 | |
|                 DB::wrapInTransaction(fn () => DB::persist(Entity\Notification::create([
 | |
|                     'activity_id' => $activity->getId(),
 | |
|                     'target_id'   => $target->getId(),
 | |
|                     'reason'      => $reason,
 | |
|                 ])));
 | |
|             } catch (Exception|Throwable $e) {
 | |
|                 // We do our best not to record duplicate notifications, but it's not insane that can happen
 | |
|                 Log::error('It was attempted to record an invalid notification!', [$e]);
 | |
|             }
 | |
|         }
 | |
| 
 | |
|         if ($remote_targets !== []) {
 | |
|             Queue::enqueue(
 | |
|                 payload: [$sender, $activity, $remote_targets, $reason],
 | |
|                 queue: 'NotificationRemote',
 | |
|                 priority: false,
 | |
|             );
 | |
|         }
 | |
| 
 | |
|         return true;
 | |
|     }
 | |
| }
 |