820dd293c9
Part of the reported issue was previuosly fixed by dc497ed0 (smaller size images being blanked).
This commit fixes the remaining bug with original-size avatars being left as BMP (which could include the 96px size for instance, which could cause problems in browsers not supporting BMP natively)
Added ImageFile::copyTo() as a convenient alias for resizeTo() when not resizing; this performs the BMP/XPM/XBM->PNG conversion if needed, or copies the original file.
Copying instead of using move_uploaded_file() is fine here since:
a) the files are cleaned up on script completion anyway (vs moving to remove it)
b) we're already performing getimagesize() and possibly load/resize on the file before this point (vs needing to move the file into a usable area to work with open_basedir restrictions that prevent working directly with uploaded files in the temp dir; since this would fail anyway, we lose nothing)
ImageFile::preferredType() now works on $this->type instead of asking for one, to make it handier to use from outside. (This is still needed in order for calling code to generate a target filename.)
Recommended for future:
* additional consolidation between the various ways of uploading avatars (touched avatarsettings, grouplogo, and apiaccountupdateprofileimage with similar minor changes)
* consolidate type checks and file naming into Avatar class
472 lines
16 KiB
PHP
472 lines
16 KiB
PHP
<?php
|
|
/**
|
|
* StatusNet, the distributed open-source microblogging tool
|
|
*
|
|
* Upload an avatar
|
|
*
|
|
* PHP version 5
|
|
*
|
|
* LICENCE: This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* @category Settings
|
|
* @package StatusNet
|
|
* @author Evan Prodromou <evan@status.net>
|
|
* @author Zach Copley <zach@status.net>
|
|
* @copyright 2008-2009 StatusNet, Inc.
|
|
* @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0
|
|
* @link http://status.net/
|
|
*/
|
|
|
|
if (!defined('STATUSNET') && !defined('LACONICA')) {
|
|
exit(1);
|
|
}
|
|
|
|
require_once INSTALLDIR.'/lib/accountsettingsaction.php';
|
|
|
|
define('MAX_ORIGINAL', 480);
|
|
|
|
/**
|
|
* Upload an avatar
|
|
*
|
|
* We use jCrop plugin for jQuery to crop the image after upload.
|
|
*
|
|
* @category Settings
|
|
* @package StatusNet
|
|
* @author Evan Prodromou <evan@status.net>
|
|
* @author Zach Copley <zach@status.net>
|
|
* @author Sarven Capadisli <csarven@status.net>
|
|
* @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0
|
|
* @link http://status.net/
|
|
*/
|
|
class GrouplogoAction extends GroupDesignAction
|
|
{
|
|
var $mode = null;
|
|
var $imagefile = null;
|
|
var $filename = null;
|
|
var $msg = null;
|
|
var $success = null;
|
|
|
|
/**
|
|
* Prepare to run
|
|
*/
|
|
|
|
function prepare($args)
|
|
{
|
|
parent::prepare($args);
|
|
|
|
if (!common_logged_in()) {
|
|
// TRANS: Client error displayed when trying to create a group while not logged in.
|
|
$this->clientError(_('You must be logged in to create a group.'));
|
|
return false;
|
|
}
|
|
|
|
$nickname_arg = $this->trimmed('nickname');
|
|
$nickname = common_canonical_nickname($nickname_arg);
|
|
|
|
// Permanent redirect on non-canonical nickname
|
|
|
|
if ($nickname_arg != $nickname) {
|
|
$args = array('nickname' => $nickname);
|
|
common_redirect(common_local_url('grouplogo', $args), 301);
|
|
return false;
|
|
}
|
|
|
|
if (!$nickname) {
|
|
// TRANS: Client error displayed when trying to change group logo settings without having a nickname.
|
|
$this->clientError(_('No nickname.'), 404);
|
|
return false;
|
|
}
|
|
|
|
$groupid = $this->trimmed('groupid');
|
|
|
|
if ($groupid) {
|
|
$this->group = User_group::staticGet('id', $groupid);
|
|
} else {
|
|
$local = Local_group::staticGet('nickname', $nickname);
|
|
if ($local) {
|
|
$this->group = User_group::staticGet('id', $local->group_id);
|
|
}
|
|
}
|
|
|
|
if (!$this->group) {
|
|
// TRANS: Client error displayed when trying to update logo settings for a non-existing group.
|
|
$this->clientError(_('No such group.'), 404);
|
|
return false;
|
|
}
|
|
|
|
$cur = common_current_user();
|
|
|
|
if (!$cur->isAdmin($this->group)) {
|
|
// TRANS: Client error displayed when trying to change group logo settings while not being a group admin.
|
|
$this->clientError(_('You must be an admin to edit the group.'), 403);
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
function handle($args)
|
|
{
|
|
parent::handle($args);
|
|
if ($_SERVER['REQUEST_METHOD'] == 'POST') {
|
|
$this->handlePost();
|
|
} else {
|
|
$this->showForm();
|
|
}
|
|
}
|
|
|
|
function showForm($msg = null, $success = false)
|
|
{
|
|
$this->msg = $msg;
|
|
$this->success = $success;
|
|
|
|
$this->showPage();
|
|
}
|
|
|
|
/**
|
|
* Title of the page
|
|
*
|
|
* @return string Title of the page
|
|
*/
|
|
function title()
|
|
{
|
|
// TRANS: Title for group logo settings page.
|
|
return _('Group logo');
|
|
}
|
|
|
|
/**
|
|
* Instructions for use
|
|
*
|
|
* @return instructions for use
|
|
*/
|
|
function getInstructions()
|
|
{
|
|
// TRANS: Instructions for group logo page.
|
|
// TRANS: %s is the maximum file size for that site.
|
|
return sprintf(_('You can upload a logo image for your group. The maximum file size is %s.'), ImageFile::maxFileSize());
|
|
}
|
|
|
|
/**
|
|
* Content area of the page
|
|
*
|
|
* Shows a form for uploading an avatar.
|
|
*
|
|
* @return void
|
|
*/
|
|
function showContent()
|
|
{
|
|
if ($this->mode == 'crop') {
|
|
$this->showCropForm();
|
|
} else {
|
|
$this->showUploadForm();
|
|
}
|
|
}
|
|
|
|
function showUploadForm()
|
|
{
|
|
$user = common_current_user();
|
|
|
|
$profile = $user->getProfile();
|
|
|
|
if (!$profile) {
|
|
common_log_db_error($user, 'SELECT', __FILE__);
|
|
// TRANS: Server error displayed coming across a request from a user without a profile.
|
|
$this->serverError(_('User without matching profile.'));
|
|
return;
|
|
}
|
|
|
|
$original = $this->group->original_logo;
|
|
|
|
$this->elementStart('form', array('enctype' => 'multipart/form-data',
|
|
'method' => 'post',
|
|
'id' => 'form_settings_avatar',
|
|
'class' => 'form_settings',
|
|
'action' =>
|
|
common_local_url('grouplogo',
|
|
array('nickname' => $this->group->nickname))));
|
|
$this->elementStart('fieldset');
|
|
// TRANS: Group logo form legend.
|
|
$this->element('legend', null, _('Group logo'));
|
|
$this->hidden('token', common_session_token());
|
|
|
|
$this->elementStart('ul', 'form_data');
|
|
if ($original) {
|
|
$this->elementStart('li', array('id' => 'avatar_original',
|
|
'class' => 'avatar_view'));
|
|
// TRANS: Uploaded original file in group logo form.
|
|
$this->element('h2', null, _("Original"));
|
|
$this->elementStart('div', array('id'=>'avatar_original_view'));
|
|
$this->element('img', array('src' => $this->group->original_logo,
|
|
'alt' => $this->group->nickname));
|
|
$this->elementEnd('div');
|
|
$this->elementEnd('li');
|
|
}
|
|
|
|
if ($this->group->homepage_logo) {
|
|
$this->elementStart('li', array('id' => 'avatar_preview',
|
|
'class' => 'avatar_view'));
|
|
// TRANS: Header for preview of to be displayed group logo.
|
|
$this->element('h2', null, _("Preview"));
|
|
$this->elementStart('div', array('id'=>'avatar_preview_view'));
|
|
$this->element('img', array('src' => $this->group->homepage_logo,
|
|
'width' => AVATAR_PROFILE_SIZE,
|
|
'height' => AVATAR_PROFILE_SIZE,
|
|
'alt' => $this->group->nickname));
|
|
$this->elementEnd('div');
|
|
$this->elementEnd('li');
|
|
}
|
|
|
|
$this->elementStart('li', array ('id' => 'settings_attach'));
|
|
$this->element('input', array('name' => 'avatarfile',
|
|
'type' => 'file',
|
|
'id' => 'avatarfile'));
|
|
$this->element('input', array('name' => 'MAX_FILE_SIZE',
|
|
'type' => 'hidden',
|
|
'id' => 'MAX_FILE_SIZE',
|
|
'value' => ImageFile::maxFileSizeInt()));
|
|
$this->elementEnd('li');
|
|
$this->elementEnd('ul');
|
|
|
|
$this->elementStart('ul', 'form_actions');
|
|
$this->elementStart('li');
|
|
// TRANS: Submit button for uploading a group logo.
|
|
$this->submit('upload', _('Upload'));
|
|
$this->elementEnd('li');
|
|
$this->elementEnd('ul');
|
|
|
|
$this->elementEnd('fieldset');
|
|
$this->elementEnd('form');
|
|
|
|
}
|
|
|
|
function showCropForm()
|
|
{
|
|
$this->elementStart('form', array('method' => 'post',
|
|
'id' => 'form_settings_avatar',
|
|
'class' => 'form_settings',
|
|
'action' =>
|
|
common_local_url('grouplogo',
|
|
array('nickname' => $this->group->nickname))));
|
|
$this->elementStart('fieldset');
|
|
// TRANS: Legend for group logo settings fieldset.
|
|
$this->element('legend', null, _('Avatar settings'));
|
|
$this->hidden('token', common_session_token());
|
|
|
|
$this->elementStart('ul', 'form_data');
|
|
|
|
$this->elementStart('li',
|
|
array('id' => 'avatar_original',
|
|
'class' => 'avatar_view'));
|
|
// TRANS: Header for originally uploaded file before a crop on the group logo page.
|
|
$this->element('h2', null, _("Original"));
|
|
$this->elementStart('div', array('id'=>'avatar_original_view'));
|
|
$this->element('img', array('src' => Avatar::url($this->filedata['filename']),
|
|
'width' => $this->filedata['width'],
|
|
'height' => $this->filedata['height'],
|
|
'alt' => $this->group->nickname));
|
|
$this->elementEnd('div');
|
|
$this->elementEnd('li');
|
|
|
|
$this->elementStart('li',
|
|
array('id' => 'avatar_preview',
|
|
'class' => 'avatar_view'));
|
|
// TRANS: Header for the cropped group logo on the group logo page.
|
|
$this->element('h2', null, _("Preview"));
|
|
$this->elementStart('div', array('id'=>'avatar_preview_view'));
|
|
$this->element('img', array('src' => Avatar::url($this->filedata['filename']),
|
|
'width' => AVATAR_PROFILE_SIZE,
|
|
'height' => AVATAR_PROFILE_SIZE,
|
|
'alt' => $this->group->nickname));
|
|
$this->elementEnd('div');
|
|
|
|
foreach (array('avatar_crop_x', 'avatar_crop_y',
|
|
'avatar_crop_w', 'avatar_crop_h') as $crop_info) {
|
|
$this->element('input', array('name' => $crop_info,
|
|
'type' => 'hidden',
|
|
'id' => $crop_info));
|
|
}
|
|
|
|
// TRANS: Button text for cropping an uploaded group logo.
|
|
$this->submit('crop', _('Crop'));
|
|
|
|
$this->elementEnd('li');
|
|
$this->elementEnd('ul');
|
|
$this->elementEnd('fieldset');
|
|
$this->elementEnd('form');
|
|
|
|
}
|
|
|
|
/**
|
|
* Handle a post
|
|
*
|
|
* We mux on the button name to figure out what the user actually wanted.
|
|
*
|
|
* @return void
|
|
*/
|
|
function handlePost()
|
|
{
|
|
// CSRF protection
|
|
|
|
$token = $this->trimmed('token');
|
|
if (!$token || $token != common_session_token()) {
|
|
// TRANS: Form validation error message.
|
|
$this->show_form(_('There was a problem with your session token. '.
|
|
'Try again, please.'));
|
|
return;
|
|
}
|
|
|
|
if ($this->arg('upload')) {
|
|
$this->uploadLogo();
|
|
} else if ($this->arg('crop')) {
|
|
$this->cropLogo();
|
|
} else {
|
|
// TRANS: Form validation error message when an unsupported argument is used.
|
|
$this->showForm(_('Unexpected form submission.'));
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Handle an image upload
|
|
*
|
|
* Does all the magic for handling an image upload, and crops the
|
|
* image by default.
|
|
*
|
|
* @return void
|
|
*/
|
|
function uploadLogo()
|
|
{
|
|
try {
|
|
$imagefile = ImageFile::fromUpload('avatarfile');
|
|
} catch (Exception $e) {
|
|
$this->showForm($e->getMessage());
|
|
return;
|
|
}
|
|
|
|
$type = $imagefile->preferredType();
|
|
$filename = Avatar::filename($this->group->id,
|
|
image_type_to_extension($type),
|
|
null,
|
|
'group-temp-'.common_timestamp());
|
|
|
|
$filepath = Avatar::path($filename);
|
|
|
|
$imagefile->copyTo($filepath);
|
|
|
|
$filedata = array('filename' => $filename,
|
|
'filepath' => $filepath,
|
|
'width' => $imagefile->width,
|
|
'height' => $imagefile->height,
|
|
'type' => $type);
|
|
|
|
$_SESSION['FILEDATA'] = $filedata;
|
|
|
|
$this->filedata = $filedata;
|
|
|
|
$this->mode = 'crop';
|
|
|
|
// TRANS: Form instructions on the group logo page.
|
|
$this->showForm(_('Pick a square area of the image to be the logo.'),
|
|
true);
|
|
}
|
|
|
|
/**
|
|
* Handle the results of jcrop.
|
|
*
|
|
* @return void
|
|
*/
|
|
function cropLogo()
|
|
{
|
|
$filedata = $_SESSION['FILEDATA'];
|
|
|
|
if (!$filedata) {
|
|
// TRANS: Server error displayed trying to crop an uploaded group logo that is no longer present.
|
|
$this->serverError(_('Lost our file data.'));
|
|
return;
|
|
}
|
|
|
|
// If image is not being cropped assume pos & dimentions of original
|
|
$dest_x = $this->arg('avatar_crop_x') ? $this->arg('avatar_crop_x'):0;
|
|
$dest_y = $this->arg('avatar_crop_y') ? $this->arg('avatar_crop_y'):0;
|
|
$dest_w = $this->arg('avatar_crop_w') ? $this->arg('avatar_crop_w'):$filedata['width'];
|
|
$dest_h = $this->arg('avatar_crop_h') ? $this->arg('avatar_crop_h'):$filedata['height'];
|
|
$size = min($dest_w, $dest_h);
|
|
$size = ($size > MAX_ORIGINAL) ? MAX_ORIGINAL:$size;
|
|
|
|
$imagefile = new ImageFile($this->group->id, $filedata['filepath']);
|
|
$filename = $imagefile->resize($size, $dest_x, $dest_y, $dest_w, $dest_h);
|
|
|
|
if ($this->group->setOriginal($filename)) {
|
|
@unlink($filedata['filepath']);
|
|
unset($_SESSION['FILEDATA']);
|
|
$this->mode = 'upload';
|
|
// TRANS: Form success message after updating a group logo.
|
|
$this->showForm(_('Logo updated.'), true);
|
|
} else {
|
|
// TRANS: Form failure message after failing to update a group logo.
|
|
$this->showForm(_('Failed updating logo.'));
|
|
}
|
|
}
|
|
|
|
function showPageNotice()
|
|
{
|
|
if ($this->msg) {
|
|
$this->element('div', ($this->success) ? 'success' : 'error',
|
|
$this->msg);
|
|
} else {
|
|
$inst = $this->getInstructions();
|
|
$output = common_markup_to_html($inst);
|
|
|
|
$this->elementStart('div', 'instructions');
|
|
$this->raw($output);
|
|
$this->elementEnd('div');
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Add the jCrop stylesheet
|
|
*
|
|
* @return void
|
|
*/
|
|
|
|
function showStylesheets()
|
|
{
|
|
parent::showStylesheets();
|
|
$this->cssLink('css/jquery.Jcrop.css','base','screen, projection, tv');
|
|
}
|
|
|
|
/**
|
|
* Add the jCrop scripts
|
|
*
|
|
* @return void
|
|
*/
|
|
|
|
function showScripts()
|
|
{
|
|
parent::showScripts();
|
|
|
|
if ($this->mode == 'crop') {
|
|
$this->script('jcrop/jquery.Jcrop.min.js');
|
|
$this->script('jcrop/jquery.Jcrop.go.js');
|
|
}
|
|
|
|
$this->autofocus('avatarfile');
|
|
}
|
|
|
|
function showLocalNav()
|
|
{
|
|
$nav = new GroupNav($this, $this->group);
|
|
$nav->show();
|
|
}
|
|
}
|