Diogo Peralta Cordeiro
3f61537140
Remove Attachment Scope Fixed some minor bugs Scope will be implemented later in v3. It doesn't make sense to have the scope handling being per attachment. Different actors can post the same attachment with different scopes. The attachment controller will assume the highest level of scope applied to the attachment and the rest will be handled at the note level. Motivation: * Remove title from attachment, as it's part of the relation between attachment and note. * Remove actor from attachment, many actors may publish the same attachment. * Remove is_local from attachment, as it's part of the relation between attachment and note. * Remove remote_url from attachment, different urls can return the same attachment. Addition: * Attachment now has a lives attribute, it's a reference counter with a nicer name * GSActorToAttachment * GSActorToRemoteURL * RemoteURL * RemoteURLToNote * RemoteURLToAttachment * AttachmentToNote now has a title attribute
85 lines
3.0 KiB
PHP
85 lines
3.0 KiB
PHP
<?php
|
|
|
|
// {{{ License
|
|
|
|
// This file is part of GNU social - https://www.gnu.org/software/social
|
|
//
|
|
// GNU social is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// GNU social is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with GNU social. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
// }}}
|
|
|
|
namespace App\Tests\Core;
|
|
|
|
use App\Core\DB\DB;
|
|
use App\Util\GNUsocialTestCase;
|
|
|
|
class AttachmentTest extends GNUsocialTestCase
|
|
{
|
|
public function testNoAttachmentID()
|
|
{
|
|
// This calls static::bootKernel(), and creates a "client" that is acting as the browser
|
|
$client = static::createClient();
|
|
$client->request('GET', '/attachment');
|
|
$this->assertResponseStatusCodeSame(404);
|
|
$client->request('GET', '/attachment/-1');
|
|
$this->assertResponseStatusCodeSame(404);
|
|
$client->request('GET', '/attachment/asd');
|
|
$this->assertResponseStatusCodeSame(404);
|
|
$client->request('GET', '/attachment/0');
|
|
// In the meantime, throwing ClientException doesn't actually result in the reaching the UI, as it's intercepted
|
|
// by the helpful framework that displays the stack traces and such. This should be easily fixable when we have
|
|
// our own error pages
|
|
$this->assertSelectorTextContains('.stacktrace', 'ClientException');
|
|
}
|
|
|
|
private function testAttachment(string $suffix)
|
|
{
|
|
$client = static::createClient();
|
|
$attachment = DB::findOneBy('attachment', ['filehash' => '5d8ee7ead51a28803b4ee5cb2306a0b90b6ba570f1e5bcc2209926f6ab08e7ea']);
|
|
$crawler = $client->request('GET', "/attachment/{$attachment->getId()}{$suffix}");
|
|
}
|
|
|
|
public function testAttachmentShow()
|
|
{
|
|
$this->testAttachment('');
|
|
$this->assertResponseIsSuccessful();
|
|
$this->assertSelectorTextContains('figure figcaption', '5d8ee7ead51a28803b4ee5cb2306a0b90b6ba570f1e5bcc2209926f6ab08e7ea');
|
|
}
|
|
|
|
public function testAttachmentView()
|
|
{
|
|
$this->testAttachment('/view');
|
|
$this->assertResponseIsSuccessful();
|
|
}
|
|
|
|
public function testAttachmentDownload()
|
|
{
|
|
$this->testAttachment('/download');
|
|
$this->assertResponseIsSuccessful();
|
|
}
|
|
|
|
public function testAttachmentThumbnail()
|
|
{
|
|
$this->testAttachment('/thumbnail');
|
|
$this->assertResponseIsSuccessful();
|
|
}
|
|
|
|
public function testAttachmentThumbnailWrongSize()
|
|
{
|
|
$this->testAttachment('/thumbnail?w=1&h=1');
|
|
$this->assertSelectorTextContains('.stacktrace', 'ClientException');
|
|
// $this->assertResponseStatusCodeSame(400);
|
|
}
|
|
}
|