GNUsocial/gnusocial.rocks
4
0
Fork 1
Code Issues Pull Requests Releases Activity

improve text of post 4

Browse Source
This commit is contained in:
Diogo Peralta Cordeiro
2021-08-19 03:20:52 +01:00
parent 69d0d5d6e0
commit f9f64f242c
8 changed files with 83 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files

91
v3/updates-improve-the-attachments-system.html
View File

@@ -43,14 +43,30 @@ GNU social development team
</div>
<!-- text begin -->
<p>With the milestone "Port Media system from v2" we had ported the existing
<p>With the milestone <a href="https://www.gnusocial.rocks/v3/milestone-port-media-handling-from-v2.html">Port Media system from
v2</a> we had ported the existing
attachment system. The fact is that this system wasn't good enough.</p>
<p>It's always important to start with the original code as that allows us
to review past decisions and understand all the corner cases.</p>
to review past decisions and understand all the corner cases previously
considered.</p>
<p>Sadly, what motivated us to re-design the attachment system was the
non-considered corner cases.</p>
<p>Sadly, what motivated us to re-design the attachment system were the
non-considered corner cases. In particular:</p>
<ul>
<li>Remove <code>title</code> from attachment, as it's part of the relation between attachment and note.</li>
<li>Remove <code>actor</code> from attachment, many actors may publish the same attachment.</li>
<li>Remove <code>is_local</code> from attachment, as it's part of the relation between attachment and note.</li>
<li>Remove <code>remote_url</code> from attachment, different urls can return the same attachment.</li>
<li>Attachment now has a reference counter </li>
<li>Add entity GSActorToAttachment</li>
<li>Add entity GSActorToRemoteURL</li>
<li>Add entity RemoteURL</li>
<li>Add entity RemoteURLToNote</li>
<li>Add entity RemoteURLToAttachment</li>
<li>AttachmentToNote now has a title attribute</li>
</ul>
<p>Key commits:</p>
@@ -59,7 +75,7 @@ non-considered corner cases.</p>
<li><a href="https://code.undefinedhackers.net/GNUsocial/gnu-social/commit/c381e58d3307e7dd07abeb9cf5b3998e34f5bd48">c381e58d33 - [ENTITY] Refactor RemoteURL entities to Link</a></li>
</ul>
<p>The reasoning leading to these entities and structure is detailed in our
<p>The structural changes and how it compares to v2 is detailed in our
<a href="http://agile.gnusocial.rocks/doku.php?id=attachment">wiki</a>.</p>
<p>Some relevant observations:</p>
@@ -71,71 +87,6 @@ any remote URL being shared in a note.</li>
</ul>
<!-- text end -->
<!-- entry end -->
</div>