diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #31308 [HttpClient] fix skipping h2push test case (nicolas-grekas)

Browse Source 
This PR was merged into the 4.3-dev branch.

Discussion
----------

[HttpClient] fix skipping h2push test case

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30975
| License       | MIT
| Doc PR        | -

Commits
-------

3aaa742d40 [HttpClient] fix skipping h2push test case
This commit is contained in:
Fabien Potencier 2019-04-29 08:25:19 +02:00
commit 002b48dfc3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php
View File

@ -28,7 +28,6 @@ class CurlHttpClientTest extends HttpClientTestCase
/**
* @requires PHP 7.2.17
* @requires extension curl 7.61
*/
public function testHttp2Push()
{
@ -36,8 +35,8 @@ class CurlHttpClientTest extends HttpClientTestCase
$this->markTestSkipped('PHP 7.3.0 to 7.3.3 don\'t support HTTP/2 PUSH');
}
if (!\defined('CURLMOPT_PUSHFUNCTION') || !(CURL_VERSION_HTTP2 & curl_version()['features'])) {
$this->markTestSkipped('curl is not compiled with support for HTTP/2 PUSH');
if (!\defined('CURLMOPT_PUSHFUNCTION') || 0x073d00 > ($v = curl_version())['version_number'] || !(CURL_VERSION_HTTP2 & $v['features'])) {
$this->markTestSkipped('curl <7.61 is used or it is not compiled with support for HTTP/2 PUSH');
}
$logger = new class() extends AbstractLogger {