minor #26037 [Lock] Fix strategy tests (Valouleloup)
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #26037).
Discussion
----------
[Lock] Fix strategy tests
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Not sure if it is a mistake, but in Phpunit tests need to begin with ` test ` to be played, right ?
Commits
-------
afbb8be
Fix lock strategy tests
This commit is contained in:
commit
003e616008
@ -82,7 +82,7 @@ class ConsensusStrategyTest extends TestCase
|
|||||||
/**
|
/**
|
||||||
* @dataProvider provideIndeterminate
|
* @dataProvider provideIndeterminate
|
||||||
*/
|
*/
|
||||||
public function canBeMet($success, $failure, $total, $isMet)
|
public function testCanBeMet($success, $failure, $total, $isMet)
|
||||||
{
|
{
|
||||||
$this->assertSame($isMet, $this->strategy->canBeMet($failure, $total));
|
$this->assertSame($isMet, $this->strategy->canBeMet($failure, $total));
|
||||||
}
|
}
|
||||||
|
@ -82,7 +82,7 @@ class UnanimousStrategyTest extends TestCase
|
|||||||
/**
|
/**
|
||||||
* @dataProvider provideIndeterminate
|
* @dataProvider provideIndeterminate
|
||||||
*/
|
*/
|
||||||
public function canBeMet($success, $failure, $total, $isMet)
|
public function testCanBeMet($success, $failure, $total, $isMet)
|
||||||
{
|
{
|
||||||
$this->assertSame($isMet, $this->strategy->canBeMet($failure, $total));
|
$this->assertSame($isMet, $this->strategy->canBeMet($failure, $total));
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user