From 048d09213e0861d7f5db27b1940008ce4bd0a012 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Fri, 13 Mar 2020 23:17:44 +0100 Subject: [PATCH] [DI] skip untyped properties in AutowireRequiredPropertiesPass --- .../Compiler/AutowireRequiredPropertiesPass.php | 3 +++ .../Tests/Fixtures/includes/autowiring_classes_74.php | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredPropertiesPass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredPropertiesPass.php index 934bde8dd1..945b8c9e01 100644 --- a/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredPropertiesPass.php +++ b/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredPropertiesPass.php @@ -42,6 +42,9 @@ class AutowireRequiredPropertiesPass extends AbstractRecursivePass $properties = $value->getProperties(); foreach ($reflectionClass->getProperties() as $reflectionProperty) { + if (!$reflectionProperty->hasType()) { + continue; + } if (false === $doc = $reflectionProperty->getDocComment()) { continue; } diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_74.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_74.php index f1d76f2f0c..60b7fa7ca0 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_74.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_74.php @@ -9,6 +9,11 @@ class PropertiesInjection */ public Bar $plop; + /** + * @required + */ + public $plip; + public function __construct(A $a) { }