[Cache][Contracts] We must save the item or the trait does not have any effect

src/Symfony/Contracts/Cache/GetForCacheItemPoolTrait.php

@@ -36,6 +36,7 @@ trait GetForCacheItemPoolTrait
         if (INF === $beta || !$item->isHit()) {
             $value = $callback($item);
             $item->set($value);
+            $this->save($item);
         }
 
         return $item->get();

src/Symfony/Contracts/Tests/Cache/GetForCacheItemPoolTraitTest.php

@@ -0,0 +1,132 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Contracts\Tests\Cache;
+
+use PHPUnit\Framework\TestCase;
+use Psr\Cache\CacheItemInterface;
+use Symfony\Contracts\Cache\GetForCacheItemPoolTrait;
+
+/**
+ * @author Tobias Nyholm <tobias.nyholm@gmail.com>
+ */
+class GetForCacheItemPoolTraitTest extends TestCase
+{
+    public function testSave()
+    {
+        $item = $this->getMockBuilder(CacheItemInterface::class)->getMock();
+        $item->method('isHit')
+            ->willReturn(false);
+
+        $item->expects($this->once())
+            ->method('set')
+            ->with('computed data');
+
+        $cache = $this->getMockBuilder(ClassUsingTrait::class)
+            ->setMethods(array('getItem', 'save'))
+            ->getMock();
+        $cache->expects($this->once())
+            ->method('getItem')
+            ->with('key')
+            ->willReturn($item);
+        $cache->expects($this->once())
+            ->method('save');
+
+        $callback = function (CacheItemInterface $item) {
+            return 'computed data';
+        };
+
+        $cache->get('key', $callback);
+    }
+
+    public function testNoCallbackCallOnHit()
+    {
+        $item = $this->getMockBuilder(CacheItemInterface::class)->getMock();
+        $item->method('isHit')
+            ->willReturn(true);
+
+        $item->expects($this->never())
+            ->method('set');
+
+        $cache = $this->getMockBuilder(ClassUsingTrait::class)
+            ->setMethods(array('getItem', 'save'))
+            ->getMock();
+
+        $cache->expects($this->once())
+            ->method('getItem')
+            ->with('key')
+            ->willReturn($item);
+        $cache->expects($this->never())
+            ->method('save');
+
+        $callback = function (CacheItemInterface $item) {
+            $this->assertTrue(false, 'This code should never be reached');
+        };
+
+        $cache->get('key', $callback);
+    }
+
+    public function testRecomputeOnBetaInf()
+    {
+        $item = $this->getMockBuilder(CacheItemInterface::class)->getMock();
+        $item->method('isHit')
+            // We want to recompute even if it is a hit
+            ->willReturn(true);
+
+        $item->expects($this->once())
+            ->method('set')
+            ->with('computed data');
+
+        $cache = $this->getMockBuilder(ClassUsingTrait::class)
+            ->setMethods(array('getItem', 'save'))
+            ->getMock();
+
+        $cache->expects($this->once())
+            ->method('getItem')
+            ->with('key')
+            ->willReturn($item);
+        $cache->expects($this->once())
+            ->method('save');
+
+        $callback = function (CacheItemInterface $item) {
+            return 'computed data';
+        };
+
+        $cache->get('key', $callback, INF);
+    }
+
+    public function testExceptionOnNegativeBeta()
+    {
+        $cache = $this->getMockBuilder(ClassUsingTrait::class)
+            ->setMethods(array('getItem', 'save'))
+            ->getMock();
+
+        $callback = function (CacheItemInterface $item) {
+            return 'computed data';
+        };
+
+        $this->expectException(\InvalidArgumentException::class);
+        $cache->get('key', $callback, -2);
+    }
+}
+
+class ClassUsingTrait
+{
+    use GetForCacheItemPoolTrait;
+
+    public function getItem($key)
+    {
+    }
+
+    public function save(CacheItemInterface $item)
+    {
+    }
+}

src/Symfony/Contracts/composer.json

@@ -19,6 +19,7 @@
         "php": "^7.1.3"
     },
     "require-dev": {
+        "psr/cache": "^1.0",
         "psr/container": "^1.0"
     },
     "suggest": {