bug #34198 [HttpClient] Fix perf issue when doing thousands of requests with curl (nicolas-grekas)
This PR was merged into the 4.3 branch.
Discussion
----------
[HttpClient] Fix perf issue when doing thousands of requests with curl
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Performing while scheduling requests was a terrible idea: it makes buffers fill in memory and requires CPU do deal with the pending list, while all this in dealt with much more efficiently by any response-reading code that comes after.
Commits
-------
e388b739ed
[HttpClient] Fix perf issue when doing thousands of requests with curl
This commit is contained in:
commit
06e745847d
|
@ -142,7 +142,6 @@ final class CurlResponse implements ResponseInterface
|
||||||
// Schedule the request in a non-blocking way
|
// Schedule the request in a non-blocking way
|
||||||
$multi->openHandles[$id] = [$ch, $options];
|
$multi->openHandles[$id] = [$ch, $options];
|
||||||
curl_multi_add_handle($multi->handle, $ch);
|
curl_multi_add_handle($multi->handle, $ch);
|
||||||
self::perform($multi);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
Reference in New Issue