removed unneeded private methods
This commit is contained in:
parent
ca050f6cc3
commit
07cfa93fc1
@ -34,8 +34,12 @@ class UpdateOperation
|
||||
*/
|
||||
public function __construct(int $operationType, string $attribute, ?array $values)
|
||||
{
|
||||
$this->assertValidOperationType($operationType);
|
||||
$this->assertNullValuesOnRemoveAll($operationType, $values);
|
||||
if (!in_array($operationType, $this->validOperationTypes, true)) {
|
||||
throw new UpdateOperationException(sprintf('"%s" is not a valid modification type.', $operationType));
|
||||
}
|
||||
if (LDAP_MODIFY_BATCH_REMOVE_ALL === $operationType && null !== $values) {
|
||||
throw new UpdateOperationException(sprintf('$values must be null for LDAP_MODIFY_BATCH_REMOVE_ALL operation, "%s" given.', gettype($values)));
|
||||
}
|
||||
|
||||
$this->operationType = $operationType;
|
||||
$this->attribute = $attribute;
|
||||
@ -50,27 +54,4 @@ class UpdateOperation
|
||||
'values' => $this->values,
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param int $operationType
|
||||
*/
|
||||
private function assertValidOperationType(int $operationType): void
|
||||
{
|
||||
if (!in_array($operationType, $this->validOperationTypes, true)) {
|
||||
throw new UpdateOperationException(sprintf('"%s" is not a valid modification type.', $operationType));
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* @param int $operationType
|
||||
* @param array|null $values
|
||||
*
|
||||
* @throws \Symfony\Component\Ldap\Exception\UpdateOperationException
|
||||
*/
|
||||
private function assertNullValuesOnRemoveAll(int $operationType, ?array $values): void
|
||||
{
|
||||
if (LDAP_MODIFY_BATCH_REMOVE_ALL === $operationType && null !== $values) {
|
||||
throw new UpdateOperationException(sprintf('$values must be null for LDAP_MODIFY_BATCH_REMOVE_ALL operation, "%s" given.', gettype($values)));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user