From 095b9f3a30efd7c3c1ccd882d3ec310cb542f7af Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Tue, 9 Oct 2018 15:14:13 +0200 Subject: [PATCH] fix a return type hint --- src/Symfony/Component/Form/FormBuilder.php | 4 ++-- src/Symfony/Component/Form/Tests/FormBuilderTest.php | 10 ++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/Form/FormBuilder.php b/src/Symfony/Component/Form/FormBuilder.php index b9b01a6c7d..30e1ac0ebe 100644 --- a/src/Symfony/Component/Form/FormBuilder.php +++ b/src/Symfony/Component/Form/FormBuilder.php @@ -235,9 +235,9 @@ class FormBuilder extends FormConfigBuilder implements \IteratorAggregate, FormB } /** - * Converts an unresolved child into a {@link FormBuilder} instance. + * Converts an unresolved child into a {@link FormBuilderInterface} instance. */ - private function resolveChild(string $name): self + private function resolveChild(string $name): FormBuilderInterface { $info = $this->unresolvedChildren[$name]; $child = $this->create($name, $info['type'], $info['options']); diff --git a/src/Symfony/Component/Form/Tests/FormBuilderTest.php b/src/Symfony/Component/Form/Tests/FormBuilderTest.php index 2ecd19f5ea..0326f545af 100644 --- a/src/Symfony/Component/Form/Tests/FormBuilderTest.php +++ b/src/Symfony/Component/Form/Tests/FormBuilderTest.php @@ -13,7 +13,9 @@ namespace Symfony\Component\Form\Tests; use PHPUnit\Framework\TestCase; use Symfony\Component\Form\ButtonBuilder; +use Symfony\Component\Form\Extension\Core\Type\SubmitType; use Symfony\Component\Form\FormBuilder; +use Symfony\Component\Form\FormFactoryBuilder; use Symfony\Component\Form\SubmitButtonBuilder; class FormBuilderTest extends TestCase @@ -228,6 +230,14 @@ class FormBuilderTest extends TestCase $this->assertEmpty($unresolvedChildren->getValue($config)); } + public function testGetButtonBuilderBeforeExplicitlyResolvingAllChildren() + { + $builder = new FormBuilder('name', null, $this->dispatcher, (new FormFactoryBuilder())->getFormFactory()); + $builder->add('submit', SubmitType::class); + + $this->assertInstanceOf(ButtonBuilder::class, $builder->get('submit')); + } + private function getFormBuilder($name = 'name') { $mock = $this->getMockBuilder('Symfony\Component\Form\FormBuilder')