From 09f727b1f1725e303a21202b6bbb90d9c3f0b029 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Tue, 13 Aug 2013 11:17:13 +0200 Subject: [PATCH] changed the ESI fragment renderer to be always registered --- .../Bundle/FrameworkBundle/Resources/config/esi.xml | 8 -------- .../Resources/config/fragment_renderer.xml | 8 ++++++++ .../Component/HttpKernel/Fragment/EsiFragmentRenderer.php | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/esi.xml b/src/Symfony/Bundle/FrameworkBundle/Resources/config/esi.xml index dd8e801075..3038f40e97 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Resources/config/esi.xml +++ b/src/Symfony/Bundle/FrameworkBundle/Resources/config/esi.xml @@ -7,7 +7,6 @@ Symfony\Component\HttpKernel\HttpCache\Esi Symfony\Component\HttpKernel\EventListener\EsiListener - Symfony\Component\HttpKernel\Fragment\EsiFragmentRenderer @@ -17,12 +16,5 @@ - - - - - - %fragment.path% - diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/fragment_renderer.xml b/src/Symfony/Bundle/FrameworkBundle/Resources/config/fragment_renderer.xml index 595db6d274..4773339906 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Resources/config/fragment_renderer.xml +++ b/src/Symfony/Bundle/FrameworkBundle/Resources/config/fragment_renderer.xml @@ -9,6 +9,7 @@ Symfony\Component\HttpKernel\Fragment\InlineFragmentRenderer Symfony\Bundle\FrameworkBundle\Fragment\ContainerAwareHIncludeFragmentRenderer + Symfony\Component\HttpKernel\Fragment\EsiFragmentRenderer /_fragment @@ -33,5 +34,12 @@ %fragment.renderer.hinclude.global_template% %fragment.path% + + + + + + %fragment.path% + diff --git a/src/Symfony/Component/HttpKernel/Fragment/EsiFragmentRenderer.php b/src/Symfony/Component/HttpKernel/Fragment/EsiFragmentRenderer.php index 68b1a87da6..a491a85ade 100644 --- a/src/Symfony/Component/HttpKernel/Fragment/EsiFragmentRenderer.php +++ b/src/Symfony/Component/HttpKernel/Fragment/EsiFragmentRenderer.php @@ -35,7 +35,7 @@ class EsiFragmentRenderer extends RoutableFragmentRenderer * @param Esi $esi An Esi instance * @param InlineFragmentRenderer $inlineStrategy The inline strategy to use when ESI is not supported */ - public function __construct(Esi $esi, InlineFragmentRenderer $inlineStrategy) + public function __construct(Esi $esi = null, InlineFragmentRenderer $inlineStrategy) { $this->esi = $esi; $this->inlineStrategy = $inlineStrategy; @@ -56,7 +56,7 @@ class EsiFragmentRenderer extends RoutableFragmentRenderer */ public function render($uri, Request $request, array $options = array()) { - if (!$this->esi->hasSurrogateEsiCapability($request)) { + if (!$this->esi || !$this->esi->hasSurrogateEsiCapability($request)) { return $this->inlineStrategy->render($uri, $request, $options); }