diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Bridge/Doctrine] fix review

This commit is contained in:
Nicolas Grekas 2019-08-26 13:01:58 +02:00
parent e9886e4e4c
commit 0a00af2b77
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Bridge/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php
View File

@ -89,6 +89,6 @@ class ORMQueryBuilderLoader implements EntityLoaderInterface
return $qb->andWhere($where)
->getQuery()
->setParameter($parameter, $values, $parameterType)
->getResult() ?: [];
->getResult();
}
}

16
src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/ORMQueryBuilderLoaderTest.php
View File

@ -37,6 +37,10 @@ class ORMQueryBuilderLoaderTest extends TestCase
->setMethods(['setParameter', 'getResult', 'getSql', '_doExecute'])
->getMock();
$query
->method('getResult')
->willReturn([]);
$query->expects($this->once())
->method('setParameter')
->with('ORMQueryBuilderLoader_getEntitiesByIds_id', [1, 2], $expectedType)
@ -66,6 +70,10 @@ class ORMQueryBuilderLoaderTest extends TestCase
->setMethods(['setParameter', 'getResult', 'getSql', '_doExecute'])
->getMock();
$query
->method('getResult')
->willReturn([]);
$query->expects($this->once())
->method('setParameter')
->with('ORMQueryBuilderLoader_getEntitiesByIds_id', [1, 2, 3, '9223372036854775808'], Connection::PARAM_INT_ARRAY)
@ -98,6 +106,10 @@ class ORMQueryBuilderLoaderTest extends TestCase
->setMethods(['setParameter', 'getResult', 'getSql', '_doExecute'])
->getMock();
$query
->method('getResult')
->willReturn([]);
$query->expects($this->once())
->method('setParameter')
->with('ORMQueryBuilderLoader_getEntitiesByIds_id', ['71c5fd46-3f16-4abb-bad7-90ac1e654a2d', 'b98e8e11-2897-44df-ad24-d2627eb7f499'], Connection::PARAM_STR_ARRAY)
@ -133,6 +145,10 @@ class ORMQueryBuilderLoaderTest extends TestCase
->setMethods(['setParameter', 'getResult', 'getSql', '_doExecute'])
->getMock();
$query
->method('getResult')
->willReturn([]);
$query->expects($this->once())
->method('setParameter')
->with('ORMQueryBuilderLoader_getEntitiesByIds_id_value', [1, 2, 3], Connection::PARAM_INT_ARRAY)