From 0a4250122f95857c95b07c5ee1504956c897a74f Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Fri, 28 Dec 2012 18:06:25 +0100 Subject: [PATCH] [HttpKernel] tweaked logging in the exception listener When there is no logger, we should only log critical errors (this is more sensible than the current behavior). --- .../Component/HttpKernel/EventListener/ExceptionListener.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php b/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php index 12bd8dad04..8c49d022b0 100644 --- a/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php +++ b/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php @@ -94,13 +94,14 @@ class ExceptionListener implements EventSubscriberInterface */ protected function logException(\Exception $exception, $message, $original = true) { + $isCritical = !$exception instanceof HttpExceptionInterface || $exception->getStatusCode() >= 500; if (null !== $this->logger) { - if (!$exception instanceof HttpExceptionInterface || $exception->getStatusCode() >= 500) { + if ($isCritical) { $this->logger->crit($message); } else { $this->logger->err($message); } - } else { + } elseif (!$original || $isCritical) { error_log($message); } }