[BrowserKit] deprecated Response::buildHeader()

This commit is contained in:
Fabien Potencier 2019-01-14 15:23:01 +01:00
parent e8e52355d4
commit 0abff982e0
4 changed files with 9 additions and 2 deletions

View File

@ -4,6 +4,7 @@ UPGRADE FROM 4.2 to 4.3
BrowserKit BrowserKit
---------- ----------
* Deprecated `Response::buildHeader()`
* Deprecated `Response::getStatus()`, use `Response::getStatusCode()` instead * Deprecated `Response::getStatus()`, use `Response::getStatusCode()` instead
Config Config

View File

@ -4,6 +4,7 @@ UPGRADE FROM 4.x to 5.0
BrowserKit BrowserKit
---------- ----------
* Removed `Response::buildHeader()`
* Removed `Response::getStatus()`, use `Response::getStatusCode()` instead * Removed `Response::getStatus()`, use `Response::getStatusCode()` instead
* The `Client::submit()` method has a new `$serverParameters` argument. * The `Client::submit()` method has a new `$serverParameters` argument.

View File

@ -4,6 +4,7 @@ CHANGELOG
4.3.0 4.3.0
----- -----
* Deprecated `Response::buildHeader()`
* Deprecated `Response::getStatus()`, use `Response::getStatusCode()` instead * Deprecated `Response::getStatus()`, use `Response::getStatusCode()` instead
4.2.0 4.2.0

View File

@ -45,10 +45,10 @@ class Response
$headers = ''; $headers = '';
foreach ($this->headers as $name => $value) { foreach ($this->headers as $name => $value) {
if (\is_string($value)) { if (\is_string($value)) {
$headers .= $this->buildHeader($name, $value); $headers .= sprintf("%s: %s\n", $name, $value);
} else { } else {
foreach ($value as $headerValue) { foreach ($value as $headerValue) {
$headers .= $this->buildHeader($name, $headerValue); $headers .= sprintf("%s: %s\n", $name, $headerValue);
} }
} }
} }
@ -63,9 +63,13 @@ class Response
* @param string $value The header value * @param string $value The header value
* *
* @return string The built header line * @return string The built header line
*
* @deprecated since Symfony 4.3
*/ */
protected function buildHeader($name, $value) protected function buildHeader($name, $value)
{ {
@trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.3.', __METHOD__), E_USER_DEPRECATED);
return sprintf("%s: %s\n", $name, $value); return sprintf("%s: %s\n", $name, $value);
} }