From 0c1484b849d57a768c09d0a2917e8cd936458974 Mon Sep 17 00:00:00 2001 From: Rudy Onfroy Date: Thu, 13 Sep 2018 15:16:37 +0200 Subject: [PATCH] [OptionsResolver] remove dead code and useless else --- .../OptionsResolver/OptionsResolver.php | 20 +++---------------- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/src/Symfony/Component/OptionsResolver/OptionsResolver.php b/src/Symfony/Component/OptionsResolver/OptionsResolver.php index b6bda0708e..83d81969cb 100644 --- a/src/Symfony/Component/OptionsResolver/OptionsResolver.php +++ b/src/Symfony/Component/OptionsResolver/OptionsResolver.php @@ -770,7 +770,9 @@ class OptionsResolver implements Options // Don't include closures in the exception message continue; - } elseif ($value === $allowedValue) { + } + + if ($value === $allowedValue) { $success = true; break; } @@ -1060,20 +1062,4 @@ class OptionsResolver implements Options { return (\function_exists($isFunction = 'is_'.$type) && $isFunction($value)) || $value instanceof $type; } - - /** - * @return array - */ - private function getInvalidValues(array $arrayValues, $type) - { - $invalidValues = array(); - - foreach ($arrayValues as $key => $value) { - if (!self::isValueValidType($type, $value)) { - $invalidValues[$key] = $value; - } - } - - return $invalidValues; - } }