From 0ca4ed33fe55aa7d09a3b4015f992b7dea4fc068 Mon Sep 17 00:00:00 2001 From: Jordi Boggiano Date: Tue, 3 May 2011 14:43:22 +0200 Subject: [PATCH] [HttpKernel] Log non-http exceptions as critical as well --- .../Component/HttpKernel/Debug/ExceptionListener.php | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/HttpKernel/Debug/ExceptionListener.php b/src/Symfony/Component/HttpKernel/Debug/ExceptionListener.php index 7fde482be7..16d09def7a 100644 --- a/src/Symfony/Component/HttpKernel/Debug/ExceptionListener.php +++ b/src/Symfony/Component/HttpKernel/Debug/ExceptionListener.php @@ -49,7 +49,12 @@ class ExceptionListener $request = $event->getRequest(); if (null !== $this->logger) { - $this->logger->err(sprintf('%s: %s (uncaught exception)', get_class($exception), $exception->getMessage())); + $message = sprintf('%s: %s (uncaught exception)', get_class($exception), $exception->getMessage()); + if (!$exception instanceof HttpExceptionInterface || $exception->getStatusCode() >= 500) { + $this->logger->crit($message); + } else { + $this->logger->err($message); + } } else { error_log(sprintf('Uncaught PHP Exception %s: "%s" at %s line %s', get_class($exception), $exception->getMessage(), $exception->getFile(), $exception->getLine())); } @@ -77,7 +82,7 @@ class ExceptionListener } catch (\Exception $e) { $message = sprintf('Exception thrown when handling an exception (%s: %s)', get_class($e), $e->getMessage()); if (null !== $this->logger) { - if ($exception instanceof HttpExceptionInterface && $exception->getStatusCode() >= 500) { + if (!$exception instanceof HttpExceptionInterface || $exception->getStatusCode() >= 500) { $this->logger->crit($message); } else { $this->logger->err($message);