From 8f0b629726b635c8cfe888607f1e852e2a331d67 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Dunglas?= Date: Wed, 1 Mar 2017 22:48:20 +0100 Subject: [PATCH] [DependencyInjection] Add a missing test for @required autowiring --- .../Tests/Compiler/AutowirePassTest.php | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php index 7f542b00f9..ccb7c66c81 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php @@ -473,7 +473,7 @@ class AutowirePassTest extends TestCase $methodCalls = $container->getDefinition('setter_injection')->getMethodCalls(); $this->assertEquals( - array('setWithCallsConfigured', 'setFoo', 'setDependencies'), + array('setWithCallsConfigured', 'setFoo', 'setDependencies', 'setChildMethodWithoutDocBlock'), array_column($methodCalls, 0) ); @@ -509,7 +509,7 @@ class AutowirePassTest extends TestCase $methodCalls = $container->getDefinition('setter_injection')->getMethodCalls(); $this->assertEquals( - array('notASetter', 'setFoo', 'setDependencies', 'setWithCallsConfigured'), + array('notASetter', 'setFoo', 'setDependencies', 'setWithCallsConfigured', 'setChildMethodWithoutDocBlock'), array_column($methodCalls, 0) ); $this->assertEquals( @@ -953,6 +953,10 @@ class SetterInjection extends SetterInjectionParent { // should not be called } + + public function setChildMethodWithoutDocBlock(A $a) + { + } } class SetterInjectionParent @@ -972,6 +976,11 @@ class SetterInjectionParent public function setWithCallsConfigured(A $a) { } + + /** @required */ + public function setChildMethodWithoutDocBlock(A $a) + { + } } class SetterInjectionCollision