diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions

Browse Source
This commit is contained in:
Nicolas Grekas 2017-12-20 12:18:49 +01:00
parent d731a2748f
commit 0d4bce6676
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Symfony/Component/Process/Process.php
View File

@ -1718,15 +1718,11 @@ class Process implements \IteratorAggregate
private function getDefaultEnv()
{
if (\PHP_VERSION_ID >= 70100) {
$env = getenv();
} else {
$env = array();
$env = array();
foreach ($_SERVER as $k => $v) {
if (is_string($v) && false !== $v = getenv($k)) {
$env[$k] = $v;
}
foreach ($_SERVER as $k => $v) {
if (is_string($v) && false !== $v = getenv($k)) {
$env[$k] = $v;
}
}