diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Process] Make tests more deterministic

Browse Source
This commit is contained in:
Nicolas Grekas 2015-12-18 21:16:23 +01:00
parent 5dc2bb30ca
commit 0dc9389982
2 changed files with 38 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Symfony/Component/Process/Process.php
View File

@ -1225,14 +1225,7 @@ class Process
return $result = false; return $result = false;
} }
$proc = @proc_open('echo 1', array(array('pty'), array('pty'), array('pty')), $pipes); return $result = (bool) @proc_open('echo 1', array(array('pty'), array('pty'), array('pty')), $pipes);
if (is_resource($proc)) {
proc_close($proc);
return $result = true;
}
return $result = false;
} }
/** /**

68
src/Symfony/Component/Process/Tests/ProcessTest.php
View File

@ -828,30 +828,29 @@ class ProcessTest extends \PHPUnit_Framework_TestCase
$process->checkTimeout(); $process->checkTimeout();
usleep(100000); usleep(100000);
} }
$this->fail('A RuntimeException should have been raised'); $this->fail('A ProcessTimedOutException should have been raised');
} catch (RuntimeException $e) { } catch (ProcessTimedOutException $e) {
} }
$duration = microtime(true) - $start;
$this->assertLessThan(3, $duration); $this->assertLessThan(15, microtime(true) - $start);
throw $e; throw $e;
} }
public function testIdleTimeout() public function testIdleTimeout()
{ {
$process = $this->getProcess(self::$phpBin.' -r "sleep(3);"'); $process = $this->getProcess(self::$phpBin.' -r "sleep(34);"');
$process->setTimeout(10); $process->setTimeout(60);
$process->setIdleTimeout(0.5); $process->setIdleTimeout(0.1);
try { try {
$process->run(); $process->run();
$this->fail('A timeout exception was expected.'); $this->fail('A timeout exception was expected.');
} catch (ProcessTimedOutException $ex) { } catch (ProcessTimedOutException $e) {
$this->assertTrue($ex->isIdleTimeout()); $this->assertTrue($e->isIdleTimeout());
$this->assertFalse($ex->isGeneralTimeout()); $this->assertFalse($e->isGeneralTimeout());
$this->assertEquals(0.5, $ex->getExceededTimeout()); $this->assertEquals(0.1, $e->getExceededTimeout());
} }
} }
@ -860,17 +859,23 @@ class ProcessTest extends \PHPUnit_Framework_TestCase
if ('\\' === DIRECTORY_SEPARATOR) { if ('\\' === DIRECTORY_SEPARATOR) {
$this->markTestIncomplete('This test fails with a timeout on Windows, can someone investigate please?'); $this->markTestIncomplete('This test fails with a timeout on Windows, can someone investigate please?');
} }
$process = $this->getProcess(sprintf('%s -r %s', self::$phpBin, escapeshellarg('$n = 30; while ($n--) {echo "foo\n"; usleep(100000); }'))); $process = $this->getProcess(sprintf('%s -r %s', self::$phpBin, escapeshellarg('while (true) {echo "foo\n"; usleep(10000);}')));
$process->setTimeout(2); $process->setTimeout(1);
$process->setIdleTimeout(1); $process->start();
while (false === strpos($process->getOutput(), 'foo')) {
usleep(1000);
}
$process->setIdleTimeout(0.1);
try { try {
$process->run(); $process->wait();
$this->fail('A timeout exception was expected.'); $this->fail('A timeout exception was expected.');
} catch (ProcessTimedOutException $ex) { } catch (ProcessTimedOutException $ex) {
$this->assertTrue($ex->isGeneralTimeout(), 'A general timeout is expected.'); $this->assertTrue($ex->isGeneralTimeout(), 'A general timeout is expected.');
$this->assertFalse($ex->isIdleTimeout(), 'No idle timeout is expected.'); $this->assertFalse($ex->isIdleTimeout(), 'No idle timeout is expected.');
$this->assertEquals(2, $ex->getExceededTimeout()); $this->assertEquals(1, $ex->getExceededTimeout());
} }
} }
@ -885,11 +890,12 @@ class ProcessTest extends \PHPUnit_Framework_TestCase
try { try {
$process->run(); $process->run();
$this->fail('A RuntimeException should have been raised.'); $this->fail('A ProcessTimedOutException should have been raised.');
} catch (RuntimeException $e) { } catch (ProcessTimedOutException $e) {
} }
$this->assertFalse($process->isRunning()); $this->assertFalse($process->isRunning());
$process->start(); $process->start();
$this->assertTrue($process->isRunning());
$process->stop(0); $process->stop(0);
throw $e; throw $e;
@ -1047,7 +1053,7 @@ class ProcessTest extends \PHPUnit_Framework_TestCase
public function testDisableOutputDisablesTheOutput() public function testDisableOutputDisablesTheOutput()
{ {
$p = $this->getProcess(self::$phpBin.' -r "usleep(500000);"'); $p = $this->getProcess('foo');
$this->assertFalse($p->isOutputDisabled()); $this->assertFalse($p->isOutputDisabled());
$p->disableOutput(); $p->disableOutput();
$this->assertTrue($p->isOutputDisabled()); $this->assertTrue($p->isOutputDisabled());
@ -1061,7 +1067,7 @@ class ProcessTest extends \PHPUnit_Framework_TestCase
*/ */
public function testDisableOutputWhileRunningThrowsException() public function testDisableOutputWhileRunningThrowsException()
{ {
$p = $this->getProcess(self::$phpBin.' -r "usleep(500000);"'); $p = $this->getProcess(self::$phpBin.' -r "sleep(39);"');
$p->start(); $p->start();
$p->disableOutput(); $p->disableOutput();
} }
@ -1072,7 +1078,7 @@ class ProcessTest extends \PHPUnit_Framework_TestCase
*/ */
public function testEnableOutputWhileRunningThrowsException() public function testEnableOutputWhileRunningThrowsException()
{ {
$p = $this->getProcess(self::$phpBin.' -r "usleep(500000);"'); $p = $this->getProcess(self::$phpBin.' -r "sleep(40);"');
$p->disableOutput(); $p->disableOutput();
$p->start(); $p->start();
$p->enableOutput(); $p->enableOutput();
@ -1080,12 +1086,12 @@ class ProcessTest extends \PHPUnit_Framework_TestCase
public function testEnableOrDisableOutputAfterRunDoesNotThrowException() public function testEnableOrDisableOutputAfterRunDoesNotThrowException()
{ {
$p = $this->getProcess(self::$phpBin.' -r "usleep(500000);"'); $p = $this->getProcess('echo foo');
$p->disableOutput(); $p->disableOutput();
$p->start(); $p->run();
$p->wait();
$p->enableOutput(); $p->enableOutput();
$p->disableOutput(); $p->disableOutput();
$this->assertTrue($p->isOutputDisabled());
} }
/** /**
@ -1094,7 +1100,7 @@ class ProcessTest extends \PHPUnit_Framework_TestCase
*/ */
public function testDisableOutputWhileIdleTimeoutIsSet() public function testDisableOutputWhileIdleTimeoutIsSet()
{ {
$process = $this->getProcess('sleep 3'); $process = $this->getProcess('foo');
$process->setIdleTimeout(1); $process->setIdleTimeout(1);
$process->disableOutput(); $process->disableOutput();
} }
@ -1105,16 +1111,16 @@ class ProcessTest extends \PHPUnit_Framework_TestCase
*/ */
public function testSetIdleTimeoutWhileOutputIsDisabled() public function testSetIdleTimeoutWhileOutputIsDisabled()
{ {
$process = $this->getProcess('sleep 3'); $process = $this->getProcess('foo');
$process->disableOutput(); $process->disableOutput();
$process->setIdleTimeout(1); $process->setIdleTimeout(1);
} }
public function testSetNullIdleTimeoutWhileOutputIsDisabled() public function testSetNullIdleTimeoutWhileOutputIsDisabled()
{ {
$process = $this->getProcess('sleep 3'); $process = $this->getProcess('foo');
$process->disableOutput(); $process->disableOutput();
$process->setIdleTimeout(null); $this->assertSame($process, $process->setIdleTimeout(null));
} }
/** /**
@ -1122,7 +1128,7 @@ class ProcessTest extends \PHPUnit_Framework_TestCase
*/ */
public function testStartWithACallbackAndDisabledOutput($startMethod, $exception, $exceptionMessage) public function testStartWithACallbackAndDisabledOutput($startMethod, $exception, $exceptionMessage)
{ {
$p = $this->getProcess(self::$phpBin.' -r "usleep(500000);"'); $p = $this->getProcess('foo');
$p->disableOutput(); $p->disableOutput();
$this->setExpectedException($exception, $exceptionMessage); $this->setExpectedException($exception, $exceptionMessage);
if ('mustRun' === $startMethod) { if ('mustRun' === $startMethod) {
@ -1147,7 +1153,7 @@ class ProcessTest extends \PHPUnit_Framework_TestCase
*/ */
public function testGetOutputWhileDisabled($fetchMethod) public function testGetOutputWhileDisabled($fetchMethod)
{ {
$p = $this->getProcess(self::$phpBin.' -r "usleep(500000);"'); $p = $this->getProcess(self::$phpBin.' -r "sleep(41);"');
$p->disableOutput(); $p->disableOutput();
$p->start(); $p->start();
$p->{$fetchMethod}(); $p->{$fetchMethod}();
@ -1162,7 +1168,7 @@ class ProcessTest extends \PHPUnit_Framework_TestCase
array('getIncrementalErrorOutput'), array('getIncrementalErrorOutput'),
); );
} }
public function testStopTerminatesProcessCleanly() public function testStopTerminatesProcessCleanly()
{ {
$process = $this->getProcess(self::$phpBin.' -r "echo 123; sleep(42);"'); $process = $this->getProcess(self::$phpBin.' -r "echo 123; sleep(42);"');