diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #23347 [Dotenv] clean up before running assertions (xabbuh)

Browse Source 
This PR was merged into the 3.3 branch.

Discussion
----------

[Dotenv] clean up before running assertions

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

If one of the assertions failed, the clean up part would never happen.

Commits
-------

baafc7b409 [Dotenv] clean up before running assertions
This commit is contained in:
Fabien Potencier 2017-07-03 07:23:50 +02:00
commit 10120cf331
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Symfony/Component/Dotenv/Tests/DotenvTest.php
View File

@ -148,6 +148,13 @@ class DotenvTest extends TestCase
public function testLoad()
{
unset($_ENV['FOO']);
unset($_ENV['BAR']);
unset($_SERVER['FOO']);
unset($_SERVER['BAR']);
putenv('FOO');
putenv('BAR');
@mkdir($tmpdir = sys_get_temp_dir().'/dotenv');
$path1 = tempnam($tmpdir, 'sf-');
@ -158,14 +165,17 @@ class DotenvTest extends TestCase
(new DotEnv())->load($path1, $path2);
$this->assertSame('BAR', getenv('FOO'));
$this->assertSame('BAZ', getenv('BAR'));
$foo = getenv('FOO');
$bar = getenv('BAR');
putenv('FOO');
putenv('BAR');
unlink($path1);
unlink($path2);
rmdir($tmpdir);
$this->assertSame('BAR', $foo);
$this->assertSame('BAZ', $bar);
}
/**