From 1205e75f7a86871b8c1e18cd2be7e589e6300798 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Wed, 3 Sep 2014 11:22:04 +0200 Subject: [PATCH] Revert "minor #11808 [Security] Add more tests for StringUtils::equals (dunglas)" This reverts commit 8fdfb6fc35e194db06583854933f9c826608f7a7, reversing changes made to e99dfdf87a8f0d2871a5415401409ed96cff6f3d. --- .../Core/Tests/Util/StringUtilsTest.php | 44 ++----------------- 1 file changed, 3 insertions(+), 41 deletions(-) diff --git a/src/Symfony/Component/Security/Core/Tests/Util/StringUtilsTest.php b/src/Symfony/Component/Security/Core/Tests/Util/StringUtilsTest.php index e0366a52c1..89da98de66 100644 --- a/src/Symfony/Component/Security/Core/Tests/Util/StringUtilsTest.php +++ b/src/Symfony/Component/Security/Core/Tests/Util/StringUtilsTest.php @@ -13,49 +13,11 @@ namespace Symfony\Component\Security\Core\Tests\Util; use Symfony\Component\Security\Core\Util\StringUtils; -/** - * Data from PHP.net's hash_equals tests - */ class StringUtilsTest extends \PHPUnit_Framework_TestCase { - public function dataProviderTrue() + public function testEquals() { - return array( - array('same', 'same'), - array('', ''), - array(123, 123), - array(null, ''), - array(null, null), - ); - } - - public function dataProviderFalse() - { - return array( - array('not1same', 'not2same'), - array('short', 'longer'), - array('longer', 'short'), - array('', 'notempty'), - array('notempty', ''), - array(123, 'NaN'), - array('NaN', 123), - array(null, 123), - ); - } - - /** - * @dataProvider dataProviderTrue - */ - public function testEqualsTrue($known, $user) - { - $this->assertTrue(StringUtils::equals($known, $user)); - } - - /** - * @dataProvider dataProviderFalse - */ - public function testEqualsFalse($known, $user) - { - $this->assertFalse(StringUtils::equals($known, $user)); + $this->assertTrue(StringUtils::equals('password', 'password')); + $this->assertFalse(StringUtils::equals('password', 'foo')); } }