diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #41627 [VarExporter] Fix test on PHP 8.1 (derrabus)

Browse Source 
This PR was merged into the 4.4 branch.

Discussion
----------

[VarExporter] Fix test on PHP 8.1

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Part of #41552
| License       | MIT
| Doc PR        | N/A

On PHP 8.1, when dumping the properties of an object (either through serialization, `var_dump` or an array cast), those properties might appear in a different order than on PHP 8.0 and earlier.

Because of that, the test I'm fixing here fails. Since the order of the properties is not really important, I'm sorting the dumped array by key in order to get a stable order.

Commits
-------

56359cb999 [VarExporter] Fix test on PHP 8.1
This commit is contained in:
Nicolas Grekas 2021-06-09 09:58:59 +02:00
commit 12f3e37a46
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Symfony/Component/VarExporter/Tests/InstantiatorTest.php
View File

@ -55,7 +55,10 @@ class InstantiatorTest extends TestCase
"\0".__NAMESPACE__."\Foo\0priv" => 234,
];
$this->assertSame($expected, (array) Instantiator::instantiate(Bar::class, ['priv' => 123], [Foo::class => ['priv' => 234]]));
$actual = (array) Instantiator::instantiate(Bar::class, ['priv' => 123], [Foo::class => ['priv' => 234]]);
ksort($actual);
$this->assertSame($expected, $actual);
$e = Instantiator::instantiate('Exception', ['foo' => 123, 'trace' => [234]]);