diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #29174 Add required key attribute (greg0ire) 

This PR was merged into the 2.8 branch.

Discussion
----------

Add required key attribute

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

I am getting warnings when running tests with recent phpunit versions (since 7.2.0) :

> `- Element 'element': The attribute 'key' is required but missing.`

This requirement is far from being new, what is recent is phpunit
validating its configuration file against the XSD schema.

See d4484be1a9

This is pedantic (not a bugfix), and might be a bit painful to merge upstream, so if you feel like I should target a more recent instead and let the old branches go on with their lives, please tell me.

Commits
-------

c0733c22cb Add required key attribute
This commit is contained in:
Nicolas Grekas 2018-11-11 20:41:05 +01:00
parent c88755899e c0733c22cb
commit 131a42b38a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
phpunit.xml.dist
View File

@ -56,8 +56,8 @@
<array>
<element key="time-sensitive">
<array>
<element><string>Symfony\Component\Console</string></element>
<element><string>Symfony\Component\HttpFoundation</string></element>
<element key="0"><string>Symfony\Component\Console</string></element>
<element key="1"><string>Symfony\Component\HttpFoundation</string></element>
</array>
</element>
</array>