diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #15729 [Kernel] Integer version constants (Tobion) 

This PR was merged into the 2.3 branch.

Discussion
----------

[Kernel] Integer version constants

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

The idea of these constants is that they can be compared without using version_compare. But we want them to be compared as integers not as strings (it worked before as well because of php type juggling). They are integers semantically.

Commits
-------

4b45bb9 Kernel version constants are integers to actually be comparable numerically
This commit is contained in:
Fabien Potencier 2015-09-09 07:40:58 +02:00
parent 6430c828f6 4b45bb91ab
commit 146dca11a0
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Symfony/Component/HttpKernel/Kernel.php
View File

@ -61,10 +61,10 @@ abstract class Kernel implements KernelInterface, TerminableInterface
protected $loadClassCache;
const VERSION = '2.3.33-DEV';
const VERSION_ID = '20333';
const MAJOR_VERSION = '2';
const MINOR_VERSION = '3';
const RELEASE_VERSION = '33';
const VERSION_ID = 20333;
const MAJOR_VERSION = 2;
const MINOR_VERSION = 3;
const RELEASE_VERSION = 33;
const EXTRA_VERSION = 'DEV';
/**