bug #15729 [Kernel] Integer version constants (Tobion)
This PR was merged into the 2.3 branch.
Discussion
----------
[Kernel] Integer version constants
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
The idea of these constants is that they can be compared without using version_compare. But we want them to be compared as integers not as strings (it worked before as well because of php type juggling). They are integers semantically.
Commits
-------
4b45bb9
Kernel version constants are integers to actually be comparable numerically
This commit is contained in:
commit
146dca11a0
@ -61,10 +61,10 @@ abstract class Kernel implements KernelInterface, TerminableInterface
|
|||||||
protected $loadClassCache;
|
protected $loadClassCache;
|
||||||
|
|
||||||
const VERSION = '2.3.33-DEV';
|
const VERSION = '2.3.33-DEV';
|
||||||
const VERSION_ID = '20333';
|
const VERSION_ID = 20333;
|
||||||
const MAJOR_VERSION = '2';
|
const MAJOR_VERSION = 2;
|
||||||
const MINOR_VERSION = '3';
|
const MINOR_VERSION = 3;
|
||||||
const RELEASE_VERSION = '33';
|
const RELEASE_VERSION = 33;
|
||||||
const EXTRA_VERSION = 'DEV';
|
const EXTRA_VERSION = 'DEV';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
Reference in New Issue
Block a user