From 70fe66005a6c04ec8e31758863b62fc63706ea32 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Deruss=C3=A9?= <jeremy@derusse.com>
Date: Thu, 7 Jan 2021 23:51:21 +0100
Subject: [PATCH] Fix transient test with HttpClient jitter

---
 .../Tests/Retry/GenericRetryStrategyTest.php  | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/src/Symfony/Component/HttpClient/Tests/Retry/GenericRetryStrategyTest.php b/src/Symfony/Component/HttpClient/Tests/Retry/GenericRetryStrategyTest.php
index e04cdb45b6..98b6578f0b 100644
--- a/src/Symfony/Component/HttpClient/Tests/Retry/GenericRetryStrategyTest.php
+++ b/src/Symfony/Component/HttpClient/Tests/Retry/GenericRetryStrategyTest.php
@@ -93,19 +93,16 @@ class GenericRetryStrategyTest extends TestCase
     public function testJitter()
     {
         $strategy = new GenericRetryStrategy([], 1000, 1, 0, 1);
-        $belowHalf = 0;
-        $aboveHalf = 0;
-        for ($i = 0; $i < 20; ++$i) {
+        $min = 2000;
+        $max = 0;
+        for ($i = 0; $i < 50; ++$i) {
             $delay = $strategy->getDelay($this->getContext(0, 'GET', 'http://example.com/', 200), null, null);
-            if ($delay < 500) {
-                ++$belowHalf;
-            } elseif ($delay > 1500) {
-                ++$aboveHalf;
-            }
+            $min = min($min, $delay);
+            $max = max($max, $delay);
         }
-
-        $this->assertGreaterThanOrEqual(1, $belowHalf);
-        $this->assertGreaterThanOrEqual(1, $aboveHalf);
+        $this->assertGreaterThanOrEqual(1000, $max - $min);
+        $this->assertGreaterThanOrEqual(1000, $max);
+        $this->assertLessThanOrEqual(1000, $min);
     }
 
     private function getContext($retryCount, $method, $url, $statusCode): AsyncContext