[HttpRequest] fixes Request::getLanguages() bug
This commit is contained in:
parent
cdd89fb3be
commit
17dc2ff895
@ -1309,6 +1309,11 @@ class Request
|
||||
for ($i = 0, $max = count($codes); $i < $max; $i++) {
|
||||
if ($i == 0) {
|
||||
$lang = strtolower($codes[0]);
|
||||
// First segment of compound language codes
|
||||
// is added to supported languages list
|
||||
if (!in_array($lang, $this->languages)) {
|
||||
$this->languages[] = $lang;
|
||||
}
|
||||
} else {
|
||||
$lang .= '_'.strtoupper($codes[$i]);
|
||||
}
|
||||
@ -1316,7 +1321,9 @@ class Request
|
||||
}
|
||||
}
|
||||
|
||||
$this->languages[] = $lang;
|
||||
if (!in_array($lang, $this->languages)) {
|
||||
$this->languages[] = $lang;
|
||||
}
|
||||
}
|
||||
|
||||
return $this->languages;
|
||||
|
@ -951,8 +951,8 @@ class RequestTest extends \PHPUnit_Framework_TestCase
|
||||
|
||||
$request = new Request();
|
||||
$request->headers->set('Accept-language', 'zh, en-us; q=0.8, en; q=0.6');
|
||||
$this->assertEquals(array('zh', 'en_US', 'en'), $request->getLanguages());
|
||||
$this->assertEquals(array('zh', 'en_US', 'en'), $request->getLanguages());
|
||||
$this->assertEquals(array('zh', 'en', 'en_US'), $request->getLanguages());
|
||||
$this->assertEquals(array('zh', 'en', 'en_US'), $request->getLanguages());
|
||||
|
||||
$request = new Request();
|
||||
$request->headers->set('Accept-language', 'zh, en-us; q=0.6, en; q=0.8');
|
||||
@ -969,6 +969,10 @@ class RequestTest extends \PHPUnit_Framework_TestCase
|
||||
$request = new Request();
|
||||
$request->headers->set('Accept-language', 'zh, i-cherokee; q=0.6');
|
||||
$this->assertEquals(array('zh', 'cherokee'), $request->getLanguages());
|
||||
|
||||
$request = new Request();
|
||||
$request->headers->set('Accept-language', 'en-us');
|
||||
$this->assertEquals(array('en', 'en_US'), $request->getLanguages());
|
||||
}
|
||||
|
||||
public function testGetRequestFormat()
|
||||
|
Reference in New Issue
Block a user