[WebProfilerBundle] deprecated import/export commands

This commit is contained in:
Fabien Potencier 2015-09-07 15:20:27 +02:00
parent 0edcc2ef10
commit 17e00b9b8e
5 changed files with 39 additions and 4 deletions

View File

@ -325,8 +325,11 @@ DependencyInjection
</services>
```
Web Development Toolbar
-----------------------
WebProfiler
-----------
The `profiler:import` and `profiler:export` commands have been deprecated and
will be removed in 3.0.
The web development toolbar has been completely redesigned. This update has
introduced some changes in the HTML markup of the toolbar items.

View File

@ -1,6 +1,11 @@
CHANGELOG
=========
2.8.0
-----
* deprecated profiler:import and profiler:export commands
2.7.0
-----

View File

@ -20,6 +20,8 @@ use Symfony\Component\HttpKernel\Profiler\Profiler;
/**
* Exports a profile.
*
* @deprecated since version 2.8, to be removed in 3.0.
*
* @author Fabien Potencier <fabien@symfony.com>
*/
class ExportCommand extends Command
@ -49,7 +51,7 @@ class ExportCommand extends Command
{
$this
->setName('profiler:export')
->setDescription('Exports a profile')
->setDescription('[DEPRECATED] Exports a profile')
->setDefinition(array(
new InputArgument('token', InputArgument::REQUIRED, 'The profile token'),
))
@ -64,6 +66,10 @@ EOF
protected function execute(InputInterface $input, OutputInterface $output)
{
$formatter = $this->getHelper('formatter');
$output->writeln($formatter->formatSection('warning', 'The profiler:export command is deprecated since version 2.8 and will be removed in 3.0', 'comment'));
$token = $input->getArgument('token');
if (!$profile = $this->profiler->loadProfile($token)) {

View File

@ -20,6 +20,8 @@ use Symfony\Component\HttpKernel\Profiler\Profiler;
/**
* Imports a profile.
*
* @deprecated since version 2.8, to be removed in 3.0.
*
* @author Fabien Potencier <fabien@symfony.com>
*/
class ImportCommand extends Command
@ -49,7 +51,7 @@ class ImportCommand extends Command
{
$this
->setName('profiler:import')
->setDescription('Imports a profile')
->setDescription('[DEPRECATED] Imports a profile')
->setDefinition(array(
new InputArgument('filename', InputArgument::OPTIONAL, 'The profile path'),
))
@ -68,6 +70,10 @@ EOF
protected function execute(InputInterface $input, OutputInterface $output)
{
$formatter = $this->getHelper('formatter');
$output->writeln($formatter->formatSection('warning', 'The profiler:import command is deprecated since version 2.8 and will be removed in 3.0', 'comment'));
$data = '';
if ($input->getArgument('filename')) {
$data = file_get_contents($input->getArgument('filename'));

View File

@ -12,6 +12,7 @@
namespace Symfony\Bundle\WebProfilerBundle\Tests\Command;
use Symfony\Bundle\WebProfilerBundle\Command\ExportCommand;
use Symfony\Component\Console\Helper\HelperSet;
use Symfony\Component\Console\Tester\CommandTester;
use Symfony\Component\HttpKernel\Profiler\Profile;
@ -28,7 +29,14 @@ class ExportCommandTest extends \PHPUnit_Framework_TestCase
->getMock()
;
$helperSet = new HelperSet();
$helper = $this->getMock('Symfony\Component\Console\Helper\FormatterHelper');
$helper->expects($this->any())->method('formatSection');
$helperSet->set($helper, 'formatter');
$command = new ExportCommand($profiler);
$command->setHelperSet($helperSet);
$commandTester = new CommandTester($command);
$commandTester->execute(array('token' => 'TOKEN'));
}
@ -44,7 +52,14 @@ class ExportCommandTest extends \PHPUnit_Framework_TestCase
$profile = new Profile('TOKEN');
$profiler->expects($this->once())->method('loadProfile')->with('TOKEN')->will($this->returnValue($profile));
$helperSet = new HelperSet();
$helper = $this->getMock('Symfony\Component\Console\Helper\FormatterHelper');
$helper->expects($this->any())->method('formatSection');
$helperSet->set($helper, 'formatter');
$command = new ExportCommand($profiler);
$command->setHelperSet($helperSet);
$commandTester = new CommandTester($command);
$commandTester->execute(array('token' => 'TOKEN'));
$this->assertEquals($profiler->export($profile), $commandTester->getDisplay());