From 1825d0f2aefd9b36f84f7b86871e76429ac7a0f9 Mon Sep 17 00:00:00 2001 From: apetitpa Date: Fri, 24 Mar 2017 23:09:52 +0100 Subject: [PATCH] cast substr result to string and remove empty function use --- .../Component/Validator/Constraints/EmailValidator.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Symfony/Component/Validator/Constraints/EmailValidator.php b/src/Symfony/Component/Validator/Constraints/EmailValidator.php index 1a771debf9..cdd162d816 100644 --- a/src/Symfony/Component/Validator/Constraints/EmailValidator.php +++ b/src/Symfony/Component/Validator/Constraints/EmailValidator.php @@ -93,7 +93,7 @@ class EmailValidator extends ConstraintValidator return; } - $host = substr($value, strrpos($value, '@') + 1); + $host = (string) substr($value, strrpos($value, '@') + 1); // Check for host DNS resource records if ($constraint->checkMX) { @@ -138,7 +138,7 @@ class EmailValidator extends ConstraintValidator */ private function checkMX($host) { - return !empty($host) && checkdnsrr($host, 'MX'); + return '' !== $host && checkdnsrr($host, 'MX'); } /** @@ -150,6 +150,6 @@ class EmailValidator extends ConstraintValidator */ private function checkHost($host) { - return !empty($host) && ($this->checkMX($host) || (checkdnsrr($host, 'A') || checkdnsrr($host, 'AAAA'))); + return '' !== $host && ($this->checkMX($host) || (checkdnsrr($host, 'A') || checkdnsrr($host, 'AAAA'))); } }