diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Debug] Undefined variables raise a warning in php 8.

Browse Source
This commit is contained in:
Alexander M. Turek 2020-05-22 12:18:15 +02:00
parent 52abcbeec9
commit 1d20b514f2
1 changed files with 22 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/Symfony/Component/Debug/Tests/ErrorHandlerTest.php
View File

@ -101,9 +101,14 @@ class ErrorHandlerTest extends TestCase
$this->fail('ErrorException expected'); $this->fail('ErrorException expected');
} catch (\ErrorException $exception) { } catch (\ErrorException $exception) {
// if an exception is thrown, the test passed // if an exception is thrown, the test passed
$this->assertEquals(E_NOTICE, $exception->getSeverity()); if (\PHP_VERSION_ID < 80000) {
$this->assertEquals(E_NOTICE, $exception->getSeverity());
$this->assertRegExp('/^Notice: Undefined variable: (foo|bar)/', $exception->getMessage());
} else {
$this->assertEquals(E_WARNING, $exception->getSeverity());
$this->assertRegExp('/^Warning: Undefined variable \$(foo|bar)/', $exception->getMessage());
}
$this->assertEquals(__FILE__, $exception->getFile()); $this->assertEquals(__FILE__, $exception->getFile());
$this->assertRegExp('/^Notice: Undefined variable: (foo|bar)/', $exception->getMessage());
$trace = $exception->getTrace(); $trace = $exception->getTrace();
@ -247,11 +252,17 @@ class ErrorHandlerTest extends TestCase
$line = null; $line = null;
$logArgCheck = function ($level, $message, $context) use (&$line) { $logArgCheck = function ($level, $message, $context) use (&$line) {
$this->assertEquals('Notice: Undefined variable: undefVar', $message);
$this->assertArrayHasKey('exception', $context); $this->assertArrayHasKey('exception', $context);
$exception = $context['exception']; $exception = $context['exception'];
if (\PHP_VERSION_ID < 80000) {
$this->assertEquals('Notice: Undefined variable: undefVar', $message);
$this->assertSame(E_NOTICE, $exception->getSeverity());
} else {
$this->assertEquals('Warning: Undefined variable $undefVar', $message);
$this->assertSame(E_WARNING, $exception->getSeverity());
}
$this->assertInstanceOf(SilencedErrorContext::class, $exception); $this->assertInstanceOf(SilencedErrorContext::class, $exception);
$this->assertSame(E_NOTICE, $exception->getSeverity());
$this->assertSame(__FILE__, $exception->getFile()); $this->assertSame(__FILE__, $exception->getFile());
$this->assertSame($line, $exception->getLine()); $this->assertSame($line, $exception->getLine());
$this->assertNotEmpty($exception->getTrace()); $this->assertNotEmpty($exception->getTrace());
@ -265,8 +276,13 @@ class ErrorHandlerTest extends TestCase
; ;
$handler = ErrorHandler::register(); $handler = ErrorHandler::register();
$handler->setDefaultLogger($logger, E_NOTICE); if (\PHP_VERSION_ID < 80000) {
$handler->screamAt(E_NOTICE); $handler->setDefaultLogger($logger, E_NOTICE);
$handler->screamAt(E_NOTICE);
} else {
$handler->setDefaultLogger($logger, E_WARNING);
$handler->screamAt(E_WARNING);
}
unset($undefVar); unset($undefVar);
$line = __LINE__ + 1; $line = __LINE__ + 1;
@$undefVar++; @$undefVar++;