diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #40766 [Notifier] [Bridge] Remove hidden dependency on HttpFoundation (Nyholm)

Browse Source 
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] [Bridge] Remove hidden dependency on HttpFoundation

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

We dont need HttpFoundation to give us this constant. HttpFoundation is also missing from composer.json

Commits
-------

d37f158a88 [Notifier][Bridge] Remove hidden dependency on HttpFoundation
This commit is contained in:
Nicolas Grekas 2021-04-11 14:44:57 +02:00
commit 1e4241175f
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Symfony/Component/Notifier/Bridge/Gitter/GitterTransport.php
View File

@ -11,7 +11,6 @@
namespace Symfony\Component\Notifier\Bridge\Gitter;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Notifier\Exception\TransportException;
use Symfony\Component\Notifier\Exception\UnsupportedMessageTypeException;
use Symfony\Component\Notifier\Message\ChatMessage;
@ -69,7 +68,7 @@ final class GitterTransport extends AbstractTransport
$result = $response->toArray(false);
if (Response::HTTP_OK !== $response->getStatusCode()) {
if (200 !== $response->getStatusCode()) {
throw new TransportException(sprintf('Unable to post the Gitter message: "%s".', $result['error']), $response);
}

3
src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php
View File

@ -11,7 +11,6 @@
namespace Symfony\Component\Notifier\Bridge\LightSms;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Notifier\Exception\TransportException;
use Symfony\Component\Notifier\Exception\UnsupportedMessageTypeException;
use Symfony\Component\Notifier\Message\MessageInterface;
@ -118,7 +117,7 @@ final class LightSmsTransport extends AbstractTransport
]
);
if (Response::HTTP_OK !== $response->getStatusCode()) {
if (200 !== $response->getStatusCode()) {
throw new TransportException('Unable to send the SMS.', $response);
}