diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #33299 [EventDispatcher] Fix mocks for ImmutableEventDispatcher (derrabus) 

This PR was merged into the 3.4 branch.

Discussion
----------

[EventDispatcher] Fix mocks for ImmutableEventDispatcher

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33228
| License       | MIT
| Doc PR        | N/A

Backport from #33248. This PR fixes mocks that return values that are incompatible with the annotated return type.

Commits
-------

874aaea75f Fix mocks for ImmutableEventDispatcher.
This commit is contained in:
Nicolas Grekas 2019-08-23 12:00:53 +02:00
parent 1d7114957b 874aaea75f
commit 1f7250139f
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/Symfony/Component/EventDispatcher/Tests/ImmutableEventDispatcherTest.php
View File

@ -40,13 +40,14 @@ class ImmutableEventDispatcherTest extends TestCase
public function testDispatchDelegates()
{
$event = new Event();
$resultEvent = new Event();
$this->innerDispatcher->expects($this->once())
->method('dispatch')
->with('event', $event)
->willReturn('result');
->willReturn($resultEvent);
$this->assertSame('result', $this->dispatcher->dispatch('event', $event));
$this->assertSame($resultEvent, $this->dispatcher->dispatch('event', $event));
}
public function testGetListenersDelegates()
@ -54,9 +55,9 @@ class ImmutableEventDispatcherTest extends TestCase
$this->innerDispatcher->expects($this->once())
->method('getListeners')
->with('event')
->willReturn('result');
->willReturn(['result']);
$this->assertSame('result', $this->dispatcher->getListeners('event'));
$this->assertSame(['result'], $this->dispatcher->getListeners('event'));
}
public function testHasListenersDelegates()
@ -64,9 +65,9 @@ class ImmutableEventDispatcherTest extends TestCase
$this->innerDispatcher->expects($this->once())
->method('hasListeners')
->with('event')
->willReturn('result');
->willReturn(true);
$this->assertSame('result', $this->dispatcher->hasListeners('event'));
$this->assertTrue($this->dispatcher->hasListeners('event'));
}
public function testAddListenerDisallowed()