diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #29726 [Lock] Fix lock test random failure (jderusse)

Browse Source 
This PR was merged into the 3.4 branch.

Discussion
----------

[Lock] Fix lock test random failure

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | NA

The expiration of some store (PDO and Memcached) have a precision of 1 second.

The current test suite of the component tries to putof the expiration to time + 1 second then tries to check the value of the lock. This could generate test failure (see https://travis-ci.org/symfony/symfony/jobs/473530213#L3389)

Commits
-------

8cff565947 Fix random test failure on lock
This commit is contained in:
Fabien Potencier 2019-01-01 18:30:58 +01:00
commit 1fafdaf9e6
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Symfony/Component/Lock/Tests/Store/ExpiringStoreTestTrait.php
View File

@ -47,10 +47,10 @@ trait ExpiringStoreTestTrait
$store = $this->getStore();
$store->save($key);
$store->putOffExpiration($key, $clockDelay / 1000000);
$store->putOffExpiration($key, 2 * $clockDelay / 1000000);
$this->assertTrue($store->exists($key));
usleep(2 * $clockDelay);
usleep(3 * $clockDelay);
$this->assertFalse($store->exists($key));
}
@ -86,10 +86,10 @@ trait ExpiringStoreTestTrait
$store = $this->getStore();
$store->save($key);
$store->putOffExpiration($key, $clockDelay / 1000000);
$store->putOffExpiration($key, 2 * $clockDelay / 1000000);
$this->assertTrue($store->exists($key));
usleep(2 * $clockDelay);
usleep(3 * $clockDelay);
$this->assertFalse($store->exists($key));
}