diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #17450 [FrameworkBundle] Fix upgrade guides concerning erroneous removal of assets helper (regularjack) 

This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] Fix upgrade guides concerning erroneous removal of assets helper

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As mentioned in #17041, the upgrade guides for 2.7 and 3.0 erroneously mention that the `templating.helper.assets` service is removed in 3.0.  #17041 cannot fix these issues since it targets 3.0.

This PR should only be merged after #17041 since it depends on it.

Commits
-------

5abac56 Fix upgrade guides concerning erroneous removal of assets helper
This commit is contained in:
Fabien Potencier 2016-01-19 22:29:05 +01:00
parent 90ce9bc35e 5abac565d3
commit 20f0d60226
2 changed files with 2 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
UPGRADE-2.7.md
View File

@ -596,11 +596,11 @@ TwigBundle
FrameworkBundle
---------------
* The `templating.helper.assets` was refactored and returns now an object of the type
* The `templating.helper.assets` service was refactored and now returns an object of type
`Symfony\Bundle\FrameworkBundle\Templating\Helper\AssetsHelper` instead of
`Symfony\Component\Templating\Helper\CoreAssetsHelper`. You can update your class definition
or use the `assets.packages` service instead. Using the `assets.packages` service is the recommended
way. The `templating.helper.assets` service will be removed in Symfony 3.0.
way.
Before:

45
UPGRADE-3.0.md
View File

@ -388,51 +388,6 @@ UPGRADE FROM 2.x to 3.0
* The `request` service was removed. You must inject the `request_stack`
service instead.
* The `templating.helper.assets` was removed in Symfony 3.0. You should
use the `assets.package` service instead.
Before:
```php
use Symfony\Component\Templating\Helper\CoreAssetsHelper;
class DemoService
{
private $assetsHelper;
public function __construct(CoreAssetsHelper $assetsHelper)
{
$this->assetsHelper = $assetsHelper;
}
public function testMethod()
{
return $this->assetsHelper->getUrl('thumbnail.png', null, $this->assetsHelper->getVersion());
}
}
```
After:
```php
use Symfony\Component\Asset\Packages;
class DemoService
{
private $assetPackages;
public function __construct(Packages $assetPackages)
{
$this->assetPackages = $assetPackages;
}
public function testMethod()
{
return $this->assetPackages->getUrl('thumbnail.png').$this->assetPackages->getVersion();
}
}
```
* The `enctype` method of the `form` helper was removed. You should use the
new method `start` instead.