diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Form] Added support for __get and __set in PropertyPath

Browse Source
This commit is contained in:
GordonsLondon 2010-11-09 12:18:19 +01:00 committed by Fabien Potencier
parent 5aeb358721
commit 23ac47e011
3 changed files with 42 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/Form/PropertyPath.php
View File

@ -324,7 +324,7 @@ class PropertyPath implements \IteratorAggregate
}
return $object->$property;
} else if (property_exists($object, $property)) {
} else if (property_exists($object, $property) || $reflClass->hasMethod('__get')) {
// needed to support \stdClass instances
return $object->$property;
} else {
@ -367,7 +367,7 @@ class PropertyPath implements \IteratorAggregate
}
$objectOrArray->$property = $value;
} else if (property_exists($objectOrArray, $property)) {
} else if (property_exists($objectOrArray, $property) || $reflClass->hasMethod('__get')) {
// needed to support \stdClass instances
$objectOrArray->$property = $value;
} else {

18
tests/Symfony/Tests/Component/Form/Fixtures/Magician.php Normal file
View File

@ -0,0 +1,18 @@
<?php
namespace Symfony\Tests\Component\Form\Fixtures;
class Magician
{
private $properties = array();
public function __set($name, $value)
{
$this->properties[$name] = $value;
}
public function __get($name)
{
return isset($this->properties[$name]) ? $this->properties[$name] : null;
}
}

22
tests/Symfony/Tests/Component/Form/PropertyPathTest.php
View File

@ -3,9 +3,11 @@
namespace Symfony\Tests\Component\Form;
require_once __DIR__ . '/Fixtures/Author.php';
require_once __DIR__ . '/Fixtures/Magician.php';
use Symfony\Component\Form\PropertyPath;
use Symfony\Tests\Component\Form\Fixtures\Author;
use Symfony\Tests\Component\Form\Fixtures\Magician;
class PropertyPathTest extends \PHPUnit_Framework_TestCase
{
@ -135,6 +137,16 @@ class PropertyPathTest extends \PHPUnit_Framework_TestCase
$this->assertSame(false, $path->getValue($object));
}
public function testGetValueReadsMagicGet()
{
$path = new PropertyPath('magicProperty');
$object = new Magician();
$object->__set('magicProperty', 'foobar');
$this->assertSame('foobar', $path->getValue($object));
}
public function testGetValueThrowsExceptionIfIsserIsNotPublic()
{
$path = new PropertyPath('privateIsser');
@ -205,6 +217,16 @@ class PropertyPathTest extends \PHPUnit_Framework_TestCase
$this->assertEquals('Bernhard', $object['firstName']);
}
public function testSetValueUpdateMagicSet()
{
$object = new Magician();
$path = new PropertyPath('magicProperty');
$path->setValue($object, 'foobar');
$this->assertEquals('foobar', $object->__get('magicProperty'));
}
public function testSetValueThrowsExceptionIfArrayAccessExpected()
{
$path = new PropertyPath('[firstName]');