bug #33601 [HttpClient] Add default value for Accept header (numerogeek)
This PR was merged into the 4.3 branch.
Discussion
----------
[HttpClient] Add default value for Accept header
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix #33596 <!-- prefix each issue number with "Fix #", if any -->
| License | MIT
This PR will add an "Accept: *" header when nothing is provided to stick with the behavior of a native curl query or postman query.
Commits
-------
48eebfc77b
Add default value for Accept header
This commit is contained in:
commit
23f64d5075
@ -56,6 +56,10 @@ trait HttpClientTrait
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (!isset($options['normalized_headers']['accept'])) {
|
||||||
|
$options['normalized_headers']['accept'] = [$options['headers'][] = 'Accept: *'];
|
||||||
|
}
|
||||||
|
|
||||||
if (isset($options['body'])) {
|
if (isset($options['body'])) {
|
||||||
$options['body'] = self::normalizeBody($options['body']);
|
$options['body'] = self::normalizeBody($options['body']);
|
||||||
}
|
}
|
||||||
|
@ -172,7 +172,7 @@ class HttpClientTraitTest extends TestCase
|
|||||||
public function testAuthBearerOption()
|
public function testAuthBearerOption()
|
||||||
{
|
{
|
||||||
[, $options] = self::prepareRequest('POST', 'http://example.com', ['auth_bearer' => 'foobar'], HttpClientInterface::OPTIONS_DEFAULTS);
|
[, $options] = self::prepareRequest('POST', 'http://example.com', ['auth_bearer' => 'foobar'], HttpClientInterface::OPTIONS_DEFAULTS);
|
||||||
$this->assertSame(['Authorization: Bearer foobar'], $options['headers']);
|
$this->assertSame(['Accept: *', 'Authorization: Bearer foobar'], $options['headers']);
|
||||||
$this->assertSame(['Authorization: Bearer foobar'], $options['normalized_headers']['authorization']);
|
$this->assertSame(['Authorization: Bearer foobar'], $options['normalized_headers']['authorization']);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user