diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Form] Fixed regression in BooleanToStringTransformer from ed83752

This commit is contained in:
Bernhard Schussek 2013-09-12 09:25:54 +02:00
parent 610301d5e0
commit 2747bdca76
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/Form/Extension/Core/DataTransformer/BooleanToStringTransformer.php
View File

@ -49,6 +49,10 @@ class BooleanToStringTransformer implements DataTransformerInterface
*/ */
public function transform($value) public function transform($value)
{ {
if (null === $value) {
return null;
}
if (!is_bool($value)) { if (!is_bool($value)) {
throw new TransformationFailedException('Expected a Boolean.'); throw new TransformationFailedException('Expected a Boolean.');
} }

8
src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/BooleanToStringTransformerTest.php
View File

@ -38,12 +38,10 @@ class BooleanToStringTransformerTest extends \PHPUnit_Framework_TestCase
$this->assertNull($this->transformer->transform(false)); $this->assertNull($this->transformer->transform(false));
} }
/** // https://github.com/symfony/symfony/issues/8989
* @expectedException \Symfony\Component\Form\Exception\TransformationFailedException public function testTransformAcceptsNull()
*/
public function testTransformFailsIfNull()
{ {
$this->transformer->transform(null); $this->assertNull($this->transformer->transform(null));
} }
/** /**