From 27517e38bef5e652f378d55de50477dd37a9d450 Mon Sep 17 00:00:00 2001 From: WouterJ Date: Tue, 13 Oct 2015 22:03:48 +0200 Subject: [PATCH] Use entry_type instead of type --- .../Component/Form/Extension/Core/Type/CollectionType.php | 2 ++ src/Symfony/Component/Form/Tests/AbstractTableLayoutTest.php | 4 ++-- .../Form/Tests/Extension/Core/Type/CollectionTypeTest.php | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php b/src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php index 7de18e013a..a74ef226e1 100644 --- a/src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php +++ b/src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php @@ -92,6 +92,8 @@ class CollectionType extends AbstractType if (null !== $value) { @trigger_error('The form option "type" is deprecated since version 2.8 and will be removed in 3.0. Use "entry_type" instead.', E_USER_DEPRECATED); } + + return $value; }; $entryType = function (Options $options) { if (null !== $options['type']) { diff --git a/src/Symfony/Component/Form/Tests/AbstractTableLayoutTest.php b/src/Symfony/Component/Form/Tests/AbstractTableLayoutTest.php index 7cb44ade6b..9902a6dc08 100644 --- a/src/Symfony/Component/Form/Tests/AbstractTableLayoutTest.php +++ b/src/Symfony/Component/Form/Tests/AbstractTableLayoutTest.php @@ -195,7 +195,7 @@ abstract class AbstractTableLayoutTest extends AbstractLayoutTest public function testCollection() { $form = $this->factory->createNamed('names', 'Symfony\Component\Form\Extension\Core\Type\CollectionType', array('a', 'b'), array( - 'type' => 'Symfony\Component\Form\Extension\Core\Type\TextType', + 'entry_type' => 'Symfony\Component\Form\Extension\Core\Type\TextType', )); $this->assertWidgetMatchesXpath($form->createView(), array(), @@ -213,7 +213,7 @@ abstract class AbstractTableLayoutTest extends AbstractLayoutTest public function testEmptyCollection() { $form = $this->factory->createNamed('names', 'Symfony\Component\Form\Extension\Core\Type\CollectionType', array(), array( - 'type' => 'Symfony\Component\Form\Extension\Core\Type\TextType', + 'entry_type' => 'Symfony\Component\Form\Extension\Core\Type\TextType', )); $this->assertWidgetMatchesXpath($form->createView(), array(), diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/CollectionTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/CollectionTypeTest.php index cc00945f91..82faa71510 100644 --- a/src/Symfony/Component/Form/Tests/Extension/Core/Type/CollectionTypeTest.php +++ b/src/Symfony/Component/Form/Tests/Extension/Core/Type/CollectionTypeTest.php @@ -31,7 +31,7 @@ class CollectionTypeTest extends \Symfony\Component\Form\Test\TypeTestCase public function testContainsNoChildByDefault() { $form = $this->factory->create('Symfony\Component\Form\Extension\Core\Type\CollectionType', null, array( - 'type' => 'Symfony\Component\Form\Extension\Core\Type\TextType', + 'entry_type' => 'Symfony\Component\Form\Extension\Core\Type\TextType', )); $this->assertCount(0, $form); @@ -305,10 +305,10 @@ class CollectionTypeTest extends \Symfony\Component\Form\Test\TypeTestCase public function testPrototypeData() { $form = $this->factory->create('Symfony\Component\Form\Extension\Core\Type\CollectionType', array(), array( - 'type' => 'Symfony\Component\Form\Extension\Core\Type\TextType', 'allow_add' => true, 'prototype' => true, 'prototype_data' => 'foo', + 'entry_type' => 'Symfony\Component\Form\Extension\Core\Type\TextType', 'entry_options' => array( 'data' => 'bar', ),