diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #31982 [HttpClient] fix Psr18Client handling of non-200 response codes (nicolas-grekas)

Browse Source 
This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] fix Psr18Client handling of non-200 response codes

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31979
| License       | MIT
| Doc PR        | -

Commits
-------

4a7989456b [HttpClient] fix Psr18Client handling of non-200 response codes
This commit is contained in:
Fabien Potencier 2019-06-11 12:37:06 +02:00
commit 2f4f8c05d7
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/HttpClient/Psr18Client.php
View File

@ -73,13 +73,13 @@ final class Psr18Client implements ClientInterface
$psrResponse = $this->responseFactory->createResponse($response->getStatusCode());
foreach ($response->getHeaders() as $name => $values) {
foreach ($response->getHeaders(false) as $name => $values) {
foreach ($values as $value) {
$psrResponse = $psrResponse->withAddedHeader($name, $value);
}
}
return $psrResponse->withBody($this->streamFactory->createStream($response->getContent()));
return $psrResponse->withBody($this->streamFactory->createStream($response->getContent(false)));
} catch (TransportExceptionInterface $e) {
if ($e instanceof \InvalidArgumentException) {
throw new Psr18RequestException($e, $request);

9
src/Symfony/Component/HttpClient/Tests/Psr18ClientTest.php
View File

@ -74,4 +74,13 @@ class Psr18ClientTest extends TestCase
$this->expectException(Psr18RequestException::class);
$client->sendRequest($factory->createRequest('BAD.METHOD', 'http://localhost:8057'));
}
public function test404()
{
$factory = new Psr17Factory();
$client = new Psr18Client(new NativeHttpClient());
$response = $client->sendRequest($factory->createRequest('GET', 'http://localhost:8057/404'));
$this->assertSame(404, $response->getStatusCode());
}
}