diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use an empty string as default for assertEquals 

Make sure it isn’t interpreted as a type NULL, making the test fail with
PHPUnit 7.2.
This commit is contained in:
David Prévot 2018-07-08 17:43:47 -10:00
parent 18edda3716
commit 31353147a3
5 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/ClassLoader/Tests/ClassMapGeneratorTest.php
View File

@ -138,7 +138,7 @@ class ClassMapGeneratorTest extends TestCase
), ClassMapGenerator::createMap($finder));
}
protected function assertEqualsNormalized($expected, $actual, $message = null)
protected function assertEqualsNormalized($expected, $actual, $message = '')
{
foreach ($expected as $ns => $path) {
$expected[$ns] = str_replace('\\', '/', $path);

2
src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php
View File

@ -1027,7 +1027,7 @@ HTML;
/**
* @dataProvider getBaseTagData
*/
public function testBaseTag($baseValue, $linkValue, $expectedUri, $currentUri = null, $description = null)
public function testBaseTag($baseValue, $linkValue, $expectedUri, $currentUri = null, $description = '')
{
$crawler = new Crawler('<html><base href="'.$baseValue.'"><a href="'.$linkValue.'"></a></html>', $currentUri);
$this->assertEquals($expectedUri, $crawler->filterXPath('//a')->link()->getUri(), $description);

12
src/Symfony/Component/Stopwatch/Tests/StopwatchEventTest.php
View File

@ -73,7 +73,7 @@ class StopwatchEventTest extends TestCase
$event->start();
usleep(200000);
$event->stop();
$this->assertEquals(200, $event->getDuration(), null, self::DELTA);
$this->assertEquals(200, $event->getDuration(), '', self::DELTA);
$event = new StopwatchEvent(microtime(true) * 1000);
$event->start();
@ -83,7 +83,7 @@ class StopwatchEventTest extends TestCase
$event->start();
usleep(100000);
$event->stop();
$this->assertEquals(200, $event->getDuration(), null, self::DELTA);
$this->assertEquals(200, $event->getDuration(), '', self::DELTA);
}
public function testDurationBeforeStop()
@ -91,7 +91,7 @@ class StopwatchEventTest extends TestCase
$event = new StopwatchEvent(microtime(true) * 1000);
$event->start();
usleep(200000);
$this->assertEquals(200, $event->getDuration(), null, self::DELTA);
$this->assertEquals(200, $event->getDuration(), '', self::DELTA);
$event = new StopwatchEvent(microtime(true) * 1000);
$event->start();
@ -100,7 +100,7 @@ class StopwatchEventTest extends TestCase
usleep(50000);
$event->start();
usleep(100000);
$this->assertEquals(100, $event->getDuration(), null, self::DELTA);
$this->assertEquals(100, $event->getDuration(), '', self::DELTA);
}
/**
@ -134,7 +134,7 @@ class StopwatchEventTest extends TestCase
$event->start();
usleep(100000);
$event->ensureStopped();
$this->assertEquals(300, $event->getDuration(), null, self::DELTA);
$this->assertEquals(300, $event->getDuration(), '', self::DELTA);
}
public function testStartTime()
@ -151,7 +151,7 @@ class StopwatchEventTest extends TestCase
$event->start();
usleep(100000);
$event->stop();
$this->assertEquals(0, $event->getStartTime(), null, self::DELTA);
$this->assertEquals(0, $event->getStartTime(), '', self::DELTA);
}
/**

2
src/Symfony/Component/Stopwatch/Tests/StopwatchTest.php
View File

@ -79,7 +79,7 @@ class StopwatchTest extends TestCase
$event = $stopwatch->stop('foo');
$this->assertInstanceOf('Symfony\Component\Stopwatch\StopwatchEvent', $event);
$this->assertEquals(200, $event->getDuration(), null, self::DELTA);
$this->assertEquals(200, $event->getDuration(), '', self::DELTA);
}
/**

2
src/Symfony/Component/Yaml/Tests/Fixtures/escapedCharacters.yml
View File

@ -4,7 +4,7 @@ yaml: |
php: |
"\\0 \\ \\a \\b \\n"
---
test: null
test: 'null'
yaml: |
"\0"
php: |