Merge branch '3.3' into 3.4
* 3.3: [WebProfilerBundle] add missing tests Fix dump panel hidden when closing a dump FormInterface::getPropertyPath(): PropertyPathInterface|null [FrameworkBundle][Routing] Remove unused logger argument
This commit is contained in:
commit
31e64bf7c5
@ -59,7 +59,6 @@
|
|||||||
</service>
|
</service>
|
||||||
|
|
||||||
<service id="router.default" class="Symfony\Bundle\FrameworkBundle\Routing\Router">
|
<service id="router.default" class="Symfony\Bundle\FrameworkBundle\Routing\Router">
|
||||||
<tag name="monolog.logger" channel="router" />
|
|
||||||
<argument type="service" id="service_container" />
|
<argument type="service" id="service_container" />
|
||||||
<argument>%router.resource%</argument>
|
<argument>%router.resource%</argument>
|
||||||
<argument type="collection">
|
<argument type="collection">
|
||||||
@ -75,7 +74,6 @@
|
|||||||
<argument key="matcher_cache_class">%router.options.matcher.cache_class%</argument>
|
<argument key="matcher_cache_class">%router.options.matcher.cache_class%</argument>
|
||||||
</argument>
|
</argument>
|
||||||
<argument type="service" id="router.request_context" on-invalid="ignore" />
|
<argument type="service" id="router.request_context" on-invalid="ignore" />
|
||||||
<argument type="service" id="logger" on-invalid="ignore" />
|
|
||||||
<call method="setConfigCacheFactory">
|
<call method="setConfigCacheFactory">
|
||||||
<argument type="service" id="config_cache_factory" />
|
<argument type="service" id="config_cache_factory" />
|
||||||
</call>
|
</call>
|
||||||
|
@ -98,6 +98,16 @@
|
|||||||
|
|
||||||
Sfjs.toggleClass(this.parentNode, 'hover');
|
Sfjs.toggleClass(this.parentNode, 'hover');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
var dumpInfo = document.querySelector('.sf-toolbar-block-dump .sf-toolbar-info');
|
||||||
|
if (null !== dumpInfo) {
|
||||||
|
Sfjs.addEventListener(dumpInfo, 'sfbeforedumpcollapse', function () {
|
||||||
|
dumpInfo.style.minHeight = dumpInfo.getBoundingClientRect().height+'px';
|
||||||
|
});
|
||||||
|
Sfjs.addEventListener(dumpInfo, 'mouseleave', function () {
|
||||||
|
dumpInfo.style.minHeight = '';
|
||||||
|
});
|
||||||
|
}
|
||||||
},
|
},
|
||||||
function(xhr) {
|
function(xhr) {
|
||||||
if (xhr.status !== 0) {
|
if (xhr.status !== 0) {
|
||||||
|
@ -84,12 +84,29 @@ class WebDebugToolbarListenerTest extends TestCase
|
|||||||
$this->assertEquals("<html><head></head><body>\nWDT\n</body></html>", $response->getContent());
|
$this->assertEquals("<html><head></head><body>\nWDT\n</body></html>", $response->getContent());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @depends testToolbarIsInjected
|
||||||
|
*/
|
||||||
|
public function testToolbarIsNotInjectedOnNonHtmlContentType()
|
||||||
|
{
|
||||||
|
$response = new Response('<html><head></head><body></body></html>');
|
||||||
|
$response->headers->set('X-Debug-Token', 'xxxxxxxx');
|
||||||
|
$response->headers->set('Content-Type', 'text/xml');
|
||||||
|
$event = new FilterResponseEvent($this->getKernelMock(), $this->getRequestMock(), HttpKernelInterface::MASTER_REQUEST, $response);
|
||||||
|
|
||||||
|
$listener = new WebDebugToolbarListener($this->getTwigMock());
|
||||||
|
$listener->onKernelResponse($event);
|
||||||
|
|
||||||
|
$this->assertEquals('<html><head></head><body></body></html>', $response->getContent());
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @depends testToolbarIsInjected
|
* @depends testToolbarIsInjected
|
||||||
*/
|
*/
|
||||||
public function testToolbarIsNotInjectedOnContentDispositionAttachment()
|
public function testToolbarIsNotInjectedOnContentDispositionAttachment()
|
||||||
{
|
{
|
||||||
$response = new Response('<html><head></head><body></body></html>');
|
$response = new Response('<html><head></head><body></body></html>');
|
||||||
|
$response->headers->set('X-Debug-Token', 'xxxxxxxx');
|
||||||
$response->headers->set('Content-Disposition', 'attachment; filename=test.html');
|
$response->headers->set('Content-Disposition', 'attachment; filename=test.html');
|
||||||
$event = new FilterResponseEvent($this->getKernelMock(), $this->getRequestMock(false, 'html'), HttpKernelInterface::MASTER_REQUEST, $response);
|
$event = new FilterResponseEvent($this->getKernelMock(), $this->getRequestMock(false, 'html'), HttpKernelInterface::MASTER_REQUEST, $response);
|
||||||
|
|
||||||
|
@ -171,7 +171,7 @@ interface FormInterface extends \ArrayAccess, \Traversable, \Countable
|
|||||||
/**
|
/**
|
||||||
* Returns the property path that the form is mapped to.
|
* Returns the property path that the form is mapped to.
|
||||||
*
|
*
|
||||||
* @return \Symfony\Component\PropertyAccess\PropertyPathInterface The property path
|
* @return \Symfony\Component\PropertyAccess\PropertyPathInterface|null The property path
|
||||||
*/
|
*/
|
||||||
public function getPropertyPath();
|
public function getPropertyPath();
|
||||||
|
|
||||||
|
@ -16,8 +16,8 @@ Symfony\Component\Form\Extension\Core\Type\ChoiceType (choice_translation_domain
|
|||||||
Allowed values - %s
|
Allowed values - %s
|
||||||
---------------- --------------------%s
|
---------------- --------------------%s
|
||||||
Normalizer Closure { %s
|
Normalizer Closure { %s
|
||||||
parameters: 2, %s
|
parameters: 2 %s
|
||||||
file: "%s%eExtension%eCore%eType%eChoiceType.php",
|
file: "%s%eExtension%eCore%eType%eChoiceType.php"
|
||||||
line: "%s to %s" %s
|
line: "%s to %s" %s
|
||||||
} %s
|
} %s
|
||||||
---------------- --------------------%s
|
---------------- --------------------%s
|
||||||
|
@ -9,13 +9,13 @@ Symfony\Component\Form\Tests\Console\Descriptor\FooType (empty_data)
|
|||||||
%s
|
%s
|
||||||
Closure(s): [ %s
|
Closure(s): [ %s
|
||||||
Closure { %s
|
Closure { %s
|
||||||
parameters: 1, %s
|
parameters: 1 %s
|
||||||
file: "%s%eExtension%eCore%eType%eFormType.php",
|
file: "%s%eExtension%eCore%eType%eFormType.php"
|
||||||
line: "%s to %s" %s
|
line: "%s to %s" %s
|
||||||
}, %s
|
}, %s
|
||||||
Closure { %s
|
Closure { %s
|
||||||
parameters: 2, %s
|
parameters: 2 %s
|
||||||
file: "%s%eTests%eConsole%eDescriptor%eAbstractDescriptorTest.php",
|
file: "%s%eTests%eConsole%eDescriptor%eAbstractDescriptorTest.php"
|
||||||
line: "%s to %s" %s
|
line: "%s to %s" %s
|
||||||
} %s
|
} %s
|
||||||
] %s
|
] %s
|
||||||
|
@ -17,8 +17,8 @@ Symfony\Component\Form\Tests\Console\Descriptor\FooType (foo)
|
|||||||
] %s
|
] %s
|
||||||
---------------- --------------------%s
|
---------------- --------------------%s
|
||||||
Normalizer Closure { %s
|
Normalizer Closure { %s
|
||||||
parameters: 2, %s
|
parameters: 2 %s
|
||||||
file: "%s%eTests%eConsole%eDescriptor%eAbstractDescriptorTest.php",
|
file: "%s%eTests%eConsole%eDescriptor%eAbstractDescriptorTest.php"
|
||||||
line: "%s to %s" %s
|
line: "%s to %s" %s
|
||||||
} %s
|
} %s
|
||||||
---------------- --------------------%s
|
---------------- --------------------%s
|
||||||
|
@ -32,7 +32,7 @@
|
|||||||
"symfony/http-kernel": "^3.3.5|~4.0",
|
"symfony/http-kernel": "^3.3.5|~4.0",
|
||||||
"symfony/security-csrf": "~2.8|~3.0|~4.0",
|
"symfony/security-csrf": "~2.8|~3.0|~4.0",
|
||||||
"symfony/translation": "~2.8|~3.0|~4.0",
|
"symfony/translation": "~2.8|~3.0|~4.0",
|
||||||
"symfony/var-dumper": "~3.3|~4.0",
|
"symfony/var-dumper": "^3.3.11|~4.0",
|
||||||
"symfony/console": "~3.4|~4.0"
|
"symfony/console": "~3.4|~4.0"
|
||||||
},
|
},
|
||||||
"conflict": {
|
"conflict": {
|
||||||
|
@ -165,6 +165,13 @@ function toggle(a, recursive) {
|
|||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (doc.createEvent && s.dispatchEvent) {
|
||||||
|
var event = doc.createEvent('Event');
|
||||||
|
event.initEvent('sf-dump-expanded' === newClass ? 'sfbeforedumpexpand' : 'sfbeforedumpcollapse', true, false);
|
||||||
|
|
||||||
|
s.dispatchEvent(event);
|
||||||
|
}
|
||||||
|
|
||||||
a.lastChild.innerHTML = arrow;
|
a.lastChild.innerHTML = arrow;
|
||||||
s.className = s.className.replace(/\bsf-dump-(compact|expanded)\b/, newClass);
|
s.className = s.className.replace(/\bsf-dump-(compact|expanded)\b/, newClass);
|
||||||
|
|
||||||
|
@ -147,10 +147,10 @@ RuntimeException {
|
|||||||
#file: "%ACliDumperTest.php"
|
#file: "%ACliDumperTest.php"
|
||||||
#line: %d
|
#line: %d
|
||||||
trace: {
|
trace: {
|
||||||
%ACliDumperTest.php:%d: {
|
%ACliDumperTest.php:%d {
|
||||||
:
|
›
|
||||||
: $ex = new \RuntimeException('foo');
|
› $ex = new \RuntimeException('foo');
|
||||||
:
|
›
|
||||||
}
|
}
|
||||||
%A
|
%A
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user