From 3306c70a34936672b1e6346b677c2065ba73c65b Mon Sep 17 00:00:00 2001 From: Roland Franssen Date: Sun, 21 Aug 2016 12:01:27 +0000 Subject: [PATCH] [DI] Cleanup array_key_exists --- src/Symfony/Component/DependencyInjection/Container.php | 5 ++--- .../Component/DependencyInjection/ContainerBuilder.php | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/Symfony/Component/DependencyInjection/Container.php b/src/Symfony/Component/DependencyInjection/Container.php index 3ecf81635a..d59ad0d5ff 100644 --- a/src/Symfony/Component/DependencyInjection/Container.php +++ b/src/Symfony/Component/DependencyInjection/Container.php @@ -223,7 +223,6 @@ class Container implements IntrospectableContainerInterface if ('service_container' === $id || isset($this->aliases[$id]) || isset($this->services[$id]) - || array_key_exists($id, $this->services) ) { return true; } @@ -266,7 +265,7 @@ class Container implements IntrospectableContainerInterface $id = $this->aliases[$id]; } // Re-use shared service instance if it exists. - if (isset($this->services[$id]) || array_key_exists($id, $this->services)) { + if (isset($this->services[$id])) { return $this->services[$id]; } @@ -348,7 +347,7 @@ class Container implements IntrospectableContainerInterface $id = $this->aliases[$id]; } - return isset($this->services[$id]) || array_key_exists($id, $this->services); + return isset($this->services[$id]); } /** diff --git a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php index 0813110ded..70d1efda4c 100644 --- a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php +++ b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php @@ -436,7 +436,7 @@ class ContainerBuilder extends Container implements TaggedContainerInterface return $service; } - if (!array_key_exists($id, $this->definitions) && isset($this->aliasDefinitions[$id])) { + if (!isset($this->definitions[$id]) && isset($this->aliasDefinitions[$id])) { return $this->get($this->aliasDefinitions[$id]); } @@ -784,7 +784,7 @@ class ContainerBuilder extends Container implements TaggedContainerInterface */ public function hasDefinition($id) { - return array_key_exists(strtolower($id), $this->definitions); + return isset($this->definitions[strtolower($id)]); } /** @@ -800,7 +800,7 @@ class ContainerBuilder extends Container implements TaggedContainerInterface { $id = strtolower($id); - if (!array_key_exists($id, $this->definitions)) { + if (!isset($this->definitions[$id])) { throw new ServiceNotFoundException($id); }