From 3454d6084f9e536411011a345adae6718b661d4c Mon Sep 17 00:00:00 2001 From: Romain Neutron Date: Thu, 22 May 2014 22:31:58 +0200 Subject: [PATCH] [Process] Fix conflicts between latest 2.3 fix and 2.5 deprecation --- .../Process/Tests/AbstractProcessTest.php | 20 +++++++++---------- .../Tests/SigchildDisabledProcessTest.php | 4 ++-- .../Tests/SigchildEnabledProcessTest.php | 4 ++-- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/Symfony/Component/Process/Tests/AbstractProcessTest.php b/src/Symfony/Component/Process/Tests/AbstractProcessTest.php index e099faa268..4e0f4b5bb1 100644 --- a/src/Symfony/Component/Process/Tests/AbstractProcessTest.php +++ b/src/Symfony/Component/Process/Tests/AbstractProcessTest.php @@ -173,17 +173,17 @@ abstract class AbstractProcessTest extends \PHPUnit_Framework_TestCase } /** - * @dataProvider provideInvalidStdinValues + * @dataProvider provideInvalidInputValues * @expectedException \Symfony\Component\Process\Exception\InvalidArgumentException - * @expectedExceptionMessage Symfony\Component\Process\Process::setStdin only accepts strings. + * @expectedExceptionMessage Symfony\Component\Process\Process::setInput only accepts strings. */ - public function testInvalidStdin($value) + public function testInvalidInput($value) { $process = $this->getProcess('php -v'); - $process->setStdin($value); + $process->setInput($value); } - public function provideInvalidStdinValues() + public function provideInvalidInputValues() { return array( array(array()), @@ -193,16 +193,16 @@ abstract class AbstractProcessTest extends \PHPUnit_Framework_TestCase } /** - * @dataProvider provideStdinValues + * @dataProvider provideInputValues */ - public function testValidStdin($expected, $value) + public function testValidInput($expected, $value) { $process = $this->getProcess('php -v'); - $process->setStdin($value); - $this->assertSame($expected, $process->getStdin()); + $process->setInput($value); + $this->assertSame($expected, $process->getInput()); } - public function provideStdinValues() + public function provideInputValues() { return array( array(null, null), diff --git a/src/Symfony/Component/Process/Tests/SigchildDisabledProcessTest.php b/src/Symfony/Component/Process/Tests/SigchildDisabledProcessTest.php index 252098ec4c..d0a0f25d18 100644 --- a/src/Symfony/Component/Process/Tests/SigchildDisabledProcessTest.php +++ b/src/Symfony/Component/Process/Tests/SigchildDisabledProcessTest.php @@ -230,9 +230,9 @@ class SigchildDisabledProcessTest extends AbstractProcessTest /** * {@inheritdoc} */ - protected function getProcess($commandline, $cwd = null, array $env = null, $stdin = null, $timeout = 60, array $options = array()) + protected function getProcess($commandline, $cwd = null, array $env = null, $input = null, $timeout = 60, array $options = array()) { - $process = new ProcessInSigchildEnvironment($commandline, $cwd, $env, $stdin, $timeout, $options); + $process = new ProcessInSigchildEnvironment($commandline, $cwd, $env, $input, $timeout, $options); $process->setEnhanceSigchildCompatibility(false); return $process; diff --git a/src/Symfony/Component/Process/Tests/SigchildEnabledProcessTest.php b/src/Symfony/Component/Process/Tests/SigchildEnabledProcessTest.php index 65dd4bb573..05b9dad6af 100644 --- a/src/Symfony/Component/Process/Tests/SigchildEnabledProcessTest.php +++ b/src/Symfony/Component/Process/Tests/SigchildEnabledProcessTest.php @@ -123,9 +123,9 @@ class SigchildEnabledProcessTest extends AbstractProcessTest /** * {@inheritdoc} */ - protected function getProcess($commandline, $cwd = null, array $env = null, $stdin = null, $timeout = 60, array $options = array()) + protected function getProcess($commandline, $cwd = null, array $env = null, $input = null, $timeout = 60, array $options = array()) { - $process = new ProcessInSigchildEnvironment($commandline, $cwd, $env, $stdin, $timeout, $options); + $process = new ProcessInSigchildEnvironment($commandline, $cwd, $env, $input, $timeout, $options); $process->setEnhanceSigchildCompatibility(true); return $process;