diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Doctrine Bridge] Check field type before adding Length constraint

Browse Source
This commit is contained in:
Franco Traversaro 2019-06-05 16:31:24 +02:00 committed by Christian Flothmann
parent e5b082acee
commit 35e6df6bac
3 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Symfony/Bridge/Doctrine/Tests/Fixtures/DoctrineLoaderEntity.php
View File

@ -60,4 +60,13 @@ class DoctrineLoaderEntity extends DoctrineLoaderParentEntity
* @ORM\Embedded(class=DoctrineLoaderEmbed::class)
*/
public $embedded;
/** @ORM\Column(type="text", nullable=true, length=1000) */
public $textField;
/** @ORM\Id @ORM\Column(type="guid", length=50) */
protected $guidField;
/** @ORM\Column(type="simple_array", length=100) */
public $simpleArrayField = [];
}

10
src/Symfony/Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php
View File

@ -108,6 +108,16 @@ class DoctrineLoaderTest extends TestCase
$this->assertCount(1, $embeddedMaxLengthConstraints);
$this->assertInstanceOf(Length::class, $embeddedMaxLengthConstraints[0]);
$this->assertSame(25, $embeddedMaxLengthConstraints[0]->max);
$this->assertCount(0, $classMetadata->getPropertyMetadata('guidField'));
$this->assertCount(0, $classMetadata->getPropertyMetadata('simpleArrayField'));
$textFieldMetadata = $classMetadata->getPropertyMetadata('textField');
$this->assertCount(1, $textFieldMetadata);
$textFieldConstraints = $textFieldMetadata[0]->getConstraints();
$this->assertCount(1, $textFieldConstraints);
$this->assertInstanceOf(Length::class, $textFieldConstraints[0]);
$this->assertSame(1000, $textFieldConstraints[0]->max);
}
public function testFieldMappingsConfiguration()

2
src/Symfony/Bridge/Doctrine/Validator/DoctrineLoader.php
View File

@ -73,7 +73,7 @@ final class DoctrineLoader implements LoaderInterface
$metadata->addConstraint(new UniqueEntity(['fields' => $mapping['fieldName']]));
}
if (null === ($mapping['length'] ?? null)) {
if (null === ($mapping['length'] ?? null) || !\in_array($mapping['type'], ['string', 'text'], true)) {
continue;
}