diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PropertyInfo] Fix breaking change with has*(arguments...) methods

Browse Source
This commit is contained in:
YaFou 2021-01-19 20:11:07 +01:00
parent 6510b047e6
commit 37cc16e3d8
No known key found for this signature in database
GPG Key ID: A112DE339CED408A
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php
View File

@ -239,7 +239,7 @@ class ReflectionExtractor implements PropertyListExtractorInterface, PropertyTyp
foreach ($this->accessorPrefixes as $prefix) { foreach ($this->accessorPrefixes as $prefix) {
$methodName = $prefix.$camelProp; $methodName = $prefix.$camelProp;
if ($reflClass->hasMethod($methodName) && ($reflClass->getMethod($methodName)->getModifiers() & $this->methodReflectionFlags)) { if ($reflClass->hasMethod($methodName) && $reflClass->getMethod($methodName)->getModifiers() & $this->methodReflectionFlags && !$reflClass->getMethod($methodName)->getNumberOfRequiredParameters()) {
$method = $reflClass->getMethod($methodName); $method = $reflClass->getMethod($methodName);
return new PropertyReadInfo(PropertyReadInfo::TYPE_METHOD, $methodName, $this->getReadVisiblityForMethod($method), $method->isStatic(), false); return new PropertyReadInfo(PropertyReadInfo::TYPE_METHOD, $methodName, $this->getReadVisiblityForMethod($method), $method->isStatic(), false);

2
src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php
View File

@ -75,6 +75,7 @@ class ReflectionExtractorTest extends TestCase
'xTotals', 'xTotals',
'YT', 'YT',
'date', 'date',
'element',
'c', 'c',
'd', 'd',
'e', 'e',
@ -291,6 +292,7 @@ class ReflectionExtractorTest extends TestCase
['id', true], ['id', true],
['Guid', true], ['Guid', true],
['guid', false], ['guid', false],
['element', false],
]; ];
} }

6
src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php
View File

@ -130,6 +130,8 @@ class Dummy extends ParentDummy
*/ */
public $nestedIterators; public $nestedIterators;
private $elements;
public static function getStatic() public static function getStatic()
{ {
} }
@ -218,4 +220,8 @@ class Dummy extends ParentDummy
public function addDate(\DateTime $date) public function addDate(\DateTime $date)
{ {
} }
public function hasElement(string $element): bool
{
}
} }