diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #38168 [HttpFoundation] Skip the cookie_max_age fixture on PHP 8 (derrabus) 

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] Skip the cookie_max_age fixture on PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

This PR suggest to skip a certain integration test on php 8. The integration test in question triggers a warning by setting a way too high expiration date when calling `setcookie()`. Apparently, this warning has been upgraded to a fatal error on php 8.

Since the integration test is run in a separate process, we might as well adjust the expectation of that test case, but I don't really see the point in asserting fatal error behavior, to be honest.

Commits
-------

d6d9b2927d [HttpFoundation] Skip the cookie_max_age fixture on PHP 8.
This commit is contained in:
Fabien Potencier 2020-09-13 06:52:13 +02:00
parent 4b3015ff5f d6d9b2927d
commit 3825542c02
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/HttpFoundation/Tests/ResponseFunctionalTest.php
View File

@ -45,6 +45,10 @@ class ResponseFunctionalTest extends TestCase
*/
public function testCookie($fixture)
{
if (\PHP_VERSION_ID >= 80000 && 'cookie_max_age' === $fixture) {
$this->markTestSkipped('This fixture produces a fatal error on PHP 8.');
}
$result = file_get_contents(sprintf('http://localhost:8054/%s.php', $fixture));
$this->assertStringMatchesFormatFile(__DIR__.sprintf('/Fixtures/response-functional/%s.expected', $fixture), $result);
}